drm/i915/gem: fix non-SMP build failure

Message ID 20210125122542.4144849-1-arnd@kernel.org
State New
Headers show
Series
  • drm/i915/gem: fix non-SMP build failure
Related show

Commit Message

Arnd Bergmann Jan. 25, 2021, 12:25 p.m.
From: Arnd Bergmann <arnd@arndb.de>


The x86-specific wbinvd_on_all_cpus() function is exported
through asm/smp.h, causing a build failure in the i915 driver
when SMP is disabled:

drivers/gpu/drm/i915/i915_gem.c:1182:2: error: implicit declaration of function 'wbinvd_on_all_cpus' [-Werror,-Wimplicit-function-declaration]

Include that header file explicitly.

Fixes: 30d2bfd09383 ("drm/i915/gem: Almagamate clflushes on freeze")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/gpu/drm/i915/i915_gem.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.29.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Comments

Chris Wilson Jan. 25, 2021, 12:34 p.m. | #1
Quoting Arnd Bergmann (2021-01-25 12:25:34)
> From: Arnd Bergmann <arnd@arndb.de>

> 

> The x86-specific wbinvd_on_all_cpus() function is exported

> through asm/smp.h, causing a build failure in the i915 driver

> when SMP is disabled:

> 

> drivers/gpu/drm/i915/i915_gem.c:1182:2: error: implicit declaration of function 'wbinvd_on_all_cpus' [-Werror,-Wimplicit-function-declaration]


I thought the code was already in i915_gem_pm.c (which included smp.h);
it is now.
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Patch

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 9b04dff5eb32..2a1643514577 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -36,6 +36,7 @@ 
 #include <linux/pci.h>
 #include <linux/dma-buf.h>
 #include <linux/mman.h>
+#include <asm/smp.h>
 
 #include "display/intel_display.h"
 #include "display/intel_frontbuffer.h"