diff mbox series

Input: iqs5xx - initialize an uninitialized variable

Message ID 1611592500-32209-1-git-send-email-jeff@labundy.com
State Accepted
Commit 7a6a53b2b1a3e68b69cd75a74783f4d8fd5b6fb5
Headers show
Series Input: iqs5xx - initialize an uninitialized variable | expand

Commit Message

Jeff LaBundy Jan. 25, 2021, 4:35 p.m. UTC 
If execution jumps to the err_kfree label, error_bl is evaluated
before it is initialized. Fix this by initializing it to zero.

Fixes: 2539da6677b6 ("Input: iqs5xx - preserve bootloader errors")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jeff LaBundy <jeff@labundy.com>
---
 drivers/input/touchscreen/iqs5xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dmitry Torokhov Jan. 25, 2021, 6:13 p.m. UTC | #1 
On Mon, Jan 25, 2021 at 10:35:00AM -0600, Jeff LaBundy wrote:
> If execution jumps to the err_kfree label, error_bl is evaluated
> before it is initialized. Fix this by initializing it to zero.
> 
> Fixes: 2539da6677b6 ("Input: iqs5xx - preserve bootloader errors")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Jeff LaBundy <jeff@labundy.com>

Applied, thank you.
diff mbox series

Patch

diff --git a/drivers/input/touchscreen/iqs5xx.c b/drivers/input/touchscreen/iqs5xx.c
index 05e0c6f..54f3003 100644
--- a/drivers/input/touchscreen/iqs5xx.c
+++ b/drivers/input/touchscreen/iqs5xx.c
@@ -852,7 +852,7 @@  static int iqs5xx_fw_file_parse(struct i2c_client *client,
 static int iqs5xx_fw_file_write(struct i2c_client *client, const char *fw_file)
 {
 	struct iqs5xx_private *iqs5xx = i2c_get_clientdata(client);
-	int error, error_bl;
+	int error, error_bl = 0;
 	u8 *pmap;
 
 	if (iqs5xx->bl_status == IQS5XX_BL_STATUS_NONE)