| Message ID | 1611648783-3916-1-git-send-email-abaci-bugfix@linux.alibaba.com |
|---|---|
| State | New |
| Headers | show |
| Series | rocker: Simplify the calculation of variables | expand |
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 26 Jan 2021 16:13:03 +0800 you wrote: > Fix the following coccicheck warnings: > > ./drivers/net/ethernet/rocker/rocker_ofdpa.c:926:34-36: WARNING !A || A > && B is equivalent to !A || B. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> > > [...] Here is the summary with links: - rocker: Simplify the calculation of variables https://git.kernel.org/netdev/net-next/c/1d96006dccf0 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/rocker/rocker_ofdpa.c b/drivers/net/ethernet/rocker/rocker_ofdpa.c index 7072b24..e2d5962 100644 --- a/drivers/net/ethernet/rocker/rocker_ofdpa.c +++ b/drivers/net/ethernet/rocker/rocker_ofdpa.c @@ -923,7 +923,7 @@ static int ofdpa_flow_tbl_bridge(struct ofdpa_port *ofdpa_port, struct ofdpa_flow_tbl_entry *entry; u32 priority; bool vlan_bridging = !!vlan_id; - bool dflt = !eth_dst || (eth_dst && eth_dst_mask); + bool dflt = !eth_dst || eth_dst_mask; bool wild = false; entry = kzalloc(sizeof(*entry), GFP_ATOMIC);
Fix the following coccicheck warnings: ./drivers/net/ethernet/rocker/rocker_ofdpa.c:926:34-36: WARNING !A || A && B is equivalent to !A || B. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> --- drivers/net/ethernet/rocker/rocker_ofdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)