diff mbox series

[1/2] brcmfmac: Add DMI nvram filename quirk for Predia Basic tablet

Message ID 20210129171413.139880-1-hdegoede@redhat.com
State New
Headers show
Series [1/2] brcmfmac: Add DMI nvram filename quirk for Predia Basic tablet | expand

Commit Message

Hans de Goede Jan. 29, 2021, 5:14 p.m. UTC
The Predia Basic tablet contains quite generic names in the sys_vendor and
product_name DMI strings, without this patch brcmfmac will try to load:
brcmfmac43340-sdio.Insyde-CherryTrail.txt as nvram file which is a bit
too generic.

Add a DMI quirk so that a unique and clearly identifiable nvram file name
is used on the Predia Basic tablet.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 .../net/wireless/broadcom/brcm80211/brcmfmac/dmi.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Kalle Valo Feb. 8, 2021, 11:03 a.m. UTC | #1
Hans de Goede <hdegoede@redhat.com> wrote:

> The Predia Basic tablet contains quite generic names in the sys_vendor and

> product_name DMI strings, without this patch brcmfmac will try to load:

> brcmfmac43340-sdio.Insyde-CherryTrail.txt as nvram file which is a bit

> too generic.

> 

> Add a DMI quirk so that a unique and clearly identifiable nvram file name

> is used on the Predia Basic tablet.

> 

> Signed-off-by: Hans de Goede <hdegoede@redhat.com>


2 patches applied to wireless-drivers-next.git, thanks.

af4b3a6f36d6 brcmfmac: Add DMI nvram filename quirk for Predia Basic tablet
a338c874d3d9 brcmfmac: Add DMI nvram filename quirk for Voyo winpad A15 tablet

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210129171413.139880-1-hdegoede@redhat.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
diff mbox series

Patch

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c
index 4aa2561934d7..824a79f24383 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c
@@ -40,6 +40,10 @@  static const struct brcmf_dmi_data pov_tab_p1006w_data = {
 	BRCM_CC_43340_CHIP_ID, 2, "pov-tab-p1006w-data"
 };
 
+static const struct brcmf_dmi_data predia_basic_data = {
+	BRCM_CC_43341_CHIP_ID, 2, "predia-basic"
+};
+
 static const struct dmi_system_id dmi_platform_data[] = {
 	{
 		/* ACEPC T8 Cherry Trail Z8350 mini PC */
@@ -111,6 +115,16 @@  static const struct dmi_system_id dmi_platform_data[] = {
 		},
 		.driver_data = (void *)&pov_tab_p1006w_data,
 	},
+	{
+		/* Predia Basic tablet (+ with keyboard dock) */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Insyde"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "CherryTrail"),
+			/* Mx.WT107.KUBNGEA02 with the version-nr dropped */
+			DMI_MATCH(DMI_BIOS_VERSION, "Mx.WT107.KUBNGEA"),
+		},
+		.driver_data = (void *)&predia_basic_data,
+	},
 	{}
 };