| Message ID | 1410803758-26906-1-git-send-email-nm@ti.com |
|---|---|
| State | New |
| Headers | show |
diff --git a/drivers/input/misc/palmas-pwrbutton.c b/drivers/input/misc/palmas-pwrbutton.c index 4ed6f78..c0c4636 100644 --- a/drivers/input/misc/palmas-pwrbutton.c +++ b/drivers/input/misc/palmas-pwrbutton.c @@ -211,8 +211,8 @@ static int palmas_pwron_probe(struct platform_device *pdev) pwron->irq = platform_get_irq(pdev, 0); error = request_threaded_irq(pwron->irq, NULL, pwron_irq, - IRQF_TRIGGER_HIGH | IRQF_TRIGGER_LOW, - dev_name(dev), pwron); + IRQF_TRIGGER_HIGH | IRQF_TRIGGER_LOW | + IRQF_ONESHOT, dev_name(dev), pwron); if (error) { dev_err(dev, "Can't get IRQ for pwron: %d\n", error); goto err_free_input;
make C=2 CHECK="scripts/coccicheck" MODE=report COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci ./drivers/input/misc/palmas-pwrbutton.o Reports: drivers/input/misc/palmas-pwrbutton.c:213:9-29: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Palmas powerbutton just needs threaded IRQ handler since I2C operations are involved and there is nothing in non-threaded primary handler we could do. So mark the request with ONESHOT as it should have been done in these cases. Cc: Julia Lawal <julia.lawall@lip6.fr> Cc: Dan Carpenter <dan.carpenter@oracle.com> Fixes: adff5962fdd2 ("Input: introduce palmas-pwrbutton") Reported-by: kbuild test robot <fengguang.wu@intel.com> Signed-off-by: Nishanth Menon <nm@ti.com> --- drivers/input/misc/palmas-pwrbutton.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)