diff mbox series

[net,1/4] net: ipa: add a missing __iomem attribute

Message ID 20210201232609.3524451-2-elder@linaro.org
State New
Headers show
Series net: ipa: a few bug fixes | expand

Commit Message

Alex Elder Feb. 1, 2021, 11:26 p.m. UTC 
The virt local variable in gsi_channel_state() does not have an
__iomem attribute but should.  Fix this.

Signed-off-by: Alex Elder <elder@linaro.org>

---
 drivers/net/ipa/gsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.27.0

Comments

Amy Parker Feb. 2, 2021, 12:09 a.m. UTC | #1 
On Mon, Feb 1, 2021 at 3:29 PM Alex Elder <elder@linaro.org> wrote:
>
> The virt local variable in gsi_channel_state() does not have an
> __iomem attribute but should.  Fix this.
>
> Signed-off-by: Alex Elder <elder@linaro.org>
> ---
>  drivers/net/ipa/gsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c
> index 14d9a791924bf..e2e77f09077a9 100644
> --- a/drivers/net/ipa/gsi.c
> +++ b/drivers/net/ipa/gsi.c
> @@ -440,7 +440,7 @@ static void gsi_evt_ring_de_alloc_command(struct gsi *gsi, u32 evt_ring_id)
>  static enum gsi_channel_state gsi_channel_state(struct gsi_channel *channel)
>  {
>         u32 channel_id = gsi_channel_id(channel);
> -       void *virt = channel->gsi->virt;
> +       void __iomem *virt = channel->gsi->virt;
>         u32 val;
>
>         val = ioread32(virt + GSI_CH_C_CNTXT_0_OFFSET(channel_id));
> --
> 2.27.0
>

Seems pretty straightforward to me, ioread32 expects an
__iomem-annotated pointer.

Reviewed-by: Amy Parker <enbyamy@gmail.com>
diff mbox series

Patch

diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c
index 14d9a791924bf..e2e77f09077a9 100644
--- a/drivers/net/ipa/gsi.c
+++ b/drivers/net/ipa/gsi.c
@@ -440,7 +440,7 @@  static void gsi_evt_ring_de_alloc_command(struct gsi *gsi, u32 evt_ring_id)
 static enum gsi_channel_state gsi_channel_state(struct gsi_channel *channel)
 {
 	u32 channel_id = gsi_channel_id(channel);
-	void *virt = channel->gsi->virt;
+	void __iomem *virt = channel->gsi->virt;
 	u32 val;
 
 	val = ioread32(virt + GSI_CH_C_CNTXT_0_OFFSET(channel_id));