diff mbox series

[11/18] arm64: dts: qcom: msm8994-octagon: Add uSD card and disable HS400 on eMMC

Message ID 20210131013853.55810-12-konrad.dybcio@somainline.org
State New
Headers show
Series 8992/4/Lumia 950/XL DTS updates | expand

Commit Message

Konrad Dybcio Jan. 31, 2021, 1:38 a.m. UTC
From: Gustave Monce <gustave.monce@outlook.com>

Lumia 950/XL, like other phones, ship with different storage chips.
Some of them are not capable of stable operation at HS400. Disable it.

Signed-off-by: Gustave Monce <gustave.monce@outlook.com>
Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
---
 .../dts/qcom/msm8994-msft-lumia-octagon.dtsi  | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)

Comments

Pavel Machek Feb. 18, 2021, 1:41 p.m. UTC | #1
On Sun 2021-01-31 02:38:42, Konrad Dybcio wrote:
> From: Gustave Monce <gustave.monce@outlook.com>

> 

> Lumia 950/XL, like other phones, ship with different storage chips.

> Some of them are not capable of stable operation at HS400. Disable it.

> 

> Signed-off-by: Gustave Monce <gustave.monce@outlook.com>

> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>

> ---

>  .../dts/qcom/msm8994-msft-lumia-octagon.dtsi  | 21 +++++++++++++++++++

>  1 file changed, 21 insertions(+)

> 

> diff --git a/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi b/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi

> index bf6e63a23600..004a42261cef 100644

> --- a/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi

> +++ b/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi

> @@ -684,6 +684,27 @@ vph_pwr_bbyp: boost-bypass {

>  

>  &sdhc1 {

>  	status = "okay";

> +

> +	/*

> +	 * This device is shipped with HS400 capabable eMMCs


Typo, should be "capable"?

> +	 * However various brands have been used in various product batches,

> +	 * including a Samsung eMMC (BGND3R) which features a quirk with HS400.

> +	 * Set the speed to HS200 as a safety measure.

> +	 */


And this makes little sense. "This device is often shipped..."?

Best regards,
									Pavel

-- 
http://www.livejournal.com/~pavelmachek
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi b/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi
index bf6e63a23600..004a42261cef 100644
--- a/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi
@@ -684,6 +684,27 @@  vph_pwr_bbyp: boost-bypass {
 
 &sdhc1 {
 	status = "okay";
+
+	/*
+	 * This device is shipped with HS400 capabable eMMCs
+	 * However various brands have been used in various product batches,
+	 * including a Samsung eMMC (BGND3R) which features a quirk with HS400.
+	 * Set the speed to HS200 as a safety measure.
+	 */
+	mmc-hs200-1_8v;
+};
+
+&sdhc2 {
+	status = "okay";
+
+	pinctrl-names = "default", "sleep";
+	pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on>;
+	pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off>;
+
+	vmmc-supply = <&vreg_l21a_2p95>;
+	vqmmc-supply = <&vreg_l13a_2p95>;
+
+	cd-gpios = <&pm8994_gpios 8 GPIO_ACTIVE_LOW>;
 };
 
 &tlmm {