diff mbox series

drivers: net: xen-netfront: Simplify the calculation of variables

Message ID 1612261069-13315-1-git-send-email-jiapeng.chong@linux.alibaba.com
State New
Headers show
Series drivers: net: xen-netfront: Simplify the calculation of variables | expand

Commit Message

Jiapeng Chong Feb. 2, 2021, 10:17 a.m. UTC
Fix the following coccicheck warnings:

./drivers/net/xen-netfront.c:1816:52-54: WARNING !A || A && B is
equivalent to !A || B.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/net/xen-netfront.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Juergen Gross Feb. 4, 2021, 11:09 a.m. UTC | #1
On 02.02.21 11:17, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:

> 

> ./drivers/net/xen-netfront.c:1816:52-54: WARNING !A || A && B is

> equivalent to !A || B.

> 

> Reported-by: Abaci Robot <abaci@linux.alibaba.com>

> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>


Reviewed-by: Juergen Gross <jgross@suse.com>



Juergen
patchwork-bot+netdevbpf@kernel.org Feb. 4, 2021, 7:40 p.m. UTC | #2
Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue,  2 Feb 2021 18:17:49 +0800 you wrote:
> Fix the following coccicheck warnings:

> 

> ./drivers/net/xen-netfront.c:1816:52-54: WARNING !A || A && B is

> equivalent to !A || B.

> 

> Reported-by: Abaci Robot <abaci@linux.alibaba.com>

> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

> 

> [...]


Here is the summary with links:
  - drivers: net: xen-netfront: Simplify the calculation of variables
    https://git.kernel.org/netdev/net-next/c/e93fac3b5161

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index b01848e..5158841 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1813,7 +1813,7 @@  static int setup_netfront(struct xenbus_device *dev,
 	 *  a) feature-split-event-channels == 0
 	 *  b) feature-split-event-channels == 1 but failed to setup
 	 */
-	if (!feature_split_evtchn || (feature_split_evtchn && err))
+	if (!feature_split_evtchn || err)
 		err = setup_netfront_single(queue);
 
 	if (err)