| Message ID | 20210204180313.108876-1-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Commit | 43851904cbd7c7bb18c84cc553b6232ace23747b |
| Headers | show |
| Series | phy: qcom-qmp: make a const array static, makes object smaller | expand |
On 04-02-21, 18:03, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Don't populate the const array cfg1_settings on the stack but instead make > it static. Makes the object code smaller by 24 bytes: > > Before: > text data bss dec hex filename > 73585 20240 64 93889 16ec1 drivers/phy/qualcomm/phy-qcom-qmp.o > > After: > text data bss dec hex filename > 73465 20336 64 93865 16ea9 drivers/phy/qualcomm/phy-qcom-qmp.o > > (gcc version 10.2.0) Applied, thanks -- ~Vinod
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Thu, 4 Feb 2021 18:03:13 +0000 you wrote: > From: Colin Ian King <colin.king@canonical.com> > > Don't populate the const array cfg1_settings on the stack but instead make > it static. Makes the object code smaller by 24 bytes: > > Before: > text data bss dec hex filename > 73585 20240 64 93889 16ec1 drivers/phy/qualcomm/phy-qcom-qmp.o > > [...] Here is the summary with links: - phy: qcom-qmp: make a const array static, makes object smaller https://git.kernel.org/qcom/c/43851904cbd7 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index a679b5fb7b48..d0dfb6743965 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -3421,7 +3421,7 @@ static int qcom_qmp_phy_configure_dp_phy(struct qmp_phy *qphy) static int qcom_qmp_dp_phy_calibrate(struct phy *phy) { struct qmp_phy *qphy = phy_get_drvdata(phy); - const u8 cfg1_settings[] = { 0x13, 0x23, 0x1d }; + static const u8 cfg1_settings[] = { 0x13, 0x23, 0x1d }; u8 val; qphy->dp_aux_cfg++;