| Message ID | 0877601216922E4B83A7129715B5DA2BBE7474DF31@GEORGE.Emea.Arm.com |
|---|---|
| State | New |
| Headers | show |
Reviewed-by: Eric Dong <eric.dong@intel.com> -----Original Message----- From: Olivier Martin [mailto:Olivier.Martin@arm.com] Sent: Saturday, September 20, 2014 7:02 AM To: Fan, Jeff Cc: edk2-devel@lists.sourceforge.net Subject: [edk2] [PATCH] IntelFrameworkModulePkg/BdsDxe: Removed unused variables Dear IntelFrameworkModulePkg maintainer, please find the attached patch that removes some unused assigned variables. Some compiler (GCC in this case) raises a warning/error. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Olivier Martin <olivier.martin@arm.com> Regards, Olivier -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782 ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
Checked in code at R16187. Thanks, Eric -----Original Message----- From: Dong, Eric [mailto:eric.dong@intel.com] Sent: Monday, September 22, 2014 2:25 PM To: edk2-devel@lists.sourceforge.net; Fan, Jeff Subject: Re: [edk2] [PATCH] IntelFrameworkModulePkg/BdsDxe: Removed unused variables Reviewed-by: Eric Dong <eric.dong@intel.com> -----Original Message----- From: Olivier Martin [mailto:Olivier.Martin@arm.com] Sent: Saturday, September 20, 2014 7:02 AM To: Fan, Jeff Cc: edk2-devel@lists.sourceforge.net Subject: [edk2] [PATCH] IntelFrameworkModulePkg/BdsDxe: Removed unused variables Dear IntelFrameworkModulePkg maintainer, please find the attached patch that removes some unused assigned variables. Some compiler (GCC in this case) raises a warning/error. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Olivier Martin <olivier.martin@arm.com> Regards, Olivier -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782 ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
From 607704f7ee892cc9dc8bf1535acf23a691fac212 Mon Sep 17 00:00:00 2001 From: Olivier Martin <olivier.martin@arm.com> Date: Fri, 19 Sep 2014 22:27:00 +0100 Subject: IntelFrameworkModulePkg/BdsDxe: Removed unused variables Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Olivier Martin <olivier.martin@arm.com> --- .../Universal/BdsDxe/BootMaint/UpdatePage.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/UpdatePage.c b/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/UpdatePage.c index 20e17dd..7d5861e 100644 --- a/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/UpdatePage.c +++ b/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/UpdatePage.c @@ -543,7 +543,6 @@ UpdateOrderPage ( UINT16 Index; UINT16 OptionIndex; VOID *OptionsOpCodeHandle; - BM_LOAD_CONTEXT *NewLoadContext; BOOLEAN BootOptionFound; UINT32 *OptionOrder; EFI_QUESTION_ID QuestionId; @@ -583,7 +582,6 @@ UpdateOrderPage ( BootOptionFound = FALSE; for (Index = 0; Index < OptionMenu->MenuNumber; Index++) { NewMenuEntry = BOpt_GetMenuEntry (OptionMenu, Index); - NewLoadContext = (BM_LOAD_CONTEXT *) NewMenuEntry->VariableContext; if ((UINT32) (NewMenuEntry->OptionNumber + 1) == OptionOrder[OptionIndex]) { BootOptionFound = TRUE; break; @@ -892,7 +890,6 @@ UpdateTerminalPage ( UINT8 Index; UINT8 CheckFlags; BM_MENU_ENTRY *NewMenuEntry; - BM_TERMINAL_CONTEXT *NewTerminalContext; VOID *OptionsOpCodeHandle; UINTN CurrentTerminal; @@ -908,8 +905,6 @@ UpdateTerminalPage ( return ; } - NewTerminalContext = (BM_TERMINAL_CONTEXT *) NewMenuEntry->VariableContext; - OptionsOpCodeHandle = HiiAllocateOpCodeHandle (); ASSERT (OptionsOpCodeHandle != NULL); -- 1.7.5.4
Dear IntelFrameworkModulePkg maintainer, please find the attached patch that removes some unused assigned variables. Some compiler (GCC in this case) raises a warning/error. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Olivier Martin <olivier.martin@arm.com> Regards, Olivier -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782 ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that Matters. http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk