diff mbox series

[for-next,30/32] scsi: vmw_pvscsi: Replace spin_lock_irqsave with spin_lock in hard IRQ

Message ID 1612697823-8073-31-git-send-email-tanxiaofei@huawei.com
State New
Headers show
Series spin lock usage optimization for SCSI drivers | expand

Commit Message

Xiaofei Tan Feb. 7, 2021, 11:37 a.m. UTC
It is redundant to do irqsave and irqrestore in hardIRQ context, where
it has been in a irq-disabled context.

Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
---
 drivers/scsi/vmw_pvscsi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
index 081f54a..2994b3a 100644
--- a/drivers/scsi/vmw_pvscsi.c
+++ b/drivers/scsi/vmw_pvscsi.c
@@ -1180,11 +1180,11 @@  static irqreturn_t pvscsi_isr(int irq, void *devp)
 	struct pvscsi_adapter *adapter = devp;
 	unsigned long flags;
 
-	spin_lock_irqsave(&adapter->hw_lock, flags);
+	spin_lock(&adapter->hw_lock);
 	pvscsi_process_completion_ring(adapter);
 	if (adapter->use_msg && pvscsi_msg_pending(adapter))
 		queue_work(adapter->workqueue, &adapter->work);
-	spin_unlock_irqrestore(&adapter->hw_lock, flags);
+	spin_unlock(&adapter->hw_lock);
 
 	return IRQ_HANDLED;
 }