diff mbox

Adding selftest testdata dynamically into live tree

Message ID 20140926120917.B60B4C40FEB@trevor.secretlab.ca
State New
Headers show

Commit Message

Grant Likely Sept. 26, 2014, 12:09 p.m. UTC
On Mon, 22 Sep 2014 20:05:37 +0200, Janusz UĹźycki <j.uzycki@elproma.com.pl> wrote:
> Hi.
> 
> On 3.17.0-rc6-next-20140922+ with CONFIG_OF_SELFTEST enabled
> zImage is recreated every time I call "make" despite I've not done
> any change in source files and zImage was the same.
> This is caused by the rm line:
>    CALL    scripts/checksyscalls.sh
>    CHK     include/generated/compile.h
>    DTC     drivers/of/testcase-data/testcases.dtb
>    DTB     drivers/of/testcase-data/testcases.dtb.S
>    AS      drivers/of/testcase-data/testcases.dtb.o
>    LD      drivers/of/of_selftest.o
>    LD      drivers/of/built-in.o
> rm drivers/of/testcase-data/testcases.dtb.S 
> drivers/of/testcase-data/testcases.dtb
>    LD      drivers/built-in.o
>    LINK    vmlinux
>    LD      vmlinux.o

Try this change:


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Janusz Użycki Sept. 26, 2014, 1:36 p.m. UTC | #1
The patch didn't help. Exactly the same.

best regards
Janusz

W dniu 2014-09-26 14:09, Grant Likely pisze:
> On Mon, 22 Sep 2014 20:05:37 +0200, Janusz Użycki <j.uzycki@elproma.com.pl> wrote:
>> Hi.
>>
>> On 3.17.0-rc6-next-20140922+ with CONFIG_OF_SELFTEST enabled
>> zImage is recreated every time I call "make" despite I've not done
>> any change in source files and zImage was the same.
>> This is caused by the rm line:
>>     CALL    scripts/checksyscalls.sh
>>     CHK     include/generated/compile.h
>>     DTC     drivers/of/testcase-data/testcases.dtb
>>     DTB     drivers/of/testcase-data/testcases.dtb.S
>>     AS      drivers/of/testcase-data/testcases.dtb.o
>>     LD      drivers/of/of_selftest.o
>>     LD      drivers/of/built-in.o
>> rm drivers/of/testcase-data/testcases.dtb.S
>> drivers/of/testcase-data/testcases.dtb
>>     LD      drivers/built-in.o
>>     LINK    vmlinux
>>     LD      vmlinux.o
> Try this change:
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 260bf8acfce9..4555e2e1b4ed 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -269,7 +269,7 @@ cmd_dtc = $(CPP) $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) $< ; \
>   		-d $(depfile).dtc.tmp $(dtc-tmp) ; \
>   	cat $(depfile).pre.tmp $(depfile).dtc.tmp > $(depfile)
>   
> -$(obj)/%.dtb: $(src)/%.dts FORCE
> +$(obj)/%.dtb: $(src)/%.dts
>   	$(call if_changed_dep,dtc)
>   
>   dtc-tmp = $(subst $(comma),_,$(dot-target).dts.tmp)
>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Grant Likely Sept. 26, 2014, 3:07 p.m. UTC | #2
On Fri, Sep 26, 2014 at 2:36 PM, Janusz Użycki <j.uzycki@elproma.com.pl> wrote:
> The patch didn't help. Exactly the same.

Odd it worked here. It's moot anyway though because it breaks checking
dependencies on .dts files. I need someone stronger on kbuild-foo to
figure this out out. I've cc'd Michal and the kbuild mailing list.
Hopefully someone there can help figure this out.

g.

>
> best regards
> Janusz
>
> W dniu 2014-09-26 14:09, Grant Likely pisze:
>
>> On Mon, 22 Sep 2014 20:05:37 +0200, Janusz Użycki
>> <j.uzycki@elproma.com.pl> wrote:
>>>
>>> Hi.
>>>
>>> On 3.17.0-rc6-next-20140922+ with CONFIG_OF_SELFTEST enabled
>>> zImage is recreated every time I call "make" despite I've not done
>>> any change in source files and zImage was the same.
>>> This is caused by the rm line:
>>>     CALL    scripts/checksyscalls.sh
>>>     CHK     include/generated/compile.h
>>>     DTC     drivers/of/testcase-data/testcases.dtb
>>>     DTB     drivers/of/testcase-data/testcases.dtb.S
>>>     AS      drivers/of/testcase-data/testcases.dtb.o
>>>     LD      drivers/of/of_selftest.o
>>>     LD      drivers/of/built-in.o
>>> rm drivers/of/testcase-data/testcases.dtb.S
>>> drivers/of/testcase-data/testcases.dtb
>>>     LD      drivers/built-in.o
>>>     LINK    vmlinux
>>>     LD      vmlinux.o
>>
>> Try this change:
>>
>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>> index 260bf8acfce9..4555e2e1b4ed 100644
>> --- a/scripts/Makefile.lib
>> +++ b/scripts/Makefile.lib
>> @@ -269,7 +269,7 @@ cmd_dtc = $(CPP) $(dtc_cpp_flags) -x
>> assembler-with-cpp -o $(dtc-tmp) $< ; \
>>                 -d $(depfile).dtc.tmp $(dtc-tmp) ; \
>>         cat $(depfile).pre.tmp $(depfile).dtc.tmp > $(depfile)
>>   -$(obj)/%.dtb: $(src)/%.dts FORCE
>> +$(obj)/%.dtb: $(src)/%.dts
>>         $(call if_changed_dep,dtc)
>>     dtc-tmp = $(subst $(comma),_,$(dot-target).dts.tmp)
>>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 260bf8acfce9..4555e2e1b4ed 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -269,7 +269,7 @@  cmd_dtc = $(CPP) $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) $< ; \
 		-d $(depfile).dtc.tmp $(dtc-tmp) ; \
 	cat $(depfile).pre.tmp $(depfile).dtc.tmp > $(depfile)
 
-$(obj)/%.dtb: $(src)/%.dts FORCE
+$(obj)/%.dtb: $(src)/%.dts
 	$(call if_changed_dep,dtc)
 
 dtc-tmp = $(subst $(comma),_,$(dot-target).dts.tmp)