diff mbox series

[v8,2/6] mfd: Support ROHM BD9576MUF and BD9573MUF

Message ID 560b9748094392493ebf7af11b6cc558776c4fd5.1613031055.git.matti.vaittinen@fi.rohmeurope.com
State Superseded
Headers show
Series Support ROHM BD9576MUF and BD9573MUF PMICs | expand

Commit Message

Vaittinen, Matti Feb. 11, 2021, 9:48 a.m. UTC 
Add core support for ROHM BD9576MUF and BD9573MUF PMICs which are
mainly used to power the R-Car series processors.

Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
---
Changes:
 - Comments fixed based on suggestions from Lee
 - Name of regulator cell changed as suggested by Lee
 - Renamed MFD cell variables for better readability
 - Aligned header definitions for better readability

 drivers/mfd/Kconfig              |  11 ++++
 drivers/mfd/Makefile             |   1 +
 drivers/mfd/rohm-bd9576.c        | 109 +++++++++++++++++++++++++++++++
 include/linux/mfd/rohm-bd957x.h  |  59 +++++++++++++++++
 include/linux/mfd/rohm-generic.h |   2 +
 5 files changed, 182 insertions(+)
 create mode 100644 drivers/mfd/rohm-bd9576.c
 create mode 100644 include/linux/mfd/rohm-bd957x.h

Comments

Lee Jones March 8, 2021, 1:36 p.m. UTC | #1 
On Thu, 11 Feb 2021, Matti Vaittinen wrote:

> Add core support for ROHM BD9576MUF and BD9573MUF PMICs which are

> mainly used to power the R-Car series processors.

> 

> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>

> ---

> Changes:

>  - Comments fixed based on suggestions from Lee

>  - Name of regulator cell changed as suggested by Lee

>  - Renamed MFD cell variables for better readability

>  - Aligned header definitions for better readability

> 

>  drivers/mfd/Kconfig              |  11 ++++

>  drivers/mfd/Makefile             |   1 +

>  drivers/mfd/rohm-bd9576.c        | 109 +++++++++++++++++++++++++++++++

>  include/linux/mfd/rohm-bd957x.h  |  59 +++++++++++++++++

>  include/linux/mfd/rohm-generic.h |   2 +

>  5 files changed, 182 insertions(+)

>  create mode 100644 drivers/mfd/rohm-bd9576.c

>  create mode 100644 include/linux/mfd/rohm-bd957x.h

> 

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig

> index bdfce7b15621..53c7c96283bd 100644

> --- a/drivers/mfd/Kconfig

> +++ b/drivers/mfd/Kconfig

> @@ -1998,6 +1998,17 @@ config MFD_ROHM_BD71828

>  	  Also included is a Coulomb counter, a real-time clock (RTC), and

>  	  a 32.768 kHz clock gate.

>  

> +config MFD_ROHM_BD957XMUF

> +	tristate "ROHM BD9576MUF and BD9573MUF Power Management ICs"

> +	depends on I2C=y

> +	depends on OF

> +	select REGMAP_I2C

> +	select MFD_CORE

> +	help

> +	  Select this option to get support for the ROHM BD9576MUF and

> +	  BD9573MUF Power Management ICs. BD9576 and BD9573 are primarily

> +	  designed to be used to power R-Car series processors.

> +

>  config MFD_STM32_LPTIMER

>  	tristate "Support for STM32 Low-Power Timer"

>  	depends on (ARCH_STM32 && OF) || COMPILE_TEST

> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile

> index 14fdb188af02..e58fae024bb2 100644

> --- a/drivers/mfd/Makefile

> +++ b/drivers/mfd/Makefile

> @@ -262,6 +262,7 @@ obj-$(CONFIG_RAVE_SP_CORE)	+= rave-sp.o

>  obj-$(CONFIG_MFD_ROHM_BD70528)	+= rohm-bd70528.o

>  obj-$(CONFIG_MFD_ROHM_BD71828)	+= rohm-bd71828.o

>  obj-$(CONFIG_MFD_ROHM_BD718XX)	+= rohm-bd718x7.o

> +obj-$(CONFIG_MFD_ROHM_BD957XMUF)	+= rohm-bd9576.o

>  obj-$(CONFIG_MFD_STMFX) 	+= stmfx.o

>  obj-$(CONFIG_MFD_KHADAS_MCU) 	+= khadas-mcu.o

>  

> diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c

> new file mode 100644

> index 000000000000..efd439677c9e

> --- /dev/null

> +++ b/drivers/mfd/rohm-bd9576.c

> @@ -0,0 +1,109 @@

> +// SPDX-License-Identifier: GPL-2.0-or-later

> +/*

> + * Copyright (C) 2020 ROHM Semiconductors


If you get a chance, could you please update these?

> + * ROHM BD9576MUF and BD9573MUF PMIC driver

> + */


For my own reference (apply this as-is to your sign-off block):

  Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Vaittinen, Matti March 8, 2021, 2:52 p.m. UTC | #2 
Hello Lee,

On Mon, 2021-03-08 at 13:36 +0000, Lee Jones wrote:
> On Thu, 11 Feb 2021, Matti Vaittinen wrote:

> 

> > Add core support for ROHM BD9576MUF and BD9573MUF PMICs which are

> > mainly used to power the R-Car series processors.

> > 

> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>

> > ---

> > Changes:

> >  - Comments fixed based on suggestions from Lee

> >  - Name of regulator cell changed as suggested by Lee

> >  - Renamed MFD cell variables for better readability

> >  - Aligned header definitions for better readability

> > 

> >  drivers/mfd/Kconfig              |  11 ++++

> >  drivers/mfd/Makefile             |   1 +

> >  drivers/mfd/rohm-bd9576.c        | 109

> > +++++++++++++++++++++++++++++++

> >  include/linux/mfd/rohm-bd957x.h  |  59 +++++++++++++++++

> >  include/linux/mfd/rohm-generic.h |   2 +

> >  5 files changed, 182 insertions(+)

> >  create mode 100644 drivers/mfd/rohm-bd9576.c

> >  create mode 100644 include/linux/mfd/rohm-bd957x.h

> > 

> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig

> > index bdfce7b15621..53c7c96283bd 100644

> > --- a/drivers/mfd/Kconfig

> > +++ b/drivers/mfd/Kconfig

> > @@ -1998,6 +1998,17 @@ config MFD_ROHM_BD71828

> >  	  Also included is a Coulomb counter, a real-time clock (RTC),

> > and

> >  	  a 32.768 kHz clock gate.

> >  

> > +config MFD_ROHM_BD957XMUF

> > +	tristate "ROHM BD9576MUF and BD9573MUF Power Management ICs"

> > +	depends on I2C=y

> > +	depends on OF

> > +	select REGMAP_I2C

> > +	select MFD_CORE

> > +	help

> > +	  Select this option to get support for the ROHM BD9576MUF and

> > +	  BD9573MUF Power Management ICs. BD9576 and BD9573 are

> > primarily

> > +	  designed to be used to power R-Car series processors.

> > +

> >  config MFD_STM32_LPTIMER

> >  	tristate "Support for STM32 Low-Power Timer"

> >  	depends on (ARCH_STM32 && OF) || COMPILE_TEST

> > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile

> > index 14fdb188af02..e58fae024bb2 100644

> > --- a/drivers/mfd/Makefile

> > +++ b/drivers/mfd/Makefile

> > @@ -262,6 +262,7 @@ obj-$(CONFIG_RAVE_SP_CORE)	+= rave-sp.o

> >  obj-$(CONFIG_MFD_ROHM_BD70528)	+= rohm-bd70528.o

> >  obj-$(CONFIG_MFD_ROHM_BD71828)	+= rohm-bd71828.o

> >  obj-$(CONFIG_MFD_ROHM_BD718XX)	+= rohm-bd718x7.o

> > +obj-$(CONFIG_MFD_ROHM_BD957XMUF)	+= rohm-bd9576.o

> >  obj-$(CONFIG_MFD_STMFX) 	+= stmfx.o

> >  obj-$(CONFIG_MFD_KHADAS_MCU) 	+= khadas-mcu.o

> >  

> > diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c

> > new file mode 100644

> > index 000000000000..efd439677c9e

> > --- /dev/null

> > +++ b/drivers/mfd/rohm-bd9576.c

> > @@ -0,0 +1,109 @@

> > +// SPDX-License-Identifier: GPL-2.0-or-later

> > +/*

> > + * Copyright (C) 2020 ROHM Semiconductors

> 

> If you get a chance, could you please update these?


I'll respin the series as I'll add designated initializers for MFD
regulator array cell as you suggested. So I'll update this at the same
time.

> 

> > + * ROHM BD9576MUF and BD9573MUF PMIC driver

> > + */

> 

> For my own reference (apply this as-is to your sign-off block):

> 

>   Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>

>
diff mbox series

Patch

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index bdfce7b15621..53c7c96283bd 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1998,6 +1998,17 @@  config MFD_ROHM_BD71828
 	  Also included is a Coulomb counter, a real-time clock (RTC), and
 	  a 32.768 kHz clock gate.
 
+config MFD_ROHM_BD957XMUF
+	tristate "ROHM BD9576MUF and BD9573MUF Power Management ICs"
+	depends on I2C=y
+	depends on OF
+	select REGMAP_I2C
+	select MFD_CORE
+	help
+	  Select this option to get support for the ROHM BD9576MUF and
+	  BD9573MUF Power Management ICs. BD9576 and BD9573 are primarily
+	  designed to be used to power R-Car series processors.
+
 config MFD_STM32_LPTIMER
 	tristate "Support for STM32 Low-Power Timer"
 	depends on (ARCH_STM32 && OF) || COMPILE_TEST
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index 14fdb188af02..e58fae024bb2 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -262,6 +262,7 @@  obj-$(CONFIG_RAVE_SP_CORE)	+= rave-sp.o
 obj-$(CONFIG_MFD_ROHM_BD70528)	+= rohm-bd70528.o
 obj-$(CONFIG_MFD_ROHM_BD71828)	+= rohm-bd71828.o
 obj-$(CONFIG_MFD_ROHM_BD718XX)	+= rohm-bd718x7.o
+obj-$(CONFIG_MFD_ROHM_BD957XMUF)	+= rohm-bd9576.o
 obj-$(CONFIG_MFD_STMFX) 	+= stmfx.o
 obj-$(CONFIG_MFD_KHADAS_MCU) 	+= khadas-mcu.o
 
diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c
new file mode 100644
index 000000000000..efd439677c9e
--- /dev/null
+++ b/drivers/mfd/rohm-bd9576.c
@@ -0,0 +1,109 @@ 
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (C) 2020 ROHM Semiconductors
+ *
+ * ROHM BD9576MUF and BD9573MUF PMIC driver
+ */
+
+#include <linux/i2c.h>
+#include <linux/interrupt.h>
+#include <linux/ioport.h>
+#include <linux/irq.h>
+#include <linux/mfd/core.h>
+#include <linux/mfd/rohm-bd957x.h>
+#include <linux/mfd/rohm-generic.h>
+#include <linux/module.h>
+#include <linux/of_device.h>
+#include <linux/regmap.h>
+#include <linux/types.h>
+
+static struct mfd_cell bd9573_mfd_cells[] = {
+	{ .name = "bd9573-regulator", },
+	{ .name = "bd9576-wdt", },
+};
+
+static struct mfd_cell bd9576_mfd_cells[] = {
+	{ .name = "bd9576-regulator", },
+	{ .name = "bd9576-wdt", },
+};
+
+static const struct regmap_range volatile_ranges[] = {
+	regmap_reg_range(BD957X_REG_SMRB_ASSERT, BD957X_REG_SMRB_ASSERT),
+	regmap_reg_range(BD957X_REG_PMIC_INTERNAL_STAT,
+			 BD957X_REG_PMIC_INTERNAL_STAT),
+	regmap_reg_range(BD957X_REG_INT_THERM_STAT, BD957X_REG_INT_THERM_STAT),
+	regmap_reg_range(BD957X_REG_INT_OVP_STAT, BD957X_REG_INT_SYS_STAT),
+	regmap_reg_range(BD957X_REG_INT_MAIN_STAT, BD957X_REG_INT_MAIN_STAT),
+};
+
+static const struct regmap_access_table volatile_regs = {
+	.yes_ranges = &volatile_ranges[0],
+	.n_yes_ranges = ARRAY_SIZE(volatile_ranges),
+};
+
+static struct regmap_config bd957x_regmap = {
+	.reg_bits = 8,
+	.val_bits = 8,
+	.volatile_table = &volatile_regs,
+	.max_register = BD957X_MAX_REGISTER,
+	.cache_type = REGCACHE_RBTREE,
+};
+
+static int bd957x_i2c_probe(struct i2c_client *i2c,
+			     const struct i2c_device_id *id)
+{
+	int ret;
+	struct regmap *regmap;
+	struct mfd_cell *cells;
+	int num_cells;
+	unsigned long chip_type;
+
+	chip_type = (unsigned long)of_device_get_match_data(&i2c->dev);
+
+	switch (chip_type) {
+	case ROHM_CHIP_TYPE_BD9576:
+		cells = bd9576_mfd_cells;
+		num_cells = ARRAY_SIZE(bd9576_mfd_cells);
+		break;
+	case ROHM_CHIP_TYPE_BD9573:
+		cells = bd9573_mfd_cells;
+		num_cells = ARRAY_SIZE(bd9573_mfd_cells);
+		break;
+	default:
+		dev_err(&i2c->dev, "Unknown device type");
+		return -EINVAL;
+	}
+
+	regmap = devm_regmap_init_i2c(i2c, &bd957x_regmap);
+	if (IS_ERR(regmap)) {
+		dev_err(&i2c->dev, "Failed to initialize Regmap\n");
+		return PTR_ERR(regmap);
+	}
+
+	ret = devm_mfd_add_devices(&i2c->dev, PLATFORM_DEVID_AUTO, cells,
+				   num_cells, NULL, 0, NULL);
+	if (ret)
+		dev_err(&i2c->dev, "Failed to create subdevices\n");
+
+	return ret;
+}
+
+static const struct of_device_id bd957x_of_match[] = {
+	{ .compatible = "rohm,bd9576", .data = (void *)ROHM_CHIP_TYPE_BD9576, },
+	{ .compatible = "rohm,bd9573", .data = (void *)ROHM_CHIP_TYPE_BD9573, },
+	{ },
+};
+MODULE_DEVICE_TABLE(of, bd957x_of_match);
+
+static struct i2c_driver bd957x_drv = {
+	.driver = {
+		.name = "rohm-bd957x",
+		.of_match_table = bd957x_of_match,
+	},
+	.probe = &bd957x_i2c_probe,
+};
+module_i2c_driver(bd957x_drv);
+
+MODULE_AUTHOR("Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>");
+MODULE_DESCRIPTION("ROHM BD9576MUF and BD9573MUF Power Management IC driver");
+MODULE_LICENSE("GPL");
diff --git a/include/linux/mfd/rohm-bd957x.h b/include/linux/mfd/rohm-bd957x.h
new file mode 100644
index 000000000000..ae59c0f7188d
--- /dev/null
+++ b/include/linux/mfd/rohm-bd957x.h
@@ -0,0 +1,59 @@ 
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+/* Copyright (C) 2020 ROHM Semiconductors */
+
+#ifndef __LINUX_MFD_BD957X_H__
+#define __LINUX_MFD_BD957X_H__
+
+enum {
+	BD957X_VD50,
+	BD957X_VD18,
+	BD957X_VDDDR,
+	BD957X_VD10,
+	BD957X_VOUTL1,
+	BD957X_VOUTS1,
+};
+
+#define BD957X_REG_SMRB_ASSERT		0x15
+#define BD957X_REG_PMIC_INTERNAL_STAT	0x20
+#define BD957X_REG_INT_THERM_STAT	0x23
+#define BD957X_REG_INT_THERM_MASK	0x24
+#define BD957X_REG_INT_OVP_STAT		0x25
+#define BD957X_REG_INT_SCP_STAT		0x26
+#define BD957X_REG_INT_OCP_STAT		0x27
+#define BD957X_REG_INT_OVD_STAT		0x28
+#define BD957X_REG_INT_UVD_STAT		0x29
+#define BD957X_REG_INT_UVP_STAT		0x2a
+#define BD957X_REG_INT_SYS_STAT		0x2b
+#define BD957X_REG_INT_SYS_MASK		0x2c
+#define BD957X_REG_INT_MAIN_STAT	0x30
+#define BD957X_REG_INT_MAIN_MASK	0x31
+
+#define BD957X_REG_WDT_CONF		0x16
+
+#define BD957X_REG_POW_TRIGGER1		0x41
+#define BD957X_REG_POW_TRIGGER2		0x42
+#define BD957X_REG_POW_TRIGGER3		0x43
+#define BD957X_REG_POW_TRIGGER4		0x44
+#define BD957X_REG_POW_TRIGGERL1	0x45
+#define BD957X_REG_POW_TRIGGERS1	0x46
+
+#define BD957X_REGULATOR_EN_MASK	0xff
+#define BD957X_REGULATOR_DIS_VAL	0xff
+
+#define BD957X_VSEL_REG_MASK		0xff
+
+#define BD957X_MASK_VOUT1_TUNE		0x87
+#define BD957X_MASK_VOUT2_TUNE		0x87
+#define BD957X_MASK_VOUT3_TUNE		0x1f
+#define BD957X_MASK_VOUT4_TUNE		0x1f
+#define BD957X_MASK_VOUTL1_TUNE		0x87
+
+#define BD957X_REG_VOUT1_TUNE		0x50
+#define BD957X_REG_VOUT2_TUNE		0x53
+#define BD957X_REG_VOUT3_TUNE		0x56
+#define BD957X_REG_VOUT4_TUNE		0x59
+#define BD957X_REG_VOUTL1_TUNE		0x5c
+
+#define BD957X_MAX_REGISTER		0x61
+
+#endif
diff --git a/include/linux/mfd/rohm-generic.h b/include/linux/mfd/rohm-generic.h
index 4283b5b33e04..58b4f1a0f4af 100644
--- a/include/linux/mfd/rohm-generic.h
+++ b/include/linux/mfd/rohm-generic.h
@@ -12,6 +12,8 @@  enum rohm_chip_type {
 	ROHM_CHIP_TYPE_BD71847,
 	ROHM_CHIP_TYPE_BD70528,
 	ROHM_CHIP_TYPE_BD71828,
+	ROHM_CHIP_TYPE_BD9576,
+	ROHM_CHIP_TYPE_BD9573,
 	ROHM_CHIP_TYPE_AMOUNT
 };