diff mbox series

[net-next] r8169: handle tx before rx in napi poll

Message ID 5ef5322d-cc83-747b-5995-2e60f2c39d93@gmail.com
State New
Headers show
Series [net-next] r8169: handle tx before rx in napi poll | expand

Commit Message

Heiner Kallweit Feb. 11, 2021, 8:20 p.m. UTC
Cleaning up tx descriptors first increases the chance that
rtl_rx() can allocate new skb's from the cache.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/ethernet/realtek/r8169_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Feb. 12, 2021, 2:20 a.m. UTC | #1
Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Thu, 11 Feb 2021 21:20:08 +0100 you wrote:
> Cleaning up tx descriptors first increases the chance that

> rtl_rx() can allocate new skb's from the cache.

> 

> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

> ---

>  drivers/net/ethernet/realtek/r8169_main.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)


Here is the summary with links:
  - [net-next] r8169: handle tx before rx in napi poll
    https://git.kernel.org/netdev/net-next/c/9fbb4a7ac463

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index de439db75..44a438bad 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -4588,10 +4588,10 @@  static int rtl8169_poll(struct napi_struct *napi, int budget)
 	struct net_device *dev = tp->dev;
 	int work_done;
 
-	work_done = rtl_rx(dev, tp, budget);
-
 	rtl_tx(dev, tp, budget);
 
+	work_done = rtl_rx(dev, tp, budget);
+
 	if (work_done < budget && napi_complete_done(napi, work_done))
 		rtl_irq_enable(tp);