Add CHARGE_NOW support to cw2015_battery.c

Message ID 20210216193217.144803-1-martin@ashbysoft.com
State New
Headers show
Series
  • Add CHARGE_NOW support to cw2015_battery.c
Related show

Commit Message

Martin Ashby Feb. 16, 2021, 7:32 p.m.
CHARGE_NOW is expected by some user software (such as waybar)
instead of 'CAPACITY', in order to correctly calculate remaining battery
life.

Signed-off-by: Martin Ashby <martin@ashbysoft.com>
---
 drivers/power/supply/cw2015_battery.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Tobias Schramm Feb. 18, 2021, 12:22 p.m. | #1
Hi Martin,

thanks for the updated patch.

I just noticed that the patch subject is not ideal. Please have a look 
at the git log of cw2015_battery.c. You will see that the commit subject 
always starts with prefix "power: supply: cw2015:". That makes it a lot 
easier to grasp which subsystem a certain commit is about. Would you 
mind sending a v2 of your patch that does that, too?

Cheers,
Tobias

Patch

diff --git a/drivers/power/supply/cw2015_battery.c b/drivers/power/supply/cw2015_battery.c
index 0146f1bfc..aa1f1771b 100644
--- a/drivers/power/supply/cw2015_battery.c
+++ b/drivers/power/supply/cw2015_battery.c
@@ -511,6 +511,11 @@  static int cw_battery_get_property(struct power_supply *psy,
 			val->intval = 0;
 		break;
 
+	case POWER_SUPPLY_PROP_CHARGE_NOW:
+		val->intval = cw_bat->battery.charge_full_design_uah;
+		val->intval = val->intval * cw_bat->soc / 100;
+		break;
+
 	case POWER_SUPPLY_PROP_CURRENT_NOW:
 		if (cw_battery_valid_time_to_empty(cw_bat) &&
 		    cw_bat->battery.charge_full_design_uah > 0) {
@@ -542,6 +547,7 @@  static enum power_supply_property cw_battery_properties[] = {
 	POWER_SUPPLY_PROP_CHARGE_COUNTER,
 	POWER_SUPPLY_PROP_CHARGE_FULL,
 	POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN,
+	POWER_SUPPLY_PROP_CHARGE_NOW,
 	POWER_SUPPLY_PROP_CURRENT_NOW,
 };