diff mbox series

KVM: SEV: fix double locking due to incorrect backport

Message ID 20210218184058.1420763-1-pbonzini@redhat.com
State New
Headers show
Series KVM: SEV: fix double locking due to incorrect backport | expand

Commit Message

Paolo Bonzini Feb. 18, 2021, 6:40 p.m. UTC
Fix an incorrect line in the 5.4.y and 4.19.y backports of commit
19a23da53932bc ("Fix unsynchronized access to sev members through
svm_register_enc_region"), first applied to 5.4.98 and 4.19.176.

Fixes: 1e80fdc09d12 ("KVM: SVM: Pin guest memory when SEV is active")
Reported-by: Dov Murik <dovmurik@linux.vnet.ibm.com>
Cc: stable@vger.kernel.org # 5.4.x
Cc: stable@vger.kernel.org # 4.19.x
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 arch/x86/kvm/svm.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Sasha Levin Feb. 18, 2021, 10:17 p.m. UTC | #1
On Thu, Feb 18, 2021 at 01:40:58PM -0500, Paolo Bonzini wrote:
>Fix an incorrect line in the 5.4.y and 4.19.y backports of commit
>19a23da53932bc ("Fix unsynchronized access to sev members through
>svm_register_enc_region"), first applied to 5.4.98 and 4.19.176.
>
>Fixes: 1e80fdc09d12 ("KVM: SVM: Pin guest memory when SEV is active")
>Reported-by: Dov Murik <dovmurik@linux.vnet.ibm.com>
>Cc: stable@vger.kernel.org # 5.4.x
>Cc: stable@vger.kernel.org # 4.19.x
>Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Queued up, thanks!
diff mbox series

Patch

diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index 296b0d7570d0..1da558f28aa5 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -7104,7 +7104,6 @@  static int svm_register_enc_region(struct kvm *kvm,
 	region->uaddr = range->addr;
 	region->size = range->size;
 
-	mutex_lock(&kvm->lock);
 	list_add_tail(&region->list, &sev->regions_list);
 	mutex_unlock(&kvm->lock);