| Message ID | 20210218201849.2805-1-xypron.glpk@gmx.de |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] efi/efivars: ConInDev, ConOutDev, ConErrDev are volatile | expand |
(cc Peter) On Thu, 18 Feb 2021 at 21:18, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > UEFI variables ConInDev, ConOutDev, ConErrDev are volatile variables that > are set by the firmware on every reset. It does not make sense to set these > variables via the efivarfs filesystem. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > drivers/firmware/efi/vars.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/firmware/efi/vars.c b/drivers/firmware/efi/vars.c > index 41c1d00bf933..561e0a01093b 100644 > --- a/drivers/firmware/efi/vars.c > +++ b/drivers/firmware/efi/vars.c > @@ -180,11 +180,8 @@ static const struct variable_validate variable_validate[] = { > { EFI_GLOBAL_VARIABLE_GUID, "DriverOrder", validate_boot_order }, > { EFI_GLOBAL_VARIABLE_GUID, "Driver*", validate_load_option }, > { EFI_GLOBAL_VARIABLE_GUID, "ConIn", validate_device_path }, > - { EFI_GLOBAL_VARIABLE_GUID, "ConInDev", validate_device_path }, > { EFI_GLOBAL_VARIABLE_GUID, "ConOut", validate_device_path }, > - { EFI_GLOBAL_VARIABLE_GUID, "ConOutDev", validate_device_path }, > { EFI_GLOBAL_VARIABLE_GUID, "ErrOut", validate_device_path }, > - { EFI_GLOBAL_VARIABLE_GUID, "ErrOutDev", validate_device_path }, > { EFI_GLOBAL_VARIABLE_GUID, "Lang", validate_ascii_string }, > { EFI_GLOBAL_VARIABLE_GUID, "OsIndications", NULL }, > { EFI_GLOBAL_VARIABLE_GUID, "PlatformLang", validate_ascii_string }, > -- > 2.30.0 >
diff --git a/drivers/firmware/efi/vars.c b/drivers/firmware/efi/vars.c index 41c1d00bf933..561e0a01093b 100644 --- a/drivers/firmware/efi/vars.c +++ b/drivers/firmware/efi/vars.c @@ -180,11 +180,8 @@ static const struct variable_validate variable_validate[] = { { EFI_GLOBAL_VARIABLE_GUID, "DriverOrder", validate_boot_order }, { EFI_GLOBAL_VARIABLE_GUID, "Driver*", validate_load_option }, { EFI_GLOBAL_VARIABLE_GUID, "ConIn", validate_device_path }, - { EFI_GLOBAL_VARIABLE_GUID, "ConInDev", validate_device_path }, { EFI_GLOBAL_VARIABLE_GUID, "ConOut", validate_device_path }, - { EFI_GLOBAL_VARIABLE_GUID, "ConOutDev", validate_device_path }, { EFI_GLOBAL_VARIABLE_GUID, "ErrOut", validate_device_path }, - { EFI_GLOBAL_VARIABLE_GUID, "ErrOutDev", validate_device_path }, { EFI_GLOBAL_VARIABLE_GUID, "Lang", validate_ascii_string }, { EFI_GLOBAL_VARIABLE_GUID, "OsIndications", NULL }, { EFI_GLOBAL_VARIABLE_GUID, "PlatformLang", validate_ascii_string },
UEFI variables ConInDev, ConOutDev, ConErrDev are volatile variables that are set by the firmware on every reset. It does not make sense to set these variables via the efivarfs filesystem. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- drivers/firmware/efi/vars.c | 3 --- 1 file changed, 3 deletions(-) -- 2.30.0