| Message ID | 1614069358-50943-1-git-send-email-yang.lee@linux.alibaba.com |
|---|---|
| State | Accepted |
| Commit | 6e5d5791730b55a1f987e1db84b078b91eb49e99 |
| Headers | show |
| Series | gpiolib: acpi: Add missing IRQF_ONESHOT | expand |
On Tue, Feb 23, 2021 at 01:51:53PM +0200, Andy Shevchenko wrote: > On Tue, Feb 23, 2021 at 04:35:58PM +0800, Yang Li wrote: > > fixed the following coccicheck: > > ./drivers/gpio/gpiolib-acpi.c:176:7-27: ERROR: Threaded IRQ with no > > primary handler requested without IRQF_ONESHOT > > > > Make sure threaded IRQs without a primary handler are always request > > with IRQF_ONESHOT > > Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Bart, I guess I will collect this in my branch and send you a PR. I have more fixes to that file anyway.
On Thu, Feb 25, 2021 at 4:07 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Tue, Feb 23, 2021 at 01:51:53PM +0200, Andy Shevchenko wrote: > > On Tue, Feb 23, 2021 at 04:35:58PM +0800, Yang Li wrote: > > > fixed the following coccicheck: > > > ./drivers/gpio/gpiolib-acpi.c:176:7-27: ERROR: Threaded IRQ with no > > > primary handler requested without IRQF_ONESHOT > > > > > > Make sure threaded IRQs without a primary handler are always request > > > with IRQF_ONESHOT > > > > Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Bart, I guess I will collect this in my branch and send you a PR. > I have more fixes to that file anyway. > > -- > With Best Regards, > Andy Shevchenko > > Fine with me!
On Mon, Mar 01, 2021 at 02:57:53PM +0100, Bartosz Golaszewski wrote: > On Thu, Feb 25, 2021 at 4:07 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > On Tue, Feb 23, 2021 at 01:51:53PM +0200, Andy Shevchenko wrote: > > > On Tue, Feb 23, 2021 at 04:35:58PM +0800, Yang Li wrote: > > > > fixed the following coccicheck: > > > > ./drivers/gpio/gpiolib-acpi.c:176:7-27: ERROR: Threaded IRQ with no > > > > primary handler requested without IRQF_ONESHOT > > > > > > > > Make sure threaded IRQs without a primary handler are always request > > > > with IRQF_ONESHOT > > > > > > Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > Bart, I guess I will collect this in my branch and send you a PR. > > I have more fixes to that file anyway. > > Fine with me! Good! So, when you have time, please review [1] and I'll send PR for fixes. [1]: https://lore.kernel.org/linux-gpio/20210225163320.71267-1-andriy.shevchenko@linux.intel.com/T/#u
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c index e37a57d..86efa2d 100644 --- a/drivers/gpio/gpiolib-acpi.c +++ b/drivers/gpio/gpiolib-acpi.c @@ -174,7 +174,7 @@ static void acpi_gpiochip_request_irq(struct acpi_gpio_chip *acpi_gpio, int ret, value; ret = request_threaded_irq(event->irq, NULL, event->handler, - event->irqflags, "ACPI:Event", event); + event->irqflags | IRQF_ONESHOT, "ACPI:Event", event); if (ret) { dev_err(acpi_gpio->chip->parent, "Failed to setup interrupt handler for %d\n",
fixed the following coccicheck: ./drivers/gpio/gpiolib-acpi.c:176:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/gpio/gpiolib-acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)