diff mbox series

[v3,2/3] dt-bindings: usb: generic-ehci: document spurious-oc flag

Message ID 20210223174455.1378-3-noltari@gmail.com
State Superseded
Headers show
Series usb: host: ehci-platform: add spurious-oc support | expand

Commit Message

Álvaro Fernández Rojas Feb. 23, 2021, 5:44 p.m. UTC
Over-current reporting isn't supported on some platforms such as bcm63xx.
These devices will incorrectly report over-current if this flag isn't properly
activated.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
 v3: no changes.
 v2: change flag name and improve documentation as suggested by Alan Stern.

 Documentation/devicetree/bindings/usb/generic-ehci.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Álvaro Fernández Rojas Feb. 24, 2021, 7:20 a.m. UTC | #1
I didn’t change this, but I missed Alan’s Acked-by, so:
Acked-by: Alan Stern <stern@rowland.harvard.edu>

> El 23 feb 2021, a las 18:44, Álvaro Fernández Rojas <noltari@gmail.com> escribió:
> 
> Over-current reporting isn't supported on some platforms such as bcm63xx.
> These devices will incorrectly report over-current if this flag isn't properly
> activated.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
> v3: no changes.
> v2: change flag name and improve documentation as suggested by Alan Stern.
> 
> Documentation/devicetree/bindings/usb/generic-ehci.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> index cf83f2d9afac..8089dc956ba3 100644
> --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> @@ -122,6 +122,12 @@ properties:
>     description:
>       Set this flag to force EHCI reset after resume.
> 
> +  spurious-oc:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      Set this flag to indicate that the hardware sometimes turns on
> +      the OC bit when an over-current isn't actually present.
> +
>   companion:
>     $ref: /schemas/types.yaml#/definitions/phandle
>     description:
> -- 
> 2.20.1
>
Rob Herring March 6, 2021, 8:02 p.m. UTC | #2
On Tue, 23 Feb 2021 18:44:54 +0100, Álvaro Fernández Rojas wrote:
> Over-current reporting isn't supported on some platforms such as bcm63xx.

> These devices will incorrectly report over-current if this flag isn't properly

> activated.

> 

> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>

> ---

>  v3: no changes.

>  v2: change flag name and improve documentation as suggested by Alan Stern.

> 

>  Documentation/devicetree/bindings/usb/generic-ehci.yaml | 6 ++++++

>  1 file changed, 6 insertions(+)

> 


Acked-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
index cf83f2d9afac..8089dc956ba3 100644
--- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
@@ -122,6 +122,12 @@  properties:
     description:
       Set this flag to force EHCI reset after resume.
 
+  spurious-oc:
+    $ref: /schemas/types.yaml#/definitions/flag
+    description:
+      Set this flag to indicate that the hardware sometimes turns on
+      the OC bit when an over-current isn't actually present.
+
   companion:
     $ref: /schemas/types.yaml#/definitions/phandle
     description: