[v2,8/9] mtd/drivers/nand: Use HZ macros

Message ID 20210224144222.23762-8-daniel.lezcano@linaro.org
State New
Headers show
Series
  • Untitled series #104495
Related show

Commit Message

Daniel Lezcano Feb. 24, 2021, 2:42 p.m.
HZ unit conversion macros are available in units.h, use them and
remove the duplicate definition.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

---
 drivers/mtd/nand/raw/intel-nand-controller.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Comments

Miquel Raynal March 2, 2021, 4:31 p.m. | #1
On Wed, 2021-02-24 at 14:42:18 UTC, Daniel Lezcano wrote:
> HZ unit conversion macros are available in units.h, use them and

> remove the duplicate definition.

> 

> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>


Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Miquel Raynal March 2, 2021, 5:12 p.m. | #2
Hi Daniel,

Daniel Lezcano <daniel.lezcano@linaro.org> wrote on Tue, 2 Mar 2021
18:03:12 +0100:

> On 02/03/2021 17:31, Miquel Raynal wrote:
> > On Wed, 2021-02-24 at 14:42:18 UTC, Daniel Lezcano wrote:  
> >> HZ unit conversion macros are available in units.h, use them and
> >> remove the duplicate definition.
> >>
> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>  
> > 
> > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.  
> 
> Actually, I was expecting to have it merged through linux-pm as this
> patch depends on 1/9
> 
> 
> 

No problem, I just removed it from my tree. However in this case
please fix the subject prefix to "mtd: rawnand: intel:". With this nit
fixed,

Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl

Patch

diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nand/raw/intel-nand-controller.c
index a304fda5d1fa..8d00191a4815 100644
--- a/drivers/mtd/nand/raw/intel-nand-controller.c
+++ b/drivers/mtd/nand/raw/intel-nand-controller.c
@@ -20,6 +20,7 @@ 
 #include <linux/sched.h>
 #include <linux/slab.h>
 #include <linux/types.h>
+#include <linux/units.h>
 #include <asm/unaligned.h>
 
 #define EBU_CLC			0x000
@@ -102,7 +103,6 @@ 
 
 #define MAX_CS	2
 
-#define HZ_PER_MHZ	1000000L
 #define USEC_PER_SEC	1000000L
 
 struct ebu_nand_cs {