diff mbox

[edk2,RHEL-7.1,ovmf] ArmVirtualizationPkg: FdtPL011SerialPortLib: support UEFI_APPLICATION

Message ID 1413377394-23122-1-git-send-email-lersek@redhat.com
State New
Headers show

Commit Message

Laszlo Ersek Oct. 15, 2014, 12:49 p.m. UTC
The library already supports UEFI_DRIVER, we just need to relax the
restriction list.

This allows ArmVirtualizationPkg platforms to build applications, like the
UEFI shell.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 .../Library/FdtPL011SerialPortLib/FdtPL011SerialPortLib.inf             | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laszlo Ersek Oct. 15, 2014, 12:57 p.m. UTC | #1
On 10/15/14 14:49, Laszlo Ersek wrote:
> The library already supports UEFI_DRIVER, we just need to relax the
> restriction list.
> 
> This allows ArmVirtualizationPkg platforms to build applications, like the
> UEFI shell.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  .../Library/FdtPL011SerialPortLib/FdtPL011SerialPortLib.inf             | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ArmPlatformPkg/ArmVirtualizationPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLib.inf b/ArmPlatformPkg/ArmVirtualizationPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLib.inf
> index 178e6c4..9145afa 100644
> --- a/ArmPlatformPkg/ArmVirtualizationPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLib.inf
> +++ b/ArmPlatformPkg/ArmVirtualizationPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLib.inf
> @@ -20,7 +20,7 @@
>    FILE_GUID                      = CB768406-7DE6-49B6-BC2C-F324E110DE5A
>    MODULE_TYPE                    = BASE
>    VERSION_STRING                 = 1.0
> -  LIBRARY_CLASS                  = SerialPortLib|DXE_CORE DXE_DRIVER UEFI_DRIVER DXE_RUNTIME_DRIVER
> +  LIBRARY_CLASS                  = SerialPortLib|DXE_CORE DXE_DRIVER UEFI_DRIVER DXE_RUNTIME_DRIVER UEFI_APPLICATION
>    CONSTRUCTOR                    = FdtPL011SerialPortLibInitialize
>  
>  [Sources.common]
> 

Oops.

I most certainly intended to post this patch upstream, just not with
this subject prefix. Sigh.

Please do review & apply as usual, ignoring the prefix.

Thanks,
Laszlo

------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
Olivier Martin Oct. 15, 2014, 2:16 p.m. UTC | #2
Reviewed-By:  Olivier Martin <olivier.martin@arm.com>

Thanks Laszlo for the patch, I have just pushed it into SVN rev16219.

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: 15 October 2014 13:57
> To: edk2-devel@lists.sourceforge.net; ard.biesheuvel@linaro.org
> Subject: Re: [edk2] [RHEL-7.1 ovmf PATCH] ArmVirtualizationPkg:
> FdtPL011SerialPortLib: support UEFI_APPLICATION
> 
> On 10/15/14 14:49, Laszlo Ersek wrote:
> > The library already supports UEFI_DRIVER, we just need to relax the
> > restriction list.
> >
> > This allows ArmVirtualizationPkg platforms to build applications,
> like the
> > UEFI shell.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> > ---
> >  .../Library/FdtPL011SerialPortLib/FdtPL011SerialPortLib.inf
> | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> a/ArmPlatformPkg/ArmVirtualizationPkg/Library/FdtPL011SerialPortLib/Fdt
> PL011SerialPortLib.inf
> b/ArmPlatformPkg/ArmVirtualizationPkg/Library/FdtPL011SerialPortLib/Fdt
> PL011SerialPortLib.inf
> > index 178e6c4..9145afa 100644
> > ---
> a/ArmPlatformPkg/ArmVirtualizationPkg/Library/FdtPL011SerialPortLib/Fdt
> PL011SerialPortLib.inf
> > +++
> b/ArmPlatformPkg/ArmVirtualizationPkg/Library/FdtPL011SerialPortLib/Fdt
> PL011SerialPortLib.inf
> > @@ -20,7 +20,7 @@
> >    FILE_GUID                      = CB768406-7DE6-49B6-BC2C-
> F324E110DE5A
> >    MODULE_TYPE                    = BASE
> >    VERSION_STRING                 = 1.0
> > -  LIBRARY_CLASS                  = SerialPortLib|DXE_CORE DXE_DRIVER
> UEFI_DRIVER DXE_RUNTIME_DRIVER
> > +  LIBRARY_CLASS                  = SerialPortLib|DXE_CORE DXE_DRIVER
> UEFI_DRIVER DXE_RUNTIME_DRIVER UEFI_APPLICATION
> >    CONSTRUCTOR                    = FdtPL011SerialPortLibInitialize
> >
> >  [Sources.common]
> >
> 
> Oops.
> 
> I most certainly intended to post this patch upstream, just not with
> this subject prefix. Sigh.
> 
> Please do review & apply as usual, ignoring the prefix.
> 
> Thanks,
> Laszlo
> 
> -----------------------------------------------------------------------
> -------
> Comprehensive Server Monitoring with Site24x7.
> Monitor 10 servers for $9/Month.
> Get alerted through email, SMS, voice calls or mobile push
> notifications.
> Take corrective actions from your mobile device.
> http://p.sf.net/sfu/Zoho
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel





------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
diff mbox

Patch

diff --git a/ArmPlatformPkg/ArmVirtualizationPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLib.inf b/ArmPlatformPkg/ArmVirtualizationPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLib.inf
index 178e6c4..9145afa 100644
--- a/ArmPlatformPkg/ArmVirtualizationPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLib.inf
+++ b/ArmPlatformPkg/ArmVirtualizationPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLib.inf
@@ -20,7 +20,7 @@ 
   FILE_GUID                      = CB768406-7DE6-49B6-BC2C-F324E110DE5A
   MODULE_TYPE                    = BASE
   VERSION_STRING                 = 1.0
-  LIBRARY_CLASS                  = SerialPortLib|DXE_CORE DXE_DRIVER UEFI_DRIVER DXE_RUNTIME_DRIVER
+  LIBRARY_CLASS                  = SerialPortLib|DXE_CORE DXE_DRIVER UEFI_DRIVER DXE_RUNTIME_DRIVER UEFI_APPLICATION
   CONSTRUCTOR                    = FdtPL011SerialPortLibInitialize
 
 [Sources.common]