From patchwork Mon Mar 1 13:32:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 388634 Delivered-To: patch@linaro.org Received: by 2002:a02:290e:0:0:0:0:0 with SMTP id p14csp3352906jap; Mon, 1 Mar 2021 05:34:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJyJXnPRztop0Q8f8BDQyGNCYj26ZJa9bqb8NB8REdvdaVlJeGrK0GHhlJxGYUJ1K4JIpFyk X-Received: by 2002:aa7:c3c7:: with SMTP id l7mr16516969edr.207.1614605665357; Mon, 01 Mar 2021 05:34:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614605665; cv=none; d=google.com; s=arc-20160816; b=oMvDOExlGy0SlcLKkXZu1AxY3VOec/moobHVpVRtPKoxem+xoUfal1J2bqTX/Voyf0 vRDTbnJFmwD0UaGxE765bIhbBkdSyny3ICCCQ1fPEydoLGC3fNR4euy4DZZ8F5rGcTAm dezA4Yj/h4Pe/7A38WTaWIlVkEti3kBwfRfKYuyD8B58ak/4WixlJTA0I+oQzuWoy13k FVzw8bptSE3uQWC7k//oS6vCmD0xrL4jEywT44qRmQHDi+HSyPPYADX2zuuU3ZNbwMdj n7ZfxjSyUaQm01efsaLHTKxRFZ6DGPNgvXAk4/7BOrGAV3A4Bg73E0QWj5s9KKU1bhEI JTgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cYZerRT2x1qlGnIcE8x6N2LpmT6kXCgWE2D5TP/WfCs=; b=t2OlgvhYf/nBDNwIfRKgqNohnMP7XG7Ok6w+0hRoZdnsMRgwyaH2VyYE7JTrsyP3Z4 qpoG3v0mr9DEBSjCnrPGEK1aXWWC1EZ3KLy33fk+gVklLJpGY2X4s8VThz8pmdFmYrno 1CKxcFVfwYrqAEm+IR5f09LDoz/aAXg4cBbX0tMRTQ8ju9nCkW4CIJ/a6dNbFYtPYXeN Oaao7qXw+FoTtYoBeSaitL4sKEYWQI5E4y1YMW39i3IXxrhwsg0acBlDcOB7oljzcjO4 qjd2jmCdZ3oRIhIZecyuJOlLzMRfMlie4YV6XIitTd2Ft3islhW0zBzCHyfRERMFeHVT P34g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wKzXFcDL; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q15si11037053edd.127.2021.03.01.05.34.25; Mon, 01 Mar 2021 05:34:25 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wKzXFcDL; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235830AbhCANdx (ORCPT + 9 others); Mon, 1 Mar 2021 08:33:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235814AbhCANd3 (ORCPT ); Mon, 1 Mar 2021 08:33:29 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C12AC061788 for ; Mon, 1 Mar 2021 05:32:49 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id e7so25535873lft.2 for ; Mon, 01 Mar 2021 05:32:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cYZerRT2x1qlGnIcE8x6N2LpmT6kXCgWE2D5TP/WfCs=; b=wKzXFcDLjNyyRoslx3XcGuzfeszZwxSUcGtgTwhw+Y3Hp51/yhR3A4MGHWVgreAN1x hqUmNnCKT0MzuDnHrMC2sqDuere+4CpfTK30Zh9q3+YBF4hbk8WRE6AfH+ulCqd+/ozb IyIruRdLbFzaSSbSdHLXUvLm3RZfSdFWdRt3MwBk8GUsSX/YsN/vOJac3U5nBkkbcmWF PU6Ut6S+XWdx80tyfDhbi32War2XktED/mAnE/SQC0oAwLI9ey/c87+JWcaOu+MBDF1P os2EfNbn1k8m2rEyM8mxtZ9I9Z+xilAWMTg6dPcbiiHg5bA9yVaWIDMW3YEwOrIcXZan pTxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cYZerRT2x1qlGnIcE8x6N2LpmT6kXCgWE2D5TP/WfCs=; b=QiOZ6AC8x3BGarY7QKEAz8QuMGQ7c3Y1RV6feSRUiNK6LATIdJRV5Rc875rl8Hq/XM O5b/eqFcnlSqoNPY3ggPFlOqQCd1uYrUQ7Efcc9i9EH7BZSfMnfgic2SvueVNVXqjie3 KUu20KhTmmDmckU2Ur8bzxwPrIKyCkoGrB3qTERp8VwrHKU9MnTIFrSKH2+sIBULjHg4 dZ6Whc1z+MhnTreniXjMvQAgHm8PU3HMIEna3ClpcQub/W2ShERIF5csR/F+BD3i/UO/ QOgMvNq4bzhS6wiXjUmgjHsKLgXHPRP5Me8GDRy82I8O6TaqxL552Ccmchn7rkvYBcQg riBA== X-Gm-Message-State: AOAM5320+pwStEPr84/OhFPg9wG4SHktfO/+8P1kFv6x0vb9Sg7s9yL2 LzE9zwyBsyBrAW9aLRLNafbC2Q== X-Received: by 2002:a19:7d06:: with SMTP id y6mr9808950lfc.644.1614605567969; Mon, 01 Mar 2021 05:32:47 -0800 (PST) Received: from localhost.localdomain (c-d7cb225c.014-348-6c756e10.bbcust.telenor.se. [92.34.203.215]) by smtp.gmail.com with ESMTPSA id c9sm2310066lft.144.2021.03.01.05.32.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Mar 2021 05:32:47 -0800 (PST) From: Linus Walleij To: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Linus Walleij , DENG Qingfang , Mauri Sandberg Subject: [PATCH net 2/3] net: dsa: rtl4_a: Drop skb_cow_head() Date: Mon, 1 Mar 2021 14:32:40 +0100 Message-Id: <20210301133241.1277164-2-linus.walleij@linaro.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210301133241.1277164-1-linus.walleij@linaro.org> References: <20210301133241.1277164-1-linus.walleij@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The DSA core already provides the tag headroom, drop this. Fixes: 86dd9868b878 ("net: dsa: tag_rtl4_a: Support also egress tags") Reported-by: Andrew Lunn Reported-by: DENG Qingfang Cc: Mauri Sandberg Signed-off-by: Linus Walleij --- net/dsa/tag_rtl4_a.c | 2 -- 1 file changed, 2 deletions(-) -- 2.29.2 Reviewed-by: Florian Fainelli diff --git a/net/dsa/tag_rtl4_a.c b/net/dsa/tag_rtl4_a.c index 804d756dd80a..8098d81f660b 100644 --- a/net/dsa/tag_rtl4_a.c +++ b/net/dsa/tag_rtl4_a.c @@ -42,8 +42,6 @@ static struct sk_buff *rtl4a_tag_xmit(struct sk_buff *skb, /* Pad out to at least 60 bytes */ if (__skb_put_padto(skb, ETH_ZLEN, false)) return NULL; - if (skb_cow_head(skb, RTL4_A_HDR_LEN) < 0) - return NULL; netdev_dbg(dev, "add realtek tag to package to port %d\n", dp->index);