| Message ID | 1614662511-26519-1-git-send-email-rnayak@codeaurora.org |
|---|---|
| State | Accepted |
| Commit | 07abd8db9358751107cc46d1cdbd44a92c76a934 |
| Headers | show |
| Series | [1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets | expand |
On Mon 01 Mar 23:21 CST 2021, Rajendra Nayak wrote: > The offsets for SDC_QDSD_PINGROUP and UFS_RESET were off by 0x100000 > due to an issue in the scripts generating the data. > > Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver") > > Reported-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org> > Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > drivers/pinctrl/qcom/pinctrl-sc7280.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280.c b/drivers/pinctrl/qcom/pinctrl-sc7280.c > index 8daccd5..49c4347 100644 > --- a/drivers/pinctrl/qcom/pinctrl-sc7280.c > +++ b/drivers/pinctrl/qcom/pinctrl-sc7280.c > @@ -1439,14 +1439,14 @@ static const struct msm_pingroup sc7280_groups[] = { > [172] = PINGROUP(172, qdss, _, _, _, _, _, _, _, _), > [173] = PINGROUP(173, qdss, _, _, _, _, _, _, _, _), > [174] = PINGROUP(174, qdss, _, _, _, _, _, _, _, _), > - [175] = UFS_RESET(ufs_reset, 0x1be000), > - [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0x1b3000, 15, 0), > - [177] = SDC_QDSD_PINGROUP(sdc1_clk, 0x1b3000, 13, 6), > - [178] = SDC_QDSD_PINGROUP(sdc1_cmd, 0x1b3000, 11, 3), > - [179] = SDC_QDSD_PINGROUP(sdc1_data, 0x1b3000, 9, 0), > - [180] = SDC_QDSD_PINGROUP(sdc2_clk, 0x1b4000, 14, 6), > - [181] = SDC_QDSD_PINGROUP(sdc2_cmd, 0x1b4000, 11, 3), > - [182] = SDC_QDSD_PINGROUP(sdc2_data, 0x1b4000, 9, 0), > + [175] = UFS_RESET(ufs_reset, 0xbe000), > + [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0xb3000, 15, 0), > + [177] = SDC_QDSD_PINGROUP(sdc1_clk, 0xb3000, 13, 6), > + [178] = SDC_QDSD_PINGROUP(sdc1_cmd, 0xb3000, 11, 3), > + [179] = SDC_QDSD_PINGROUP(sdc1_data, 0xb3000, 9, 0), > + [180] = SDC_QDSD_PINGROUP(sdc2_clk, 0xb4000, 14, 6), > + [181] = SDC_QDSD_PINGROUP(sdc2_cmd, 0xb4000, 11, 3), > + [182] = SDC_QDSD_PINGROUP(sdc2_data, 0xb4000, 9, 0), > }; > > static const struct msm_pinctrl_soc_data sc7280_pinctrl = { > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation >
On Tue, Mar 2, 2021 at 6:22 AM Rajendra Nayak <rnayak@codeaurora.org> wrote: > The offsets for SDC_QDSD_PINGROUP and UFS_RESET were off by 0x100000 > due to an issue in the scripts generating the data. > > Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver") > > Reported-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org> > Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> Both patches applied for fixes! Yours, Linus Walleij
On Tue, Mar 2, 2021 at 9:32 PM Rajendra Nayak <rnayak@codeaurora.org> wrote: > > The offsets for SDC_QDSD_PINGROUP and UFS_RESET were off by 0x100000 > due to an issue in the scripts generating the data. > Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver") > > Reported-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org> > Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> Should be no blank lines in the tag block. -- With Best Regards, Andy Shevchenko
On Thu, Mar 11, 2021 at 11:41 AM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Tue, Mar 2, 2021 at 9:32 PM Rajendra Nayak <rnayak@codeaurora.org> wrote: > > > > The offsets for SDC_QDSD_PINGROUP and UFS_RESET were off by 0x100000 > > due to an issue in the scripts generating the data. > > > Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver") > > > > Reported-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org> > > Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> > > Should be no blank lines in the tag block. Yeah I fixed it up when applying. Just one of these maintainer perks I offer free of charge ;) Yours, Linus Walleij
diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280.c b/drivers/pinctrl/qcom/pinctrl-sc7280.c index 8daccd5..49c4347 100644 --- a/drivers/pinctrl/qcom/pinctrl-sc7280.c +++ b/drivers/pinctrl/qcom/pinctrl-sc7280.c @@ -1439,14 +1439,14 @@ static const struct msm_pingroup sc7280_groups[] = { [172] = PINGROUP(172, qdss, _, _, _, _, _, _, _, _), [173] = PINGROUP(173, qdss, _, _, _, _, _, _, _, _), [174] = PINGROUP(174, qdss, _, _, _, _, _, _, _, _), - [175] = UFS_RESET(ufs_reset, 0x1be000), - [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0x1b3000, 15, 0), - [177] = SDC_QDSD_PINGROUP(sdc1_clk, 0x1b3000, 13, 6), - [178] = SDC_QDSD_PINGROUP(sdc1_cmd, 0x1b3000, 11, 3), - [179] = SDC_QDSD_PINGROUP(sdc1_data, 0x1b3000, 9, 0), - [180] = SDC_QDSD_PINGROUP(sdc2_clk, 0x1b4000, 14, 6), - [181] = SDC_QDSD_PINGROUP(sdc2_cmd, 0x1b4000, 11, 3), - [182] = SDC_QDSD_PINGROUP(sdc2_data, 0x1b4000, 9, 0), + [175] = UFS_RESET(ufs_reset, 0xbe000), + [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0xb3000, 15, 0), + [177] = SDC_QDSD_PINGROUP(sdc1_clk, 0xb3000, 13, 6), + [178] = SDC_QDSD_PINGROUP(sdc1_cmd, 0xb3000, 11, 3), + [179] = SDC_QDSD_PINGROUP(sdc1_data, 0xb3000, 9, 0), + [180] = SDC_QDSD_PINGROUP(sdc2_clk, 0xb4000, 14, 6), + [181] = SDC_QDSD_PINGROUP(sdc2_cmd, 0xb4000, 11, 3), + [182] = SDC_QDSD_PINGROUP(sdc2_data, 0xb4000, 9, 0), }; static const struct msm_pinctrl_soc_data sc7280_pinctrl = {
The offsets for SDC_QDSD_PINGROUP and UFS_RESET were off by 0x100000 due to an issue in the scripts generating the data. Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver") Reported-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> --- drivers/pinctrl/qcom/pinctrl-sc7280.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)