[oe] add CUnit test suite

Message ID 1413992945-33655-1-git-send-email-mike.holmes@linaro.org
State New
Headers show

Commit Message

Mike Holmes Oct. 22, 2014, 3:49 p.m.
Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
---
 meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb

Comments

Martin Jansa Oct. 22, 2014, 4:21 p.m. | #1
On Wed, Oct 22, 2014 at 11:49:05AM -0400, Mike Holmes wrote:
> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
> ---
>  meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> 
> diff --git a/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> new file mode 100644
> index 0000000..e869852
> --- /dev/null
> +++ b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> @@ -0,0 +1,18 @@
> +DESCRIPTION = "CUnit is a C framework for unit testing. Test output supports comandline and GUI reults reporting"
> +HOMEPAGE = "http://cunit.sourceforge.net"
> +LICENSE = "LGPL-2.0"
> +SECTION = "libs"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=7734aa853b85d6f935466f081490ddbb"
> +
> +S = "${WORKDIR}/CUnit-${PV}"
> +
> +SRC_URI = "http://downloads.sourceforge.net/project/cunit/CUnit/${PV}/CUnit-${PV}.tar.bz2"
> +SRC_URI[md5sum] = "b5f1a9f6093869c070c6e4a9450cc10c"
> +SRC_URI[sha256sum] = "f5b29137f845bb08b77ec60584fdb728b4e58f1023e6f249a464efa49a40f214"
> +
> +inherit autotools-brokensep
> +
> +EXTRA_OECONF = "--enable-debug --enable-memtrace --enable-automated --enable-basic --enable-console"
> +
> +FILES_${PN}-doc += "${prefix}/doc"

Why doesn't it use ${datadir}/doc == ${docdir} as everything else?

> +FILES_${PN}-dev += "${datadir}"
> -- 
> 1.9.1
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Mike Holmes Oct. 22, 2014, 4:34 p.m. | #2
On 22 October 2014 12:21, Martin Jansa <martin.jansa@gmail.com> wrote:

> On Wed, Oct 22, 2014 at 11:49:05AM -0400, Mike Holmes wrote:
> > Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
> > ---
> >  meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >  create mode 100644 meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> >
> > diff --git a/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> > new file mode 100644
> > index 0000000..e869852
> > --- /dev/null
> > +++ b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> > @@ -0,0 +1,18 @@
> > +DESCRIPTION = "CUnit is a C framework for unit testing. Test output
> supports comandline and GUI reults reporting"
> > +HOMEPAGE = "http://cunit.sourceforge.net"
> > +LICENSE = "LGPL-2.0"
> > +SECTION = "libs"
> > +LIC_FILES_CHKSUM = "file://COPYING;md5=7734aa853b85d6f935466f081490ddbb"
> > +
> > +S = "${WORKDIR}/CUnit-${PV}"
> > +
> > +SRC_URI = "
> http://downloads.sourceforge.net/project/cunit/CUnit/${PV}/CUnit-${PV}.tar.bz2
> "
> > +SRC_URI[md5sum] = "b5f1a9f6093869c070c6e4a9450cc10c"
> > +SRC_URI[sha256sum] =
> "f5b29137f845bb08b77ec60584fdb728b4e58f1023e6f249a464efa49a40f214"
> > +
> > +inherit autotools-brokensep
> > +
> > +EXTRA_OECONF = "--enable-debug --enable-memtrace --enable-automated
> --enable-basic --enable-console"
> > +
> > +FILES_${PN}-doc += "${prefix}/doc"
>
> Why doesn't it use ${datadir}/doc == ${docdir} as everything else?
>

My inexperience with OE most likely, I will try that, thank you.


>
> > +FILES_${PN}-dev += "${datadir}"
> > --
> > 1.9.1
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>
Mike Holmes Oct. 22, 2014, 8:19 p.m. | #3
On 22 October 2014 12:21, Martin Jansa <martin.jansa@gmail.com> wrote:

> On Wed, Oct 22, 2014 at 11:49:05AM -0400, Mike Holmes wrote:
> > Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
> > ---
> >  meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >  create mode 100644 meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> >
> > diff --git a/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> > new file mode 100644
> > index 0000000..e869852
> > --- /dev/null
> > +++ b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
> > @@ -0,0 +1,18 @@
> > +DESCRIPTION = "CUnit is a C framework for unit testing. Test output
> supports comandline and GUI reults reporting"
> > +HOMEPAGE = "http://cunit.sourceforge.net"
> > +LICENSE = "LGPL-2.0"
> > +SECTION = "libs"
> > +LIC_FILES_CHKSUM = "file://COPYING;md5=7734aa853b85d6f935466f081490ddbb"
> > +
> > +S = "${WORKDIR}/CUnit-${PV}"
> > +
> > +SRC_URI = "
> http://downloads.sourceforge.net/project/cunit/CUnit/${PV}/CUnit-${PV}.tar.bz2
> "
> > +SRC_URI[md5sum] = "b5f1a9f6093869c070c6e4a9450cc10c"
> > +SRC_URI[sha256sum] =
> "f5b29137f845bb08b77ec60584fdb728b4e58f1023e6f249a464efa49a40f214"
> > +
> > +inherit autotools-brokensep
> > +
> > +EXTRA_OECONF = "--enable-debug --enable-memtrace --enable-automated
> --enable-basic --enable-console"
> > +
> > +FILES_${PN}-doc += "${prefix}/doc"
>
> Why doesn't it use ${datadir}/doc == ${docdir} as everything else?
>

I think the reason is because CUnit places its docs in /usr/doc/CUnit which
is not the same as docdir (usr/share/doc)


>
> > +FILES_${PN}-dev += "${datadir}"
> > --
> > 1.9.1
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>
Ross Burton Oct. 22, 2014, 8:28 p.m. | #4
On 22 October 2014 21:19, Mike Holmes <mike.holmes@linaro.org> wrote:

> I think the reason is because CUnit places its docs in /usr/doc/CUnit which
> is not the same as docdir (usr/share/doc)
>

In that case the recipe should fix the location.

Ross
gary.robertson@linaro.org March 31, 2015, 4:10 a.m. | #5
Mike Holmes has asked me to resubmit this patch on his behalf, as other
duties have currently preempted his efforts to pursue acceptance of this
new recipe in OE.

A new patch file was added which sets the path configuration variables
to place documentation and headers in locations consistent with the
OE filesystem layout.

Looking in the ${WORKDIR}/*destdir and ${WORKDIR}/deploy-ipks subdirectories
after performing the recipe build, it appears that everything is being placed
into the appropriate locations.

We believe this version of the recipe addresses the concerns
raised in the email exchanges regarding the initial recipe submission,
and hope you will now find it acceptable.

Patch

diff --git a/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
new file mode 100644
index 0000000..e869852
--- /dev/null
+++ b/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb
@@ -0,0 +1,18 @@ 
+DESCRIPTION = "CUnit is a C framework for unit testing. Test output supports comandline and GUI reults reporting"
+HOMEPAGE = "http://cunit.sourceforge.net"
+LICENSE = "LGPL-2.0"
+SECTION = "libs"
+LIC_FILES_CHKSUM = "file://COPYING;md5=7734aa853b85d6f935466f081490ddbb"
+
+S = "${WORKDIR}/CUnit-${PV}"
+
+SRC_URI = "http://downloads.sourceforge.net/project/cunit/CUnit/${PV}/CUnit-${PV}.tar.bz2"
+SRC_URI[md5sum] = "b5f1a9f6093869c070c6e4a9450cc10c"
+SRC_URI[sha256sum] = "f5b29137f845bb08b77ec60584fdb728b4e58f1023e6f249a464efa49a40f214"
+
+inherit autotools-brokensep
+
+EXTRA_OECONF = "--enable-debug --enable-memtrace --enable-automated --enable-basic --enable-console"
+
+FILES_${PN}-doc += "${prefix}/doc"
+FILES_${PN}-dev += "${datadir}"