[RESEND,next] bnxt_en: Fix fall-through warnings for Clang

Message ID 20210305095024.GA141398@embeddedor
State New
Headers show
Series
  • [RESEND,next] bnxt_en: Fix fall-through warnings for Clang
Related show

Commit Message

Gustavo A. R. Silva March 5, 2021, 9:50 a.m.
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of just letting the code
fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Gustavo A. R. Silva April 20, 2021, 8:27 p.m. | #1
Hi all,

Friendly ping: who can take this, please?

Thanks
--
Gustavo

On 3/5/21 03:50, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning

> by explicitly adding a break statement instead of just letting the code

> fall through to the next case.

> 

> Link: https://github.com/KSPP/linux/issues/115

> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

> ---

>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c

> index b53a0d87371a..a34810750058 100644

> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c

> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c

> @@ -2158,6 +2158,7 @@ static int bnxt_hwrm_handler(struct bnxt *bp, struct tx_cmp *txcmp)

>  	case CMPL_BASE_TYPE_HWRM_ASYNC_EVENT:

>  		bnxt_async_event_process(bp,

>  					 (struct hwrm_async_event_cmpl *)txcmp);

> +		break;

>  

>  	default:

>  		break;

>
Gustavo A. R. Silva May 18, 2021, 12:23 a.m. | #2
Hi,

I'm taking this in my -next[1] branch for v5.14.

Thanks
--
Gustavo

[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp

On 4/20/21 15:27, Gustavo A. R. Silva wrote:
> Hi all,

> 

> Friendly ping: who can take this, please?

> 

> Thanks

> --

> Gustavo

> 

> On 3/5/21 03:50, Gustavo A. R. Silva wrote:

>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning

>> by explicitly adding a break statement instead of just letting the code

>> fall through to the next case.

>>

>> Link: https://github.com/KSPP/linux/issues/115

>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

>> ---

>>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 +

>>  1 file changed, 1 insertion(+)

>>

>> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c

>> index b53a0d87371a..a34810750058 100644

>> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c

>> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c

>> @@ -2158,6 +2158,7 @@ static int bnxt_hwrm_handler(struct bnxt *bp, struct tx_cmp *txcmp)

>>  	case CMPL_BASE_TYPE_HWRM_ASYNC_EVENT:

>>  		bnxt_async_event_process(bp,

>>  					 (struct hwrm_async_event_cmpl *)txcmp);

>> +		break;

>>  

>>  	default:

>>  		break;

>>

Patch

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index b53a0d87371a..a34810750058 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -2158,6 +2158,7 @@  static int bnxt_hwrm_handler(struct bnxt *bp, struct tx_cmp *txcmp)
 	case CMPL_BASE_TYPE_HWRM_ASYNC_EVENT:
 		bnxt_async_event_process(bp,
 					 (struct hwrm_async_event_cmpl *)txcmp);
+		break;
 
 	default:
 		break;