[RESEND,next] rxrpc: Fix fall-through warnings for Clang

Message ID 20210305091900.GA139713@embeddedor
State New
Headers show
Series
  • [RESEND,next] rxrpc: Fix fall-through warnings for Clang
Related show

Commit Message

Gustavo A. R. Silva March 5, 2021, 9:19 a.m.
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 net/rxrpc/af_rxrpc.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Gustavo A. R. Silva April 20, 2021, 8:09 p.m. | #1
Hi all,

Friendly ping: who can take this, please?

Thanks
--
Gustavo

On 3/5/21 03:19, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning

> by explicitly adding a break statement instead of letting the code fall

> through to the next case.

> 

> Link: https://github.com/KSPP/linux/issues/115

> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

> ---

>  net/rxrpc/af_rxrpc.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/net/rxrpc/af_rxrpc.c b/net/rxrpc/af_rxrpc.c

> index 41671af6b33f..2b5f89713e36 100644

> --- a/net/rxrpc/af_rxrpc.c

> +++ b/net/rxrpc/af_rxrpc.c

> @@ -471,6 +471,7 @@ static int rxrpc_connect(struct socket *sock, struct sockaddr *addr,

>  	switch (rx->sk.sk_state) {

>  	case RXRPC_UNBOUND:

>  		rx->sk.sk_state = RXRPC_CLIENT_UNBOUND;

> +		break;

>  	case RXRPC_CLIENT_UNBOUND:

>  	case RXRPC_CLIENT_BOUND:

>  		break;

>
Jeffrey E Altman April 21, 2021, 11:41 p.m. | #2
On 3/5/2021 4:19 AM, Gustavo A. R. Silva (gustavoars@kernel.org) wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning

> by explicitly adding a break statement instead of letting the code fall

> through to the next case.

> 

> Link: https://github.com/KSPP/linux/issues/115

> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>


This change looks good to me.  Although I would also be happy with a 
fallthrough statement being added instead.

Reviewed-by: Jeffrey Altman <jaltman@auristor.com>
begin:vcard
fn:Jeffrey Altman
n:Altman;Jeffrey
org:AuriStor, Inc.
adr:;;255 W 94TH ST STE 6B;New York;NY;10025-6985;United States
email;internet:jaltman@auristor.com
title:CEO
tel;work:+1-212-769-9018
url:https://www.linkedin.com/in/jeffreyaltman/
version:2.1
end:vcard
Gustavo A. R. Silva June 4, 2021, 10:35 p.m. | #3
Hi all,

If you don't mind, I'm taking this in my -next[1] branch for v5.14.

Thanks
--
Gustavo

[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp

On 4/20/21 15:09, Gustavo A. R. Silva wrote:
> Hi all,

> 

> Friendly ping: who can take this, please?

> 

> Thanks

> --

> Gustavo

> 

> On 3/5/21 03:19, Gustavo A. R. Silva wrote:

>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning

>> by explicitly adding a break statement instead of letting the code fall

>> through to the next case.

>>

>> Link: https://github.com/KSPP/linux/issues/115

>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

>> ---

>>  net/rxrpc/af_rxrpc.c | 1 +

>>  1 file changed, 1 insertion(+)

>>

>> diff --git a/net/rxrpc/af_rxrpc.c b/net/rxrpc/af_rxrpc.c

>> index 41671af6b33f..2b5f89713e36 100644

>> --- a/net/rxrpc/af_rxrpc.c

>> +++ b/net/rxrpc/af_rxrpc.c

>> @@ -471,6 +471,7 @@ static int rxrpc_connect(struct socket *sock, struct sockaddr *addr,

>>  	switch (rx->sk.sk_state) {

>>  	case RXRPC_UNBOUND:

>>  		rx->sk.sk_state = RXRPC_CLIENT_UNBOUND;

>> +		break;

>>  	case RXRPC_CLIENT_UNBOUND:

>>  	case RXRPC_CLIENT_BOUND:

>>  		break;

>>

Patch

diff --git a/net/rxrpc/af_rxrpc.c b/net/rxrpc/af_rxrpc.c
index 41671af6b33f..2b5f89713e36 100644
--- a/net/rxrpc/af_rxrpc.c
+++ b/net/rxrpc/af_rxrpc.c
@@ -471,6 +471,7 @@  static int rxrpc_connect(struct socket *sock, struct sockaddr *addr,
 	switch (rx->sk.sk_state) {
 	case RXRPC_UNBOUND:
 		rx->sk.sk_state = RXRPC_CLIENT_UNBOUND;
+		break;
 	case RXRPC_CLIENT_UNBOUND:
 	case RXRPC_CLIENT_BOUND:
 		break;