| Message ID | 20210306133624.17237-1-baijiaju1990@gmail.com |
|---|---|
| State | Accepted |
| Commit | 26594c6bbb60c6bc87e3762a86ceece57d164c66 |
| Headers | show |
| Series | rpmsg: qcom_glink_native: fix error return code of qcom_glink_rx_data() | expand |
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Sat, 6 Mar 2021 05:36:24 -0800 you wrote: > When idr_find() returns NULL to intent, no error return code of > qcom_glink_rx_data() is assigned. > To fix this bug, ret is assigned with -ENOENT in this case. > > Reported-by: TOTE Robot <oslab@tsinghua.edu.cn> > Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> > > [...] Here is the summary with links: - rpmsg: qcom_glink_native: fix error return code of qcom_glink_rx_data() https://git.kernel.org/qcom/c/26594c6bbb60 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index 27a05167c18c..4840886532ff 100644 --- a/drivers/rpmsg/qcom_glink_native.c +++ b/drivers/rpmsg/qcom_glink_native.c @@ -857,6 +857,7 @@ static int qcom_glink_rx_data(struct qcom_glink *glink, size_t avail) dev_err(glink->dev, "no intent found for channel %s intent %d", channel->name, liid); + ret = -ENOENT; goto advance_rx; } }
When idr_find() returns NULL to intent, no error return code of qcom_glink_rx_data() is assigned. To fix this bug, ret is assigned with -ENOENT in this case. Reported-by: TOTE Robot <oslab@tsinghua.edu.cn> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> --- drivers/rpmsg/qcom_glink_native.c | 1 + 1 file changed, 1 insertion(+)