diff mbox series

[alsa-ucm-conf,1/3] codecs/es8316: Fix capture settings

Message ID 20210307200308.136385-1-hdegoede@redhat.com
State New
Headers show
Series [alsa-ucm-conf,1/3] codecs/es8316: Fix capture settings | expand

Commit Message

Hans de Goede March 7, 2021, 8:03 p.m. UTC
Fix the following issues with the capture settings:

1. Disable ALC / Auto Level Control, it tries to always get an
   input signal even when the user is not talking into the mic
   leading to it cranking up the volume till there is noise at
   the same level as the user talking.

2. The 'ADC PGA Gain Volume' volume control is not the main
   'ADC vol' control, it is the mic amplifier control and
   setting it to 10 sets it to 24dB not 0dB.
   Adjust the comment and set it to 7 which is 16dB which
   gives a good microphone signal strength without introducing
   too much noise (with 'ADC Capture Volume' set to 0dB).

3. There actually is a main 'ADC vol' control which goes from -96 to 0dB
   which is simply called the 'ADC Capture Volume' and when disabling ALC
   it defaults to -96 dB. Add a line setting it to 0dB.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 ucm2/codecs/es8316/EnableSeq.conf | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Comments

Jaroslav Kysela March 10, 2021, 10 a.m. UTC | #1
Dne 07. 03. 21 v 21:03 Hans de Goede napsal(a):
> Fix the following issues with the capture settings:
> 
> 1. Disable ALC / Auto Level Control, it tries to always get an
>    input signal even when the user is not talking into the mic
>    leading to it cranking up the volume till there is noise at
>    the same level as the user talking.
> 
> 2. The 'ADC PGA Gain Volume' volume control is not the main
>    'ADC vol' control, it is the mic amplifier control and
>    setting it to 10 sets it to 24dB not 0dB.
>    Adjust the comment and set it to 7 which is 16dB which
>    gives a good microphone signal strength without introducing
>    too much noise (with 'ADC Capture Volume' set to 0dB).
> 
> 3. There actually is a main 'ADC vol' control which goes from -96 to 0dB
>    which is simply called the 'ADC Capture Volume' and when disabling ALC
>    it defaults to -96 dB. Add a line setting it to 0dB.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Thank you. I applied all three patches from the set.

Note that it may be better to move the static control presets to the
BootSequence, so the user can eventually fine tune them.

				Jaroslav
diff mbox series

Patch

diff --git a/ucm2/codecs/es8316/EnableSeq.conf b/ucm2/codecs/es8316/EnableSeq.conf
index 97ccfc9..272ef1a 100644
--- a/ucm2/codecs/es8316/EnableSeq.conf
+++ b/ucm2/codecs/es8316/EnableSeq.conf
@@ -11,11 +11,15 @@  EnableSequence [
 	cset "name='Headphone Mixer Volume' 4"
 	# Set DAC vol to 0 dB (192/192)
 	cset "name='DAC Playback Volume' 192"
-	# Set ADC vold to 0 dB (10/10)
-	cset "name='ADC PGA Gain Volume' 10"
+
+	# Disable Auto Level Control
+	cset "name='ALC Capture Switch' off"
+	# Set ADC vol to 0 dB (192/192)
+	cset "name='ADC Capture Volume' 192"
+	# Set Mic amplifier to +16 dB
+	cset "name='ADC PGA Gain Volume' 7"
 
 	# Setup muxes / switches
 	cset "name='Left Headphone Mixer Left DAC Switch' on"
 	cset "name='Right Headphone Mixer Right DAC Switch' on"
-	cset "name='ALC Capture Switch' on"
 ]