| Message ID | CAKdteOY6VTYVjZ3BC2Oe8872S5xpwyY5JJ2oFzjtGpj3_M=_Fg@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
ping? On 26 October 2014 17:50, Christophe Lyon <christophe.lyon@linaro.org> wrote: > On 24 October 2014 10:07, Marcus Shawcroft <marcus.shawcroft@gmail.com> wrote: >> On 21 October 2014 14:02, Christophe Lyon <christophe.lyon@linaro.org> wrote: >>> This patch series is an updated version of the series I sent here: >>> https://gcc.gnu.org/ml/gcc-patches/2014-07/msg00022.html >>> >>> I addressed comments from Marcus and Richard, and decided to skip >>> support for half-precision variants for the time being. I'll post >>> dedicated patches later. >>> >>> Compared to v2: >>> - the directory containing the new tests is named >>> gcc.target/aarch64/adv-simd instead of >>> gcc.target/aarch64/neon-intrinsics. >>> - the driver is named adv-simd.exp instead of neon-intrinsics.exp >>> - the driver is guarded against the new test parallelization framework >>> - the README file uses 'Advanced SIMD (Neon)' instead of 'Neon' >>> >> >> Thank you Christophe. Please commit all 21 patches in the series. >> > Thanks, I have committed the whole series. > > I've just realized afterwards that the tests aren't guarded against > targets not supporting Neon. > > How about adding the attached small patch? > > (ChangeLog incorrectly formatted :-() > 2014-10-26 Christophe Lyon <christophe.lyon@linaro.org> > > gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp: Skip > tests if target does not support Neon. > > > Christophe > >> /Marcus
On Sun, Oct 26, 2014 at 4:50 PM, Christophe Lyon <christophe.lyon@linaro.org> wrote: > On 24 October 2014 10:07, Marcus Shawcroft <marcus.shawcroft@gmail.com> wrote: >> On 21 October 2014 14:02, Christophe Lyon <christophe.lyon@linaro.org> wrote: >>> This patch series is an updated version of the series I sent here: >>> https://gcc.gnu.org/ml/gcc-patches/2014-07/msg00022.html >>> >>> I addressed comments from Marcus and Richard, and decided to skip >>> support for half-precision variants for the time being. I'll post >>> dedicated patches later. >>> >>> Compared to v2: >>> - the directory containing the new tests is named >>> gcc.target/aarch64/adv-simd instead of >>> gcc.target/aarch64/neon-intrinsics. >>> - the driver is named adv-simd.exp instead of neon-intrinsics.exp >>> - the driver is guarded against the new test parallelization framework >>> - the README file uses 'Advanced SIMD (Neon)' instead of 'Neon' >>> >> >> Thank you Christophe. Please commit all 21 patches in the series. >> > Thanks, I have committed the whole series. > > I've just realized afterwards that the tests aren't guarded against > targets not supporting Neon. > > How about adding the attached small patch? > > (ChangeLog incorrectly formatted :-() > 2014-10-26 Christophe Lyon <christophe.lyon@linaro.org> > > gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp: Skip > tests if target does not support Neon. Ok by me ... Ramana > > > Christophe > >> /Marcus
On 26 October 2014 16:50, Christophe Lyon <christophe.lyon@linaro.org> wrote: > I've just realized afterwards that the tests aren't guarded against > targets not supporting Neon. > > How about adding the attached small patch? +if {[istarget arm*-*-*] + && ![check_effective_target_arm_neon_ok]} then { + return +} + Umm, first thought was that this is a bit of a hack but having just discussed it with Ramana we don;t have a better alternative to hand, so OK. /Marcus
diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp index 3aa0e1c..938086b 100644 --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp @@ -32,6 +32,11 @@ load_lib torture-options.exp dg-init +if {[istarget arm*-*-*] + && ![check_effective_target_arm_neon_ok]} then { + return +} + torture-init set-torture-options $C_TORTURE_OPTIONS {{}} $LTO_TORTURE_OPTIONS