From patchwork Tue Mar 9 14:17:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 395997 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp2626013jai; Tue, 9 Mar 2021 06:22:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJx+EKNsXhR8+FOdiOglJnJyzYHT8/jBN+OG/OWnxDf+XFjvJbgfn0/XNj57bBSVJE5biYkd X-Received: by 2002:a92:760c:: with SMTP id r12mr25043908ilc.35.1615299759991; Tue, 09 Mar 2021 06:22:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615299759; cv=none; d=google.com; s=arc-20160816; b=co8oi+lDTH1yxTYSqNfZTEJ9SoCAydSz6e/bESLvBh9bUE954KUBGCLv4Gca2SbOkt /NE62h5ObTDUN2FxP94IbKdC1CJczfC7jmIcJg36t9SvQmPoxjlDhNEWc2sXITsyLubb whFxL9XGphE6uwzwM8EPNdImM9PM93OBkm8w84SiafZ6U7ANAoPZ8wiQgk3ZIql9Azjy P5gIua3S/Qrnvy0ZvUq0Eek/V2hUYfKIAdGsDghjih8jt3WYJAd9ZfnWUobcGshguKjT Nr3FBKNyvfcS94z6urWZnbMfzPXglX2rFKW5rpPDYOWcrjAebpPDddXjcK57tPdtWthZ Ez0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=nN/o3NC1BjCVaVugecWZFPBtRdcQ9Jd3TS2cKRxBLsA=; b=0DpgLpMrblYGZ/KyEz14M4eenrAv7JqRiiJOom+clNetnaomdSsgYUm9Dmcju/t6ph qbp+QbsXwHntXfyajVR5rJnzeR9judXxu4EPV6cQ30DR9DrZEYl/xWDpw6IZrrRxnpUR 2zVMv8eUcKQn4OxHdHD7MmZI6QKa6w3oSArvvTbp0Q0XhAyzJG3HUfaDSB2zleXsrGtp 9wK2HZQ9/IZEa5OipTUSF8JbrONGp8TiXjAUd+4WHfmhFnFTUQjuTjQAsyjHRdneZJjh TAmyg0yULZla02sK+WMY/9MUvdZvdvkO9g9moqVMA438kS/azCy8PCzFi4+R8Zrlb4OT SKVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Psti3gEG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n4si12568899ili.37.2021.03.09.06.22.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Mar 2021 06:22:39 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Psti3gEG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:51978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJdFv-0004oL-DY for patch@linaro.org; Tue, 09 Mar 2021 09:22:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJdB2-0001Ne-Ha for qemu-devel@nongnu.org; Tue, 09 Mar 2021 09:17:36 -0500 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:51748) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJdB0-0001ic-Qn for qemu-devel@nongnu.org; Tue, 09 Mar 2021 09:17:36 -0500 Received: by mail-wm1-x32e.google.com with SMTP id l22so2074385wme.1 for ; Tue, 09 Mar 2021 06:17:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nN/o3NC1BjCVaVugecWZFPBtRdcQ9Jd3TS2cKRxBLsA=; b=Psti3gEGTHOBatFrhi4usMelQDLv5p8QRvNUVI/4Uoae3py2vs0WNWnGKO/nPJWwGm fSFSvl4Wf6kgg/LCrzn6tQMNHbqv4U2OfSPobYy5r5VCtsDvfBQ6ouoZqmG9ixhIx1cm 4qx83HoQ7fjQDSuK1qq3w5UEPZZFx7XvQIyiNhsUP4l9iLamqrrvPbsWJ5qHPF+pRRlo mYv1wpajO6eViNo/iac3GoKje1tbICYAl8ed7MdRF7+UHFk4SQdbqBFaplXClBwKzsGN BMPn9SGGsWCdjIJ0rZktraW0rHVZPAUZxyEuSB41OniVQFzlRyPGAYzyCCzAcZx2NY5m I8/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nN/o3NC1BjCVaVugecWZFPBtRdcQ9Jd3TS2cKRxBLsA=; b=RGvaz88DW0K3UYJtyiVQwFozdYT9C711UU2KvZTU23Ak9YK3vVIAjj0zbS/YeHS7SG wUYe0+uzGpEbAd8garQ+G+t/lhUrMOgyFN6OJcW08bTnHcVt9A6/d/GtsSqgBqXL0An3 jh1a3EwOp4UAidU0jWwkjIta9oye11Oltdnd1I2jC5Y1kEVcIlq9rTS/aa47NzIibizX WhB+0GOMISTQBLBNU58W6BGDt9ovI01aOXUpetsueZ2DQLs2tNCZpf6E1l40xyU3/kZM XvSius3EF8vBANvaXArMXkHSQwjvfhpPEUOair8fRtiuN7CszB2RVplTIJCKTaA3MyvW TynA== X-Gm-Message-State: AOAM533vcxAMvzK7/bKZ+bfZ3qPr4qwNV7PfCFN7X8yjmPL+LY1J/xQI DcB3HHqwxXOEwipHTsOqk+l0uQ== X-Received: by 2002:a05:600c:4ba2:: with SMTP id e34mr4308715wmp.121.1615299453372; Tue, 09 Mar 2021 06:17:33 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id f22sm4147037wmc.33.2021.03.09.06.17.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Mar 2021 06:17:31 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 5CB931FF8F; Tue, 9 Mar 2021 14:17:28 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v2 3/4] semihosting/arm-compat-semi: deref parameter register for SYS_HEAPINFO Date: Tue, 9 Mar 2021 14:17:26 +0000 Message-Id: <20210309141727.12522-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210309141727.12522-1-alex.bennee@linaro.org> References: <20210309141727.12522-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bug 1915925 <1915925@bugs.launchpad.net>, keithp@keithp.com, =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" As per the spec: the PARAMETER REGISTER contains the address of a pointer to a four-field data block. So we need to follow the pointer and place the results of SYS_HEAPINFO there. Bug: https://bugs.launchpad.net/bugs/1915925 Cc: Bug 1915925 <1915925@bugs.launchpad.net> Cc: Keith Packard Signed-off-by: Alex Bennée --- semihosting/arm-compat-semi.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.20.1 diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c index 733eea1e2d..2ac9226d29 100644 --- a/semihosting/arm-compat-semi.c +++ b/semihosting/arm-compat-semi.c @@ -1210,6 +1210,8 @@ target_ulong do_common_semihosting(CPUState *cs) retvals[2] = rambase + limit; /* Stack base */ retvals[3] = rambase; /* Stack limit. */ #endif + /* The result array is pointed to by arg0 */ + args = arg0; for (i = 0; i < ARRAY_SIZE(retvals); i++) { bool fail;