| Message ID | 1615272478-52458-1-git-send-email-yang.lee@linux.alibaba.com |
|---|---|
| State | New |
| Headers | show |
| Series | mmc: via-sdmmc: remove unneeded variable 'ret' | expand |
On Tue, 9 Mar 2021 at 07:48, Yang Li <yang.lee@linux.alibaba.com> wrote: > > Fix the following coccicheck warning: > ./drivers/mmc/host/via-sdmmc.c:1274:5-8: Unneeded variable: "ret". > Return "0" on line 1295 > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/via-sdmmc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/via-sdmmc.c b/drivers/mmc/host/via-sdmmc.c > index 4f4c081..a1d0985 100644 > --- a/drivers/mmc/host/via-sdmmc.c > +++ b/drivers/mmc/host/via-sdmmc.c > @@ -1271,7 +1271,6 @@ static int __maybe_unused via_sd_suspend(struct device *dev) > static int __maybe_unused via_sd_resume(struct device *dev) > { > struct via_crdr_mmc_host *sdhost; > - int ret = 0; > u8 gatt; > > sdhost = dev_get_drvdata(dev); > @@ -1292,7 +1291,7 @@ static int __maybe_unused via_sd_resume(struct device *dev) > via_restore_pcictrlreg(sdhost); > via_init_sdc_pm(sdhost); > > - return ret; > + return 0; > } > > static SIMPLE_DEV_PM_OPS(via_sd_pm_ops, via_sd_suspend, via_sd_resume); > -- > 1.8.3.1 >
diff --git a/drivers/mmc/host/via-sdmmc.c b/drivers/mmc/host/via-sdmmc.c index 4f4c081..a1d0985 100644 --- a/drivers/mmc/host/via-sdmmc.c +++ b/drivers/mmc/host/via-sdmmc.c @@ -1271,7 +1271,6 @@ static int __maybe_unused via_sd_suspend(struct device *dev) static int __maybe_unused via_sd_resume(struct device *dev) { struct via_crdr_mmc_host *sdhost; - int ret = 0; u8 gatt; sdhost = dev_get_drvdata(dev); @@ -1292,7 +1291,7 @@ static int __maybe_unused via_sd_resume(struct device *dev) via_restore_pcictrlreg(sdhost); via_init_sdc_pm(sdhost); - return ret; + return 0; } static SIMPLE_DEV_PM_OPS(via_sd_pm_ops, via_sd_suspend, via_sd_resume);
Fix the following coccicheck warning: ./drivers/mmc/host/via-sdmmc.c:1274:5-8: Unneeded variable: "ret". Return "0" on line 1295 Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/mmc/host/via-sdmmc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)