| Message ID | 20210311130126.15972-2-oneukum@suse.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] cdc-acm: untangle a circular dependency between callback and softint | expand |
Den tor. 11. mar. 2021 kl. 14.01 skrev Oliver Neukum <oneukum@suse.com>: > > This failure is so common that logging an error here amounts > to spamming log files. > > Signed-off-by: Oliver Neukum <oneukum@suse.com> Reviewed-by: Bruno Thomsen <bruno.thomsen@gmail.com> I can confirm that this error message is very common on embedded Linux systems. /Bruno > --- > drivers/usb/class/cdc-acm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c > index d684cf94b1c0..fd2fce072985 100644 > --- a/drivers/usb/class/cdc-acm.c > +++ b/drivers/usb/class/cdc-acm.c > @@ -659,7 +659,8 @@ static void acm_port_dtr_rts(struct tty_port *port, int raise) > > res = acm_set_control(acm, val); > if (res && (acm->ctrl_caps & USB_CDC_CAP_LINE)) > - dev_err(&acm->control->dev, "failed to set dtr/rts\n"); > + /* This is broken in too many devices to spam the logs */ > + dev_dbg(&acm->control->dev, "failed to set dtr/rts\n"); > } > > static int acm_port_activate(struct tty_port *port, struct tty_struct *tty) > -- > 2.26.2 >
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index d684cf94b1c0..fd2fce072985 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -659,7 +659,8 @@ static void acm_port_dtr_rts(struct tty_port *port, int raise) res = acm_set_control(acm, val); if (res && (acm->ctrl_caps & USB_CDC_CAP_LINE)) - dev_err(&acm->control->dev, "failed to set dtr/rts\n"); + /* This is broken in too many devices to spam the logs */ + dev_dbg(&acm->control->dev, "failed to set dtr/rts\n"); } static int acm_port_activate(struct tty_port *port, struct tty_struct *tty)
This failure is so common that logging an error here amounts to spamming log files. Signed-off-by: Oliver Neukum <oneukum@suse.com> --- drivers/usb/class/cdc-acm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)