[26/30] scsi: atp870u: Fix naming and demote incorrect and non-conformant kernel-doc header

Message ID 20210312094738.2207817-27-lee.jones@linaro.org
State New
Headers show
Series
  • Rid W=1 warnings in SCSI
Related show

Commit Message

Lee Jones March 12, 2021, 9:47 a.m.
Fixes the following W=1 kernel build warning(s):

 drivers/scsi/atp870u.c:623: warning: expecting prototype for atp870u_queuecommand(). Prototype was for atp870u_queuecommand_lck() instead
 drivers/scsi/atp870u.c:724: warning: Function parameter or member 'dev' not described in 'send_s870'
 drivers/scsi/atp870u.c:724: warning: Function parameter or member 'c' not described in 'send_s870'
 drivers/scsi/atp870u.c:724: warning: Excess function parameter 'host' description in 'send_s870'

Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/scsi/atp870u.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

-- 
2.27.0

Patch

diff --git a/drivers/scsi/atp870u.c b/drivers/scsi/atp870u.c
index da6ca2b153d85..9d179cd15bb84 100644
--- a/drivers/scsi/atp870u.c
+++ b/drivers/scsi/atp870u.c
@@ -612,7 +612,7 @@  static irqreturn_t atp870u_intr_handle(int irq, void *dev_id)
 	return IRQ_HANDLED;
 }
 /**
- *	atp870u_queuecommand	-	Queue SCSI command
+ *	atp870u_queuecommand_lck -	Queue SCSI command
  *	@req_p: request block
  *	@done: completion function
  *
@@ -711,16 +711,15 @@  static int atp870u_queuecommand_lck(struct scsi_cmnd *req_p,
 
 static DEF_SCSI_QCMD(atp870u_queuecommand)
 
-/**
+/*
  *	send_s870	-	send a command to the controller
- *	@host: host
  *
  *	On entry there is work queued to be done. We move some of that work to the
  *	controller itself.
  *
  *	Caller holds the host lock.
  */
-static void send_s870(struct atp_unit *dev,unsigned char c)
+static void send_s870(struct atp_unit *dev, unsigned char c)
 {
 	struct scsi_cmnd *workreq = NULL;
 	unsigned int i;//,k;