diff mbox series

[-next] gpiolib: Fix error return code in gpiolib_dev_init()

Message ID 20210312080423.278094-1-weiyongjun1@huawei.com
State Accepted
Commit 3875721e825cf3ab05fc1a52b6cbd76c8d16da51
Headers show
Series [-next] gpiolib: Fix error return code in gpiolib_dev_init() | expand

Commit Message

Wei Yongjun March 12, 2021, 8:04 a.m. UTC 
From: Wei Yongjun <weiyongjun1@huawei.com>

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 4731210c09f5 ("gpiolib: Bind gpio_device to a driver to enable fw_devlink=on by default")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/gpio/gpiolib.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index cee4333f8ac7..18086262dd48 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -4242,7 +4242,8 @@  static int __init gpiolib_dev_init(void)
 		return ret;
 	}
 
-	if (driver_register(&gpio_stub_drv) < 0) {
+	ret = driver_register(&gpio_stub_drv);
+	if (ret < 0) {
 		pr_err("gpiolib: could not register GPIO stub driver\n");
 		bus_unregister(&gpio_bus_type);
 		return ret;