drm/panel: s6e63m0: Depromote debug prints

Message ID 20210313230913.4108256-1-linus.walleij@linaro.org
State New
Headers show
Series
  • drm/panel: s6e63m0: Depromote debug prints
Related show

Commit Message

Linus Walleij March 13, 2021, 11:09 p.m.
The dev_info():s in the DSI driver are very talkative,
depromote these to dev_dbg().

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
 drivers/gpu/drm/panel/panel-samsung-s6e63m0-dsi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.29.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Comments

Linus Walleij May 9, 2021, 11:09 p.m. | #1
On Sun, Mar 14, 2021 at 12:09 AM Linus Walleij <linus.walleij@linaro.org> wrote:

> The dev_info():s in the DSI driver are very talkative,

> depromote these to dev_dbg().

>

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>


Could someone show mercy on this patch and apply
it? Pretty please. Patch reviews offered in return.

Yours,
Linus Walleij
Daniel Vetter May 10, 2021, 3:37 p.m. | #2
On Mon, May 10, 2021 at 01:09:27AM +0200, Linus Walleij wrote:
> On Sun, Mar 14, 2021 at 12:09 AM Linus Walleij <linus.walleij@linaro.org> wrote:

> 

> > The dev_info():s in the DSI driver are very talkative,

> > depromote these to dev_dbg().

> >

> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

> 

> Could someone show mercy on this patch and apply

> it? Pretty please. Patch reviews offered in return.


Indeed that's a very talkative driver.

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>


> 

> Yours,

> Linus Walleij


-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Patch

diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e63m0-dsi.c b/drivers/gpu/drm/panel/panel-samsung-s6e63m0-dsi.c
index eec74c10ddda..bf0f4b4f1d20 100644
--- a/drivers/gpu/drm/panel/panel-samsung-s6e63m0-dsi.c
+++ b/drivers/gpu/drm/panel/panel-samsung-s6e63m0-dsi.c
@@ -27,7 +27,7 @@  static int s6e63m0_dsi_dcs_read(struct device *dev, const u8 cmd, u8 *data)
 		return ret;
 	}
 
-	dev_info(dev, "DSI read CMD %02x = %02x\n", cmd, *data);
+	dev_dbg(dev, "DSI read CMD %02x = %02x\n", cmd, *data);
 
 	return 0;
 }
@@ -42,7 +42,7 @@  static int s6e63m0_dsi_dcs_write(struct device *dev, const u8 *data, size_t len)
 	int chunk;
 	int ret;
 
-	dev_info(dev, "DSI writing dcs seq: %*ph\n", (int)len, data);
+	dev_dbg(dev, "DSI writing dcs seq: %*ph\n", (int)len, data);
 
 	/* Pick out and skip past the DCS command */
 	cmd = *seqp;
@@ -80,7 +80,7 @@  static int s6e63m0_dsi_dcs_write(struct device *dev, const u8 *data, size_t len)
 		cmdwritten += chunk;
 		seqp += chunk;
 	}
-	dev_info(dev, "sent command %02x %02x bytes\n", cmd, cmdwritten);
+	dev_dbg(dev, "sent command %02x %02x bytes\n", cmd, cmdwritten);
 
 	usleep_range(8000, 9000);