| Message ID | 1415098124.11486.21.camel@citrix.com |
|---|---|
| State | New |
| Headers | show |
> On 4 Nov 2014, at 10:48, Ian Campbell <Ian.Campbell@citrix.com> wrote: > > On Thu, 2014-10-23 at 11:00 +0100, Andrew Cooper wrote: > >>> Did you instead mean this from libxl_types.idl: >>> # Valid iff (shutdown||dying). >>> # >>> # Otherwise set to a value guaranteed not to clash with any valid >>> # LIBXL_SHUTDOWN_REASON_* constant. >>> ("shutdown_reason", libxl_shutdown_reason), >>> ? >> >> That is the primary comment I was on about. > > This wasn't tagged for 4.5 but it is a bug fix and the commit log & > associated commentary were pretty convincing, so Acked + Applied with > the additional hunk below folded in. > > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl > index ca3f724..f7fc695 100644 > --- a/tools/libxl/libxl_types.idl > +++ b/tools/libxl/libxl_types.idl > @@ -260,7 +260,7 @@ libxl_dominfo = Struct("dominfo",[ > ("shutdown", bool), > ("dying", bool), > > - # Valid iff (shutdown||dying). > + # Valid iff ->shutdown is true. Great, thanks for doing this (after I forgot!) Cheers, Dave > # > # Otherwise set to a value guaranteed not to clash with any valid > # LIBXL_SHUTDOWN_REASON_* constant. > >
On Tue, 2014-11-04 at 11:34 +0000, Dave Scott wrote: > > On 4 Nov 2014, at 10:48, Ian Campbell <Ian.Campbell@citrix.com> wrote: > > > > On Thu, 2014-10-23 at 11:00 +0100, Andrew Cooper wrote: > > > >>> Did you instead mean this from libxl_types.idl: > >>> # Valid iff (shutdown||dying). > >>> # > >>> # Otherwise set to a value guaranteed not to clash with any valid > >>> # LIBXL_SHUTDOWN_REASON_* constant. > >>> ("shutdown_reason", libxl_shutdown_reason), > >>> ? > >> > >> That is the primary comment I was on about. > > > > This wasn't tagged for 4.5 but it is a bug fix and the commit log & > > associated commentary were pretty convincing, so Acked + Applied with > > the additional hunk below folded in. > > > > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl > > index ca3f724..f7fc695 100644 > > --- a/tools/libxl/libxl_types.idl > > +++ b/tools/libxl/libxl_types.idl > > @@ -260,7 +260,7 @@ libxl_dominfo = Struct("dominfo",[ > > ("shutdown", bool), > > ("dying", bool), > > > > - # Valid iff (shutdown||dying). > > + # Valid iff ->shutdown is true. > > Great, thanks for doing this (after I forgot!) It was easier than pinging ;-)
diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl index ca3f724..f7fc695 100644 --- a/tools/libxl/libxl_types.idl +++ b/tools/libxl/libxl_types.idl @@ -260,7 +260,7 @@ libxl_dominfo = Struct("dominfo",[ ("shutdown", bool), ("dying", bool), - # Valid iff (shutdown||dying). + # Valid iff ->shutdown is true. # # Otherwise set to a value guaranteed not to clash with any valid # LIBXL_SHUTDOWN_REASON_* constant.