dt-bindings: Drop type references on common properties

Message ID 20210316194858.3527845-1-robh@kernel.org
State New
Headers show
Series
  • dt-bindings: Drop type references on common properties
Related show

Commit Message

Rob Herring March 16, 2021, 7:48 p.m.
Users of common properties shouldn't have a type definition as the
common schemas already have one. Drop all the unnecessary type
references in the tree.

A meta-schema update to catch these is pending.

Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Ohad Ben-Cohen <ohad@wizery.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Cheng-Yi Chiang <cychiang@chromium.org>
Cc: Benson Leung <bleung@chromium.org>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Stefan Wahren <wahrenst@gmx.net>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Odelu Kukatla <okukatla@codeaurora.org>
Cc: Alex Elder <elder@kernel.org>
Cc: Suman Anna <s-anna@ti.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: linux-gpio@vger.kernel.org
Cc: linux-pm@vger.kernel.org
Cc: linux-can@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: linux-remoteproc@vger.kernel.org
Cc: alsa-devel@alsa-project.org
Cc: linux-usb@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml       | 5 +----
 Documentation/devicetree/bindings/arm/cpus.yaml              | 2 --
 .../bindings/display/allwinner,sun4i-a10-tcon.yaml           | 1 -
 .../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml    | 3 +--
 .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml      | 1 -
 .../devicetree/bindings/interconnect/qcom,rpmh.yaml          | 1 -
 .../bindings/memory-controllers/nvidia,tegra210-emc.yaml     | 2 +-
 Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml   | 1 -
 Documentation/devicetree/bindings/net/qcom,ipa.yaml          | 1 -
 Documentation/devicetree/bindings/nvmem/nvmem-consumer.yaml  | 2 --
 .../devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml   | 2 +-
 Documentation/devicetree/bindings/sound/ak4642.yaml          | 2 --
 .../devicetree/bindings/sound/google,cros-ec-codec.yaml      | 2 +-
 Documentation/devicetree/bindings/sound/renesas,rsnd.yaml    | 1 -
 .../devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml       | 1 -
 Documentation/devicetree/bindings/usb/usb.yaml               | 1 -
 16 files changed, 5 insertions(+), 23 deletions(-)

Comments

Dmitry Baryshkov March 16, 2021, 8:23 p.m. | #1
On Tue, 16 Mar 2021 at 22:49, Rob Herring <robh@kernel.org> wrote:
>
> Users of common properties shouldn't have a type definition as the
> common schemas already have one. Drop all the unnecessary type
> references in the tree.
>
> A meta-schema update to catch these is pending.
>
> Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Marc Kleine-Budde <mkl@pengutronix.de>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Cc: Ohad Ben-Cohen <ohad@wizery.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Cheng-Yi Chiang <cychiang@chromium.org>
> Cc: Benson Leung <bleung@chromium.org>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Stefan Wahren <wahrenst@gmx.net>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Cc: Odelu Kukatla <okukatla@codeaurora.org>
> Cc: Alex Elder <elder@kernel.org>
> Cc: Suman Anna <s-anna@ti.com>
> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-pm@vger.kernel.org
> Cc: linux-can@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: linux-remoteproc@vger.kernel.org
> Cc: alsa-devel@alsa-project.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml       | 5 +----
>  Documentation/devicetree/bindings/arm/cpus.yaml              | 2 --
>  .../bindings/display/allwinner,sun4i-a10-tcon.yaml           | 1 -
>  .../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml    | 3 +--
>  .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml      | 1 -
>  .../devicetree/bindings/interconnect/qcom,rpmh.yaml          | 1 -
>  .../bindings/memory-controllers/nvidia,tegra210-emc.yaml     | 2 +-
>  Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml   | 1 -
>  Documentation/devicetree/bindings/net/qcom,ipa.yaml          | 1 -
>  Documentation/devicetree/bindings/nvmem/nvmem-consumer.yaml  | 2 --
>  .../devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml   | 2 +-
>  Documentation/devicetree/bindings/sound/ak4642.yaml          | 2 --
>  .../devicetree/bindings/sound/google,cros-ec-codec.yaml      | 2 +-
>  Documentation/devicetree/bindings/sound/renesas,rsnd.yaml    | 1 -
>  .../devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml       | 1 -
>  Documentation/devicetree/bindings/usb/usb.yaml               | 1 -
>  16 files changed, 5 insertions(+), 23 deletions(-)

For the qcom-spmi-adc-tm5.yaml:
Acked-by: Dmity Baryshkov <dmitry.baryshkov@linaro.org>

>
> diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> index a2c63c8b1d10..c6144c8421fa 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> @@ -26,10 +26,7 @@ properties:
>        - const: simple-mfd
>
>    mboxes:
> -    $ref: '/schemas/types.yaml#/definitions/phandle'
> -    description: |
> -      Phandle to the firmware device's Mailbox.
> -      (See: ../mailbox/mailbox.txt for more information)
> +    maxItems: 1
>
>    clocks:
>      type: object
> diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
> index 26b886b20b27..6be4a8852ee5 100644
> --- a/Documentation/devicetree/bindings/arm/cpus.yaml
> +++ b/Documentation/devicetree/bindings/arm/cpus.yaml
> @@ -256,13 +256,11 @@ properties:
>        where voltage is in V, frequency is in MHz.
>
>    power-domains:
> -    $ref: '/schemas/types.yaml#/definitions/phandle-array'
>      description:
>        List of phandles and PM domain specifiers, as defined by bindings of the
>        PM domain provider (see also ../power_domain.txt).
>
>    power-domain-names:
> -    $ref: '/schemas/types.yaml#/definitions/string-array'
>      description:
>        A list of power domain name strings sorted in the same order as the
>        power-domains property.
> diff --git a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
> index c13faf3e6581..3a7d5d731712 100644
> --- a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
> +++ b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
> @@ -73,7 +73,6 @@ properties:
>    clock-output-names:
>      description:
>        Name of the LCD pixel clock created.
> -    $ref: /schemas/types.yaml#/definitions/string-array
>      maxItems: 1
>
>    dmas:
> diff --git a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
> index 1a54db04f29d..bcafa494ed7a 100644
> --- a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
> @@ -43,8 +43,7 @@ properties:
>
>    gpio-ranges: true
>
> -  gpio-ranges-group-names:
> -    $ref: /schemas/types.yaml#/definitions/string-array
> +  gpio-ranges-group-names: true
>
>    socionext,interrupt-ranges:
>      description: |
> diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml
> index 6f2398cdc82d..1e7894e524f9 100644
> --- a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml
> @@ -102,7 +102,6 @@ patternProperties:
>
>        st,adc-channel-names:
>          description: List of single-ended channel names.
> -        $ref: /schemas/types.yaml#/definitions/string-array
>
>        st,filter-order:
>          description: |
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
> index 799e73cdb90b..13da7b29c707 100644
> --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
> @@ -82,7 +82,6 @@ properties:
>        this interconnect to send RPMh commands.
>
>    qcom,bcm-voter-names:
> -    $ref: /schemas/types.yaml#/definitions/string-array
>      description: |
>        Names for each of the qcom,bcm-voters specified.
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra210-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra210-emc.yaml
> index 49ab09252e52..bc8477e7ab19 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra210-emc.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra210-emc.yaml
> @@ -34,7 +34,7 @@ properties:
>        - description: EMC general interrupt
>
>    memory-region:
> -    $ref: /schemas/types.yaml#/definitions/phandle
> +    maxItems: 1
>      description:
>        phandle to a reserved memory region describing the table of EMC
>        frequencies trained by the firmware
> diff --git a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> index fe6a949a2eab..55bff1586b6f 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> +++ b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> @@ -57,7 +57,6 @@ properties:
>        - const: per
>
>    clock-frequency:
> -    $ref: /schemas/types.yaml#/definitions/uint32
>      description: |
>        The oscillator frequency driving the flexcan device, filled in by the
>        boot loader. This property should only be used the used operating system
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index 8f86084bf12e..4e8dee4aa90d 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -100,7 +100,6 @@ properties:
>        - description: Whether the IPA clock is enabled (if valid)
>
>    qcom,smem-state-names:
> -    $ref: /schemas/types.yaml#/definitions/string-array
>      description: The names of the state bits used for SMP2P output
>      items:
>        - const: ipa-clock-enabled-valid
> diff --git a/Documentation/devicetree/bindings/nvmem/nvmem-consumer.yaml b/Documentation/devicetree/bindings/nvmem/nvmem-consumer.yaml
> index d5d7f113bade..828e4a1ece41 100644
> --- a/Documentation/devicetree/bindings/nvmem/nvmem-consumer.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/nvmem-consumer.yaml
> @@ -23,12 +23,10 @@ properties:
>        List of phandle to the nvmem data cells.
>
>    nvmem-names:
> -    $ref: /schemas/types.yaml#/definitions/string-array
>      description:
>        Names for the each nvmem provider.
>
>    nvmem-cell-names:
> -    $ref: /schemas/types.yaml#/definitions/string-array
>      description:
>        Names for each nvmem-cells specified.
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml
> index 1a1159097a2a..73400bc6e91d 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml
> @@ -93,7 +93,7 @@ properties:
>  # The following are the optional properties:
>
>    memory-region:
> -    $ref: /schemas/types.yaml#/definitions/phandle
> +    maxItems: 1
>      description: |
>        phandle to the reserved memory node to be associated
>        with the remoteproc device. The reserved memory node
> diff --git a/Documentation/devicetree/bindings/sound/ak4642.yaml b/Documentation/devicetree/bindings/sound/ak4642.yaml
> index 6cd213be2266..1e2caa29790e 100644
> --- a/Documentation/devicetree/bindings/sound/ak4642.yaml
> +++ b/Documentation/devicetree/bindings/sound/ak4642.yaml
> @@ -29,11 +29,9 @@ properties:
>
>    clock-frequency:
>      description: common clock binding; frequency of MCKO
> -    $ref: /schemas/types.yaml#/definitions/uint32
>
>    clock-output-names:
>      description: common clock name
> -    $ref: /schemas/types.yaml#/definitions/string
>
>  required:
>    - compatible
> diff --git a/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml
> index acfb9db021dc..77adbebed824 100644
> --- a/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml
> +++ b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml
> @@ -32,7 +32,7 @@ properties:
>            The last one integer is the length of the shared memory.
>
>    memory-region:
> -    $ref: '/schemas/types.yaml#/definitions/phandle'
> +    maxItems: 1
>      description: |
>        Shared memory region to EC.  A "shared-dma-pool".
>        See ../reserved-memory/reserved-memory.txt for details.
> diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> index 2e1046513603..e494a0416748 100644
> --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> @@ -78,7 +78,6 @@ properties:
>
>    clock-frequency:
>      description: for audio_clkout0/1/2/3
> -    $ref: /schemas/types.yaml#/definitions/uint32-array
>
>    clkout-lr-asynchronous:
>      description: audio_clkoutn is asynchronizes with lr-clock.
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml b/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml
> index 95a728f4d333..3ea8c0c1f45f 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml
> @@ -59,7 +59,6 @@ patternProperties:
>
>      properties:
>        reg:
> -        $ref: /schemas/types.yaml#/definitions/uint32
>          description: Specify the sensor channel. There are 8 channels in PMIC5's ADC TM
>          minimum: 0
>          maximum: 7
> diff --git a/Documentation/devicetree/bindings/usb/usb.yaml b/Documentation/devicetree/bindings/usb/usb.yaml
> index 78491e66ed24..939f217b8c7b 100644
> --- a/Documentation/devicetree/bindings/usb/usb.yaml
> +++ b/Documentation/devicetree/bindings/usb/usb.yaml
> @@ -16,7 +16,6 @@ properties:
>      pattern: "^usb(@.*)?"
>
>    phys:
> -    $ref: /schemas/types.yaml#/definitions/phandle-array
>      description:
>        List of all the USB PHYs on this HCD
>
> --
> 2.27.0
>
Marc Kleine-Budde March 17, 2021, 8:30 a.m. | #2
On 16.03.2021 13:48:58, Rob Herring wrote:
> Users of common properties shouldn't have a type definition as the

> common schemas already have one. Drop all the unnecessary type

> references in the tree.

> 

> A meta-schema update to catch these is pending.

> 

> Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>

> Cc: Maxime Ripard <mripard@kernel.org>

> Cc: Linus Walleij <linus.walleij@linaro.org>

> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>

> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>

> Cc: Krzysztof Kozlowski <krzk@kernel.org>

> Cc: Marc Kleine-Budde <mkl@pengutronix.de>

> Cc: "David S. Miller" <davem@davemloft.net>

> Cc: Jakub Kicinski <kuba@kernel.org>

> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> Cc: Ohad Ben-Cohen <ohad@wizery.com>

> Cc: Mark Brown <broonie@kernel.org>

> Cc: Cheng-Yi Chiang <cychiang@chromium.org>

> Cc: Benson Leung <bleung@chromium.org>

> Cc: Zhang Rui <rui.zhang@intel.com>

> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>

> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

> Cc: Stefan Wahren <wahrenst@gmx.net>

> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>

> Cc: Odelu Kukatla <okukatla@codeaurora.org>

> Cc: Alex Elder <elder@kernel.org>

> Cc: Suman Anna <s-anna@ti.com>

> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> Cc: linux-gpio@vger.kernel.org

> Cc: linux-pm@vger.kernel.org

> Cc: linux-can@vger.kernel.org

> Cc: netdev@vger.kernel.org

> Cc: linux-remoteproc@vger.kernel.org

> Cc: alsa-devel@alsa-project.org

> Cc: linux-usb@vger.kernel.org

> Signed-off-by: Rob Herring <robh@kernel.org>

> ---

>  .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml       | 5 +----

>  Documentation/devicetree/bindings/arm/cpus.yaml              | 2 --

>  .../bindings/display/allwinner,sun4i-a10-tcon.yaml           | 1 -

>  .../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml    | 3 +--

>  .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml      | 1 -

>  .../devicetree/bindings/interconnect/qcom,rpmh.yaml          | 1 -

>  .../bindings/memory-controllers/nvidia,tegra210-emc.yaml     | 2 +-

>  Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml   | 1 -


For the flexcan:

Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>


regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |
Srinivas Kandagatla March 17, 2021, 8:59 a.m. | #3
On 16/03/2021 19:48, Rob Herring wrote:
> Users of common properties shouldn't have a type definition as the

> common schemas already have one. Drop all the unnecessary type

> references in the tree.

> 

> A meta-schema update to catch these is pending.

> 

> Cc: Nicolas Saenz Julienne<nsaenzjulienne@suse.de>

> Cc: Maxime Ripard<mripard@kernel.org>

> Cc: Linus Walleij<linus.walleij@linaro.org>

> Cc: Bartosz Golaszewski<bgolaszewski@baylibre.com>

> Cc: Bjorn Andersson<bjorn.andersson@linaro.org>

> Cc: Krzysztof Kozlowski<krzk@kernel.org>

> Cc: Marc Kleine-Budde<mkl@pengutronix.de>

> Cc: "David S. Miller"<davem@davemloft.net>

> Cc: Jakub Kicinski<kuba@kernel.org>

> Cc: Srinivas Kandagatla<srinivas.kandagatla@linaro.org>

> Cc: Ohad Ben-Cohen<ohad@wizery.com>

> Cc: Mark Brown<broonie@kernel.org>

> Cc: Cheng-Yi Chiang<cychiang@chromium.org>

> Cc: Benson Leung<bleung@chromium.org>

> Cc: Zhang Rui<rui.zhang@intel.com>

> Cc: Daniel Lezcano<daniel.lezcano@linaro.org>

> Cc: Greg Kroah-Hartman<gregkh@linuxfoundation.org>

> Cc: Stefan Wahren<wahrenst@gmx.net>

> Cc: Masahiro Yamada<yamada.masahiro@socionext.com>

> Cc: Odelu Kukatla<okukatla@codeaurora.org>

> Cc: Alex Elder<elder@kernel.org>

> Cc: Suman Anna<s-anna@ti.com>

> Cc: Kuninori Morimoto<kuninori.morimoto.gx@renesas.com>

> Cc: Dmitry Baryshkov<dmitry.baryshkov@linaro.org>

> Cc:linux-gpio@vger.kernel.org

> Cc:linux-pm@vger.kernel.org

> Cc:linux-can@vger.kernel.org

> Cc:netdev@vger.kernel.org

> Cc:linux-remoteproc@vger.kernel.org

> Cc:alsa-devel@alsa-project.org

> Cc:linux-usb@vger.kernel.org

> Signed-off-by: Rob Herring<robh@kernel.org>

> ---

>   .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml       | 5 +----

>   Documentation/devicetree/bindings/arm/cpus.yaml              | 2 --

>   .../bindings/display/allwinner,sun4i-a10-tcon.yaml           | 1 -

>   .../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml    | 3 +--

>   .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml      | 1 -

>   .../devicetree/bindings/interconnect/qcom,rpmh.yaml          | 1 -

>   .../bindings/memory-controllers/nvidia,tegra210-emc.yaml     | 2 +-

>   Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml   | 1 -

>   Documentation/devicetree/bindings/net/qcom,ipa.yaml          | 1 -

>   Documentation/devicetree/bindings/nvmem/nvmem-consumer.yaml  | 2 --


For nvmem parts,

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>


--srini
Maxime Ripard March 17, 2021, 9:44 a.m. | #4
On Tue, Mar 16, 2021 at 01:48:58PM -0600, Rob Herring wrote:
> Users of common properties shouldn't have a type definition as the

> common schemas already have one. Drop all the unnecessary type

> references in the tree.

> 

> A meta-schema update to catch these is pending.

> 

> Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>

> Cc: Maxime Ripard <mripard@kernel.org>

> Cc: Linus Walleij <linus.walleij@linaro.org>

> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>

> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>

> Cc: Krzysztof Kozlowski <krzk@kernel.org>

> Cc: Marc Kleine-Budde <mkl@pengutronix.de>

> Cc: "David S. Miller" <davem@davemloft.net>

> Cc: Jakub Kicinski <kuba@kernel.org>

> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> Cc: Ohad Ben-Cohen <ohad@wizery.com>

> Cc: Mark Brown <broonie@kernel.org>

> Cc: Cheng-Yi Chiang <cychiang@chromium.org>

> Cc: Benson Leung <bleung@chromium.org>

> Cc: Zhang Rui <rui.zhang@intel.com>

> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>

> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

> Cc: Stefan Wahren <wahrenst@gmx.net>

> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>

> Cc: Odelu Kukatla <okukatla@codeaurora.org>

> Cc: Alex Elder <elder@kernel.org>

> Cc: Suman Anna <s-anna@ti.com>

> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> Cc: linux-gpio@vger.kernel.org

> Cc: linux-pm@vger.kernel.org

> Cc: linux-can@vger.kernel.org

> Cc: netdev@vger.kernel.org

> Cc: linux-remoteproc@vger.kernel.org

> Cc: alsa-devel@alsa-project.org

> Cc: linux-usb@vger.kernel.org

> Signed-off-by: Rob Herring <robh@kernel.org>


Acked-by: Maxime Ripard <maxime@cerno.tech>


Thanks!
Maxiem
Kuninori Morimoto March 17, 2021, 10:41 p.m. | #5
Hi Rob

> Users of common properties shouldn't have a type definition as the
> common schemas already have one. Drop all the unnecessary type
> references in the tree.
> 
> A meta-schema update to catch these is pending.
> 
> Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Marc Kleine-Budde <mkl@pengutronix.de>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Cc: Ohad Ben-Cohen <ohad@wizery.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Cheng-Yi Chiang <cychiang@chromium.org>
> Cc: Benson Leung <bleung@chromium.org>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Stefan Wahren <wahrenst@gmx.net>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Cc: Odelu Kukatla <okukatla@codeaurora.org>
> Cc: Alex Elder <elder@kernel.org>
> Cc: Suman Anna <s-anna@ti.com>
> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-pm@vger.kernel.org
> Cc: linux-can@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: linux-remoteproc@vger.kernel.org
> Cc: alsa-devel@alsa-project.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---

For below

	Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

>  Documentation/devicetree/bindings/sound/ak4642.yaml          | 2 --
>  Documentation/devicetree/bindings/sound/renesas,rsnd.yaml    | 1 -

Thank you for your help !!

Best regards
---
Kuninori Morimoto
Nicolas Saenz Julienne March 18, 2021, 9:16 a.m. | #6
On Tue, 2021-03-16 at 13:48 -0600, Rob Herring wrote:
> Users of common properties shouldn't have a type definition as the

> common schemas already have one. Drop all the unnecessary type

> references in the tree.

> 

> A meta-schema update to catch these is pending.

> 

> Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>

> Cc: Maxime Ripard <mripard@kernel.org>

> Cc: Linus Walleij <linus.walleij@linaro.org>

> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>

> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>

> Cc: Krzysztof Kozlowski <krzk@kernel.org>

> Cc: Marc Kleine-Budde <mkl@pengutronix.de>

> Cc: "David S. Miller" <davem@davemloft.net>

> Cc: Jakub Kicinski <kuba@kernel.org>

> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> Cc: Ohad Ben-Cohen <ohad@wizery.com>

> Cc: Mark Brown <broonie@kernel.org>

> Cc: Cheng-Yi Chiang <cychiang@chromium.org>

> Cc: Benson Leung <bleung@chromium.org>

> Cc: Zhang Rui <rui.zhang@intel.com>

> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>

> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

> Cc: Stefan Wahren <wahrenst@gmx.net>

> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>

> Cc: Odelu Kukatla <okukatla@codeaurora.org>

> Cc: Alex Elder <elder@kernel.org>

> Cc: Suman Anna <s-anna@ti.com>

> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> Cc: linux-gpio@vger.kernel.org

> Cc: linux-pm@vger.kernel.org

> Cc: linux-can@vger.kernel.org

> Cc: netdev@vger.kernel.org

> Cc: linux-remoteproc@vger.kernel.org

> Cc: alsa-devel@alsa-project.org

> Cc: linux-usb@vger.kernel.org

> Signed-off-by: Rob Herring <robh@kernel.org>

> ---

>  .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml       | 5 +----


				^
				|

Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>


Regards,
Nicolas

Patch

diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
index a2c63c8b1d10..c6144c8421fa 100644
--- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
+++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
@@ -26,10 +26,7 @@  properties:
       - const: simple-mfd
 
   mboxes:
-    $ref: '/schemas/types.yaml#/definitions/phandle'
-    description: |
-      Phandle to the firmware device's Mailbox.
-      (See: ../mailbox/mailbox.txt for more information)
+    maxItems: 1
 
   clocks:
     type: object
diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
index 26b886b20b27..6be4a8852ee5 100644
--- a/Documentation/devicetree/bindings/arm/cpus.yaml
+++ b/Documentation/devicetree/bindings/arm/cpus.yaml
@@ -256,13 +256,11 @@  properties:
       where voltage is in V, frequency is in MHz.
 
   power-domains:
-    $ref: '/schemas/types.yaml#/definitions/phandle-array'
     description:
       List of phandles and PM domain specifiers, as defined by bindings of the
       PM domain provider (see also ../power_domain.txt).
 
   power-domain-names:
-    $ref: '/schemas/types.yaml#/definitions/string-array'
     description:
       A list of power domain name strings sorted in the same order as the
       power-domains property.
diff --git a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
index c13faf3e6581..3a7d5d731712 100644
--- a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
+++ b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
@@ -73,7 +73,6 @@  properties:
   clock-output-names:
     description:
       Name of the LCD pixel clock created.
-    $ref: /schemas/types.yaml#/definitions/string-array
     maxItems: 1
 
   dmas:
diff --git a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
index 1a54db04f29d..bcafa494ed7a 100644
--- a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
@@ -43,8 +43,7 @@  properties:
 
   gpio-ranges: true
 
-  gpio-ranges-group-names:
-    $ref: /schemas/types.yaml#/definitions/string-array
+  gpio-ranges-group-names: true
 
   socionext,interrupt-ranges:
     description: |
diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml
index 6f2398cdc82d..1e7894e524f9 100644
--- a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml
@@ -102,7 +102,6 @@  patternProperties:
 
       st,adc-channel-names:
         description: List of single-ended channel names.
-        $ref: /schemas/types.yaml#/definitions/string-array
 
       st,filter-order:
         description: |
diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
index 799e73cdb90b..13da7b29c707 100644
--- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
+++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
@@ -82,7 +82,6 @@  properties:
       this interconnect to send RPMh commands.
 
   qcom,bcm-voter-names:
-    $ref: /schemas/types.yaml#/definitions/string-array
     description: |
       Names for each of the qcom,bcm-voters specified.
 
diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra210-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra210-emc.yaml
index 49ab09252e52..bc8477e7ab19 100644
--- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra210-emc.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra210-emc.yaml
@@ -34,7 +34,7 @@  properties:
       - description: EMC general interrupt
 
   memory-region:
-    $ref: /schemas/types.yaml#/definitions/phandle
+    maxItems: 1
     description:
       phandle to a reserved memory region describing the table of EMC
       frequencies trained by the firmware
diff --git a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
index fe6a949a2eab..55bff1586b6f 100644
--- a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
+++ b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
@@ -57,7 +57,6 @@  properties:
       - const: per
 
   clock-frequency:
-    $ref: /schemas/types.yaml#/definitions/uint32
     description: |
       The oscillator frequency driving the flexcan device, filled in by the
       boot loader. This property should only be used the used operating system
diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
index 8f86084bf12e..4e8dee4aa90d 100644
--- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
@@ -100,7 +100,6 @@  properties:
       - description: Whether the IPA clock is enabled (if valid)
 
   qcom,smem-state-names:
-    $ref: /schemas/types.yaml#/definitions/string-array
     description: The names of the state bits used for SMP2P output
     items:
       - const: ipa-clock-enabled-valid
diff --git a/Documentation/devicetree/bindings/nvmem/nvmem-consumer.yaml b/Documentation/devicetree/bindings/nvmem/nvmem-consumer.yaml
index d5d7f113bade..828e4a1ece41 100644
--- a/Documentation/devicetree/bindings/nvmem/nvmem-consumer.yaml
+++ b/Documentation/devicetree/bindings/nvmem/nvmem-consumer.yaml
@@ -23,12 +23,10 @@  properties:
       List of phandle to the nvmem data cells.
 
   nvmem-names:
-    $ref: /schemas/types.yaml#/definitions/string-array
     description:
       Names for the each nvmem provider.
 
   nvmem-cell-names:
-    $ref: /schemas/types.yaml#/definitions/string-array
     description:
       Names for each nvmem-cells specified.
 
diff --git a/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml
index 1a1159097a2a..73400bc6e91d 100644
--- a/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml
@@ -93,7 +93,7 @@  properties:
 # The following are the optional properties:
 
   memory-region:
-    $ref: /schemas/types.yaml#/definitions/phandle
+    maxItems: 1
     description: |
       phandle to the reserved memory node to be associated
       with the remoteproc device. The reserved memory node
diff --git a/Documentation/devicetree/bindings/sound/ak4642.yaml b/Documentation/devicetree/bindings/sound/ak4642.yaml
index 6cd213be2266..1e2caa29790e 100644
--- a/Documentation/devicetree/bindings/sound/ak4642.yaml
+++ b/Documentation/devicetree/bindings/sound/ak4642.yaml
@@ -29,11 +29,9 @@  properties:
 
   clock-frequency:
     description: common clock binding; frequency of MCKO
-    $ref: /schemas/types.yaml#/definitions/uint32
 
   clock-output-names:
     description: common clock name
-    $ref: /schemas/types.yaml#/definitions/string
 
 required:
   - compatible
diff --git a/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml
index acfb9db021dc..77adbebed824 100644
--- a/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml
+++ b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml
@@ -32,7 +32,7 @@  properties:
           The last one integer is the length of the shared memory.
 
   memory-region:
-    $ref: '/schemas/types.yaml#/definitions/phandle'
+    maxItems: 1
     description: |
       Shared memory region to EC.  A "shared-dma-pool".
       See ../reserved-memory/reserved-memory.txt for details.
diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
index 2e1046513603..e494a0416748 100644
--- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
+++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
@@ -78,7 +78,6 @@  properties:
 
   clock-frequency:
     description: for audio_clkout0/1/2/3
-    $ref: /schemas/types.yaml#/definitions/uint32-array
 
   clkout-lr-asynchronous:
     description: audio_clkoutn is asynchronizes with lr-clock.
diff --git a/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml b/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml
index 95a728f4d333..3ea8c0c1f45f 100644
--- a/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml
+++ b/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml
@@ -59,7 +59,6 @@  patternProperties:
 
     properties:
       reg:
-        $ref: /schemas/types.yaml#/definitions/uint32
         description: Specify the sensor channel. There are 8 channels in PMIC5's ADC TM
         minimum: 0
         maximum: 7
diff --git a/Documentation/devicetree/bindings/usb/usb.yaml b/Documentation/devicetree/bindings/usb/usb.yaml
index 78491e66ed24..939f217b8c7b 100644
--- a/Documentation/devicetree/bindings/usb/usb.yaml
+++ b/Documentation/devicetree/bindings/usb/usb.yaml
@@ -16,7 +16,6 @@  properties:
     pattern: "^usb(@.*)?"
 
   phys:
-    $ref: /schemas/types.yaml#/definitions/phandle-array
     description:
       List of all the USB PHYs on this HCD