diff mbox series

[v6,06/17] media: uvcvideo: Do not check for V4L2_CTRL_WHICH_DEF_VAL

Message ID 20210317164511.39967-7-ribalda@chromium.org
State Superseded
Headers show
Series uvcvideo: Fix v4l2-compliance errors | expand

Commit Message

Ricardo Ribalda March 17, 2021, 4:45 p.m. UTC 
The framework already checks for us if V4L2_CTRL_WHICH_DEF_VAL is
written.

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
 drivers/media/usb/uvc/uvc_v4l2.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Hans Verkuil March 18, 2021, 7:16 a.m. UTC | #1 
On 17/03/2021 17:45, Ricardo Ribalda wrote:
> The framework already checks for us if V4L2_CTRL_WHICH_DEF_VAL is

> written.

> 

> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>


Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>


Thanks!

	Hans

> ---

>  drivers/media/usb/uvc/uvc_v4l2.c | 4 ----

>  1 file changed, 4 deletions(-)

> 

> diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v4l2.c

> index 252136cc885c..47b0e3224205 100644

> --- a/drivers/media/usb/uvc/uvc_v4l2.c

> +++ b/drivers/media/usb/uvc/uvc_v4l2.c

> @@ -1089,10 +1089,6 @@ static int uvc_ioctl_s_try_ext_ctrls(struct uvc_fh *handle,

>  	unsigned int i;

>  	int ret;

>  

> -	/* Default value cannot be changed */

> -	if (ctrls->which == V4L2_CTRL_WHICH_DEF_VAL)

> -		return -EINVAL;

> -

>  	ret = uvc_ctrl_begin(chain);

>  	if (ret < 0)

>  		return ret;

>
diff mbox series

Patch

diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v4l2.c
index 252136cc885c..47b0e3224205 100644
--- a/drivers/media/usb/uvc/uvc_v4l2.c
+++ b/drivers/media/usb/uvc/uvc_v4l2.c
@@ -1089,10 +1089,6 @@  static int uvc_ioctl_s_try_ext_ctrls(struct uvc_fh *handle,
 	unsigned int i;
 	int ret;
 
-	/* Default value cannot be changed */
-	if (ctrls->which == V4L2_CTRL_WHICH_DEF_VAL)
-		return -EINVAL;
-
 	ret = uvc_ctrl_begin(chain);
 	if (ret < 0)
 		return ret;