diff mbox series

qtnfmac: Fix possible buffer overflow in qtnf_event_handle_external_auth

Message ID 20210317121706.389058-1-leegib@gmail.com
State Superseded
Headers show
Series qtnfmac: Fix possible buffer overflow in qtnf_event_handle_external_auth | expand

Commit Message

Lee Gibson March 17, 2021, 12:17 p.m. UTC
Function qtnf_event_handle_external_auth calls memcpy without
checking the length.
A user could control that length and trigger a buffer overflow.
Fix by checking the length is within the maximum allowed size.

Signed-off-by: Lee Gibson <leegib@gmail.com>
---
 drivers/net/wireless/quantenna/qtnfmac/event.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Kalle Valo April 17, 2021, 5:24 p.m. UTC | #1
Lee Gibson <leegib@gmail.com> wrote:

> Function qtnf_event_handle_external_auth calls memcpy without

> checking the length.

> A user could control that length and trigger a buffer overflow.

> Fix by checking the length is within the maximum allowed size.

> 

> Signed-off-by: Lee Gibson <leegib@gmail.com>


Please use clamp_val() instead, that's preferred over min_t().

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210317121706.389058-1-leegib@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
diff mbox series

Patch

diff --git a/drivers/net/wireless/quantenna/qtnfmac/event.c b/drivers/net/wireless/quantenna/qtnfmac/event.c
index c775c177933b..ce920685055a 100644
--- a/drivers/net/wireless/quantenna/qtnfmac/event.c
+++ b/drivers/net/wireless/quantenna/qtnfmac/event.c
@@ -570,8 +570,10 @@  qtnf_event_handle_external_auth(struct qtnf_vif *vif,
 		return 0;
 
 	if (ev->ssid_len) {
-		memcpy(auth.ssid.ssid, ev->ssid, ev->ssid_len);
-		auth.ssid.ssid_len = ev->ssid_len;
+		int len = min_t(int, ev->ssid_len, IEEE80211_MAX_SSID_LEN);
+
+		memcpy(auth.ssid.ssid, ev->ssid, len);
+		auth.ssid.ssid_len = len;
 	}
 
 	auth.key_mgmt_suite = le32_to_cpu(ev->akm_suite);