thermal: core: Fix memory leak in the error path

Message ID
State New
Headers show
  • thermal: core: Fix memory leak in the error path
Related show

Commit Message

Daniel Lezcano March 19, 2021, 8:22 p.m.
Fix the following error:

 smatch warnings:
 drivers/thermal/thermal_core.c:1020 __thermal_cooling_device_register() warn: possible memory leak of 'cdev'

by freeing the cdev when exiting the function in the error path.

Fixes: 584837618100 ("thermal/drivers/core: Use a char pointer for the cooling device name")
Reported-by: kernel test robot <>
Reported-by: Dan Carpenter <>
Signed-off-by: Daniel Lezcano <>

 drivers/thermal/thermal_core.c | 1 +
 1 file changed, 1 insertion(+)



diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index c8d4010940ef..3566fd291399 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -1017,6 +1017,7 @@  __thermal_cooling_device_register(struct device_node *np,
 	ida_simple_remove(&thermal_cdev_ida, cdev->id);
+	kfree(cdev);
 	return ERR_PTR(ret);