[v1,08/14] linux-user/riscv: initialise the TaskState heap/stack info

Message ID 20210320133706.21475-9-alex.bennee@linaro.org
State Superseded
Headers show
Series
  • fixes for rc1 (kernel-doc, semihosting, testing)
Related show

Commit Message

Alex Bennée March 20, 2021, 1:37 p.m.
Arguably the target_cpu_copy_regs function for each architecture is
misnamed as a number of the architectures also take the opportunity to
fill out the TaskState structure. This could arguably be factored out
into common code but that would require a wider audit of the
architectures. For now just replicate for riscv so we can correctly
report semihosting information for SYS_HEAPINFO.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20210312102029.17017-5-alex.bennee@linaro.org>
---
 linux-user/riscv/cpu_loop.c | 5 +++++
 1 file changed, 5 insertions(+)

-- 
2.20.1

Comments

Richard Henderson March 20, 2021, 4:05 p.m. | #1
On 3/20/21 7:37 AM, Alex Bennée wrote:
> Arguably the target_cpu_copy_regs function for each architecture is

> misnamed as a number of the architectures also take the opportunity to

> fill out the TaskState structure. This could arguably be factored out

> into common code but that would require a wider audit of the

> architectures. For now just replicate for riscv so we can correctly

> report semihosting information for SYS_HEAPINFO.

> 

> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>

> Message-Id:<20210312102029.17017-5-alex.bennee@linaro.org>

> ---

>   linux-user/riscv/cpu_loop.c | 5 +++++

>   1 file changed, 5 insertions(+)


Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

Patch

diff --git a/linux-user/riscv/cpu_loop.c b/linux-user/riscv/cpu_loop.c
index 6767f941e8..74a9628dc9 100644
--- a/linux-user/riscv/cpu_loop.c
+++ b/linux-user/riscv/cpu_loop.c
@@ -135,4 +135,9 @@  void target_cpu_copy_regs(CPUArchState *env, struct target_pt_regs *regs)
         error_report("Incompatible ELF: RVE cpu requires RVE ABI binary");
         exit(EXIT_FAILURE);
     }
+
+    ts->stack_base = info->start_stack;
+    ts->heap_base = info->brk;
+    /* This will be filled in on the first SYS_HEAPINFO call.  */
+    ts->heap_limit = 0;
 }