| Message ID | 20210323131352.2461534-1-arseny.krasnov@kaspersky.com |
|---|---|
| State | New |
| Headers | show |
| Series | virtio/vsock: introduce SOCK_SEQPACKET support | expand |
On Tue, Mar 23, 2021 at 04:13:49PM +0300, Arseny Krasnov wrote: >This adds new virtio vsock specific feature bit which means >SOCK_SEQPACKET support. Guest negotiates this bit with vhost, >thus checking that vhost side supports SEQPACKET. > >Signed-off-by: Arseny Krasnov <arseny.krasnov@kaspersky.com> >--- > include/uapi/linux/virtio_vsock.h | 3 +++ > 1 file changed, 3 insertions(+) Since you have this patch, I think you can generalize the title, update the description, and merge here the changes I mentioned in patch 11/22 about changes of include/uapi/linux/virtio_vsock.h. So you can have a single patch with the new virtio-spec defines and structs related to SEQPACKET, of course then we move it before patch 11. What do you think? Stefano > >diff --git a/include/uapi/linux/virtio_vsock.h b/include/uapi/linux/virtio_vsock.h >index 692f8078cced..619aaebb355a 100644 >--- a/include/uapi/linux/virtio_vsock.h >+++ b/include/uapi/linux/virtio_vsock.h >@@ -38,6 +38,9 @@ > #include <linux/virtio_ids.h> > #include <linux/virtio_config.h> > >+/* The feature bitmap for virtio vsock */ >+#define VIRTIO_VSOCK_F_SEQPACKET 0 /* SOCK_SEQPACKET supported */ >+ > struct virtio_vsock_config { > __le64 guest_cid; > } __attribute__((packed)); >-- >2.25.1 >
On 25.03.2021 13:26, Stefano Garzarella wrote: > On Tue, Mar 23, 2021 at 04:13:49PM +0300, Arseny Krasnov wrote: >> This adds new virtio vsock specific feature bit which means >> SOCK_SEQPACKET support. Guest negotiates this bit with vhost, >> thus checking that vhost side supports SEQPACKET. >> >> Signed-off-by: Arseny Krasnov <arseny.krasnov@kaspersky.com> >> --- >> include/uapi/linux/virtio_vsock.h | 3 +++ >> 1 file changed, 3 insertions(+) > Since you have this patch, I think you can generalize the title, update > the description, and merge here the changes I mentioned in patch 11/22 > about changes of include/uapi/linux/virtio_vsock.h. > > So you can have a single patch with the new virtio-spec defines and > structs related to SEQPACKET, of course then we move it before patch 11. > > What do you think? Ok, i'll move all changes related to spec to separate patch > > Stefano > >> diff --git a/include/uapi/linux/virtio_vsock.h b/include/uapi/linux/virtio_vsock.h >> index 692f8078cced..619aaebb355a 100644 >> --- a/include/uapi/linux/virtio_vsock.h >> +++ b/include/uapi/linux/virtio_vsock.h >> @@ -38,6 +38,9 @@ >> #include <linux/virtio_ids.h> >> #include <linux/virtio_config.h> >> >> +/* The feature bitmap for virtio vsock */ >> +#define VIRTIO_VSOCK_F_SEQPACKET 0 /* SOCK_SEQPACKET supported */ >> + >> struct virtio_vsock_config { >> __le64 guest_cid; >> } __attribute__((packed)); >> -- >> 2.25.1 >> >
diff --git a/include/uapi/linux/virtio_vsock.h b/include/uapi/linux/virtio_vsock.h index 692f8078cced..619aaebb355a 100644 --- a/include/uapi/linux/virtio_vsock.h +++ b/include/uapi/linux/virtio_vsock.h @@ -38,6 +38,9 @@ #include <linux/virtio_ids.h> #include <linux/virtio_config.h> +/* The feature bitmap for virtio vsock */ +#define VIRTIO_VSOCK_F_SEQPACKET 0 /* SOCK_SEQPACKET supported */ + struct virtio_vsock_config { __le64 guest_cid; } __attribute__((packed));
This adds new virtio vsock specific feature bit which means SOCK_SEQPACKET support. Guest negotiates this bit with vhost, thus checking that vhost side supports SEQPACKET. Signed-off-by: Arseny Krasnov <arseny.krasnov@kaspersky.com> --- include/uapi/linux/virtio_vsock.h | 3 +++ 1 file changed, 3 insertions(+)