diff mbox series

[v2,mtd/fixes] mtd: spinand: core: add missing MODULE_DEVICE_TABLE()

Message ID 20210323173714.317884-1-alobakin@pm.me
State Superseded
Headers show
Series [v2,mtd/fixes] mtd: spinand: core: add missing MODULE_DEVICE_TABLE() | expand

Commit Message

Alexander Lobakin March 23, 2021, 5:37 p.m. UTC 
The module misses MODULE_DEVICE_TABLE() for both SPI and OF ID tables
and thus never autoloads on ID matches.
Add the missing declarations.
Present since day-0 of spinand framework introduction.

Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs")
Cc: stable@vger.kernel.org # 4.19+
Signed-off-by: Alexander Lobakin <alobakin@pm.me>
---
 drivers/mtd/nand/spi/core.c | 2 ++
 1 file changed, 2 insertions(+)

--
2.31.0

Comments

Miquel Raynal March 28, 2021, 5:14 p.m. UTC | #1 
On Tue, 2021-03-23 at 17:37:19 UTC, Alexander Lobakin wrote:
> The module misses MODULE_DEVICE_TABLE() for both SPI and OF ID tables

> and thus never autoloads on ID matches.

> Add the missing declarations.

> Present since day-0 of spinand framework introduction.

> 

> Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs")

> Cc: stable@vger.kernel.org # 4.19+

> Signed-off-by: Alexander Lobakin <alobakin@pm.me>


Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel
diff mbox series

Patch

diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
index 61d932c1b718..17f63f95f4a2 100644
--- a/drivers/mtd/nand/spi/core.c
+++ b/drivers/mtd/nand/spi/core.c
@@ -1263,12 +1263,14 @@  static const struct spi_device_id spinand_ids[] = {
 	{ .name = "spi-nand" },
 	{ /* sentinel */ },
 };
+MODULE_DEVICE_TABLE(spi, spinand_ids);

 #ifdef CONFIG_OF
 static const struct of_device_id spinand_of_ids[] = {
 	{ .compatible = "spi-nand" },
 	{ /* sentinel */ },
 };
+MODULE_DEVICE_TABLE(of, spinand_of_ids);
 #endif

 static struct spi_mem_driver spinand_drv = {