| Message ID | 20210324223713.1334666-1-frowand.list@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] of: unittest: rename overlay source files from .dts to .dtso | expand |
On Wed, Mar 24, 2021 at 05:37:13PM -0500, frowand.list@gmail.com wrote: > From: Frank Rowand <frank.rowand@sony.com> > > Add Makefile rule to build .dtbo.o assembly file from overlay .dtso > source file. > > Rename unittest .dts overlay source files to use .dtso suffix. I'm pretty lukewarm on .dtso... > > Update Makefile to build .dtbo.o objects instead of .dtb.o from > unittest overlay source files. > > Modify unitest.c to use .dtbo.o based symbols instead of .dtb.o > > Modify Makefile.lib %.dtbo rule to depend upon %.dtso instead of %.dts > > Documentation/devicetree/of_unittest.rst was already out of date. > This commit would make it even more out of date. Delete the document > instead of continuing the maintenance burden of keeping the document > in sync with the source. This should be a separate change. It's also going to collide with my doc improvements. Improvements here would be better than just deleting.
On 3/27/21 12:40 PM, Rob Herring wrote: > On Wed, Mar 24, 2021 at 05:37:13PM -0500, frowand.list@gmail.com wrote: >> From: Frank Rowand <frank.rowand@sony.com> >> >> Add Makefile rule to build .dtbo.o assembly file from overlay .dtso >> source file. >> >> Rename unittest .dts overlay source files to use .dtso suffix. > > I'm pretty lukewarm on .dtso... I was originally also, but I'm warming up to it. > >> >> Update Makefile to build .dtbo.o objects instead of .dtb.o from >> unittest overlay source files. >> >> Modify unitest.c to use .dtbo.o based symbols instead of .dtb.o >> >> Modify Makefile.lib %.dtbo rule to depend upon %.dtso instead of %.dts >> >> Documentation/devicetree/of_unittest.rst was already out of date. >> This commit would make it even more out of date. Delete the document >> instead of continuing the maintenance burden of keeping the document >> in sync with the source. > > This should be a separate change. It's also going to collide with my doc > improvements. I'll split it out. > > Improvements here would be better than just deleting. OK, I'll make the document more abstract so that code changes will be less likely to require document changes. -Frank
Hi Frank, Rob, On Mon, Mar 29, 2021 at 9:23 PM Frank Rowand <frowand.list@gmail.com> wrote: > On 3/27/21 12:40 PM, Rob Herring wrote: > > On Wed, Mar 24, 2021 at 05:37:13PM -0500, frowand.list@gmail.com wrote: > >> From: Frank Rowand <frank.rowand@sony.com> > >> > >> Add Makefile rule to build .dtbo.o assembly file from overlay .dtso > >> source file. > >> > >> Rename unittest .dts overlay source files to use .dtso suffix. > > > > I'm pretty lukewarm on .dtso... > > I was originally also, but I'm warming up to it. What's the status of this? v5.12 (introducing the concept of dtbo) is around the corner, and it would be best to decide on dts or dtso before its release. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 4/22/21 3:44 AM, Geert Uytterhoeven wrote: > Hi Frank, Rob, > > On Mon, Mar 29, 2021 at 9:23 PM Frank Rowand <frowand.list@gmail.com> wrote: >> On 3/27/21 12:40 PM, Rob Herring wrote: >>> On Wed, Mar 24, 2021 at 05:37:13PM -0500, frowand.list@gmail.com wrote: >>>> From: Frank Rowand <frank.rowand@sony.com> >>>> >>>> Add Makefile rule to build .dtbo.o assembly file from overlay .dtso >>>> source file. >>>> >>>> Rename unittest .dts overlay source files to use .dtso suffix. >>> >>> I'm pretty lukewarm on .dtso... >> >> I was originally also, but I'm warming up to it. > > What's the status of this? I was planning to resend on top of the upcoming -rc1. > v5.12 (introducing the concept of dtbo) is around the corner, and it > would be best to decide on dts or dtso before its release. > > Thanks! > > Gr{oetje,eeting}s, > > Geert >
On 22-04-21, 13:54, Frank Rowand wrote: > On 4/22/21 3:44 AM, Geert Uytterhoeven wrote: > > Hi Frank, Rob, > > > > On Mon, Mar 29, 2021 at 9:23 PM Frank Rowand <frowand.list@gmail.com> wrote: > >> On 3/27/21 12:40 PM, Rob Herring wrote: > >>> On Wed, Mar 24, 2021 at 05:37:13PM -0500, frowand.list@gmail.com wrote: > >>>> From: Frank Rowand <frank.rowand@sony.com> > >>>> > >>>> Add Makefile rule to build .dtbo.o assembly file from overlay .dtso > >>>> source file. > >>>> > >>>> Rename unittest .dts overlay source files to use .dtso suffix. > >>> > >>> I'm pretty lukewarm on .dtso... > >> > >> I was originally also, but I'm warming up to it. > > > > What's the status of this? > > I was planning to resend on top of the upcoming -rc1. Ping. -- viresh
On 5/26/21 1:11 AM, Viresh Kumar wrote: > On 22-04-21, 13:54, Frank Rowand wrote: >> On 4/22/21 3:44 AM, Geert Uytterhoeven wrote: >>> Hi Frank, Rob, >>> >>> On Mon, Mar 29, 2021 at 9:23 PM Frank Rowand <frowand.list@gmail.com> wrote: >>>> On 3/27/21 12:40 PM, Rob Herring wrote: >>>>> On Wed, Mar 24, 2021 at 05:37:13PM -0500, frowand.list@gmail.com wrote: >>>>>> From: Frank Rowand <frank.rowand@sony.com> >>>>>> >>>>>> Add Makefile rule to build .dtbo.o assembly file from overlay .dtso >>>>>> source file. >>>>>> >>>>>> Rename unittest .dts overlay source files to use .dtso suffix. >>>>> >>>>> I'm pretty lukewarm on .dtso... >>>> >>>> I was originally also, but I'm warming up to it. >>> >>> What's the status of this? >> >> I was planning to resend on top of the upcoming -rc1. > > Ping. > Thanks for the prod... The .dtso convention was added to the dtc compiler, then a patch was accepted to revert one mention of .dtso ,though there still remains two location where .dtbo is still recognized (guess_type_by_name() in dtc and the help text of the fdtoverlay program). It seems that the general .dtso and .dtbo were not popular, so I'm going to drop this patch instead of continuing to try to get it accepted. -Frank
On Wed, May 26, 2021 at 04:21:48PM -0500, Frank Rowand wrote: > On 5/26/21 1:11 AM, Viresh Kumar wrote: > > On 22-04-21, 13:54, Frank Rowand wrote: > >> On 4/22/21 3:44 AM, Geert Uytterhoeven wrote: > >>> Hi Frank, Rob, > >>> > >>> On Mon, Mar 29, 2021 at 9:23 PM Frank Rowand <frowand.list@gmail.com> wrote: > >>>> On 3/27/21 12:40 PM, Rob Herring wrote: > >>>>> On Wed, Mar 24, 2021 at 05:37:13PM -0500, frowand.list@gmail.com wrote: > >>>>>> From: Frank Rowand <frank.rowand@sony.com> > >>>>>> > >>>>>> Add Makefile rule to build .dtbo.o assembly file from overlay .dtso > >>>>>> source file. > >>>>>> > >>>>>> Rename unittest .dts overlay source files to use .dtso suffix. > >>>>> > >>>>> I'm pretty lukewarm on .dtso... > >>>> > >>>> I was originally also, but I'm warming up to it. > >>> > >>> What's the status of this? > >> > >> I was planning to resend on top of the upcoming -rc1. > > > > Ping. > > > > Thanks for the prod... > > The .dtso convention was added to the dtc compiler, then a patch was > accepted to revert one mention of .dtso ,though there still remains > two location where .dtbo is still recognized (guess_type_by_name() in > dtc and the help text of the fdtoverlay program). > > It seems that the general .dtso and .dtbo were not popular, so I'm > going to drop this patch instead of continuing to try to get it > accepted. AFAICT .dtbo is moderately well established, and I think it's a good convention, since it matters whether a blob is an overlay or base tree, and it's not trivial to tell which is which. .dtso is much more recent, and I think there's much less value to it. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
On Thu, May 27, 2021 at 3:48 AM David Gibson <david@gibson.dropbear.id.au> wrote: > On Wed, May 26, 2021 at 04:21:48PM -0500, Frank Rowand wrote: > > On 5/26/21 1:11 AM, Viresh Kumar wrote: > > > On 22-04-21, 13:54, Frank Rowand wrote: > > >> On 4/22/21 3:44 AM, Geert Uytterhoeven wrote: > > >>> On Mon, Mar 29, 2021 at 9:23 PM Frank Rowand <frowand.list@gmail.com> wrote: > > >>>> On 3/27/21 12:40 PM, Rob Herring wrote: > > >>>>> On Wed, Mar 24, 2021 at 05:37:13PM -0500, frowand.list@gmail.com wrote: > > >>>>>> From: Frank Rowand <frank.rowand@sony.com> > > >>>>>> > > >>>>>> Add Makefile rule to build .dtbo.o assembly file from overlay .dtso > > >>>>>> source file. > > >>>>>> > > >>>>>> Rename unittest .dts overlay source files to use .dtso suffix. > > >>>>> > > >>>>> I'm pretty lukewarm on .dtso... > > >>>> > > >>>> I was originally also, but I'm warming up to it. > > >>> > > >>> What's the status of this? > > >> > > >> I was planning to resend on top of the upcoming -rc1. > > > > > > Ping. > > > > > > > Thanks for the prod... > > > > The .dtso convention was added to the dtc compiler, then a patch was > > accepted to revert one mention of .dtso ,though there still remains > > two location where .dtbo is still recognized (guess_type_by_name() in > > dtc and the help text of the fdtoverlay program). > > > > It seems that the general .dtso and .dtbo were not popular, so I'm > > going to drop this patch instead of continuing to try to get it > > accepted. > > AFAICT .dtbo is moderately well established, and I think it's a good > convention, since it matters whether a blob is an overlay or base > tree, and it's not trivial to tell which is which. Indeed. > .dtso is much more recent, Is it? The oldest reference I could find is from May 2015: "[PATCH/RFC] kbuild: Create a rule for building device tree overlay objects" https://lore.kernel.org/linux-devicetree/1431431816-24612-1-git-send-email-geert+renesas@glider.be/ I have always used dtbo/dtso in my published overlays branches, referred from https://elinux.org/R-Car/DT-Overlays, and used by various people. > and I think there's much less value to it. IMHO the same reasoning as for dtb vs. dtbo applies to dts vs. dtso. It matters if the resulting blob will be an overlay or base tree, as the blob will have to be called .dtb or .dtbo. As dtc outputs to stdout by default, the caller has to provide the output filename, and thus needs to know. Even if dtc would name the output file based on the presence of "/plugin/" in the input file, the build system still needs to know for dependency tracking. We also do have .dts vs. .dtsi. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 5/26/21 8:22 PM, David Gibson wrote: > On Wed, May 26, 2021 at 04:21:48PM -0500, Frank Rowand wrote: >> On 5/26/21 1:11 AM, Viresh Kumar wrote: >>> On 22-04-21, 13:54, Frank Rowand wrote: >>>> On 4/22/21 3:44 AM, Geert Uytterhoeven wrote: >>>>> Hi Frank, Rob, >>>>> >>>>> On Mon, Mar 29, 2021 at 9:23 PM Frank Rowand <frowand.list@gmail.com> wrote: >>>>>> On 3/27/21 12:40 PM, Rob Herring wrote: >>>>>>> On Wed, Mar 24, 2021 at 05:37:13PM -0500, frowand.list@gmail.com wrote: >>>>>>>> From: Frank Rowand <frank.rowand@sony.com> >>>>>>>> >>>>>>>> Add Makefile rule to build .dtbo.o assembly file from overlay .dtso >>>>>>>> source file. >>>>>>>> >>>>>>>> Rename unittest .dts overlay source files to use .dtso suffix. >>>>>>> >>>>>>> I'm pretty lukewarm on .dtso... >>>>>> >>>>>> I was originally also, but I'm warming up to it. >>>>> >>>>> What's the status of this? >>>> >>>> I was planning to resend on top of the upcoming -rc1. >>> >>> Ping. >>> >> >> Thanks for the prod... >> >> The .dtso convention was added to the dtc compiler, then a patch was >> accepted to revert one mention of .dtso ,though there still remains >> two location where .dtbo is still recognized (guess_type_by_name() in >> dtc and the help text of the fdtoverlay program). >> >> It seems that the general .dtso and .dtbo were not popular, so I'm >> going to drop this patch instead of continuing to try to get it >> accepted. > > AFAICT .dtbo is moderately well established, and I think it's a good > convention, since it matters whether a blob is an overlay or base > tree, and it's not trivial to tell which is which. > > .dtso is much more recent, and I think there's much less value to it. > Thanks for the correction, I misunderstood your thoughts. -Frank
On Thu, May 27, 2021 at 09:21:05AM +0200, Geert Uytterhoeven wrote: 65;6401;1c> On Thu, May 27, 2021 at 3:48 AM David Gibson > <david@gibson.dropbear.id.au> wrote: > > On Wed, May 26, 2021 at 04:21:48PM -0500, Frank Rowand wrote: > > > On 5/26/21 1:11 AM, Viresh Kumar wrote: > > > > On 22-04-21, 13:54, Frank Rowand wrote: > > > >> On 4/22/21 3:44 AM, Geert Uytterhoeven wrote: > > > >>> On Mon, Mar 29, 2021 at 9:23 PM Frank Rowand <frowand.list@gmail.com> wrote: > > > >>>> On 3/27/21 12:40 PM, Rob Herring wrote: > > > >>>>> On Wed, Mar 24, 2021 at 05:37:13PM -0500, frowand.list@gmail.com wrote: > > > >>>>>> From: Frank Rowand <frank.rowand@sony.com> > > > >>>>>> > > > >>>>>> Add Makefile rule to build .dtbo.o assembly file from overlay .dtso > > > >>>>>> source file. > > > >>>>>> > > > >>>>>> Rename unittest .dts overlay source files to use .dtso suffix. > > > >>>>> > > > >>>>> I'm pretty lukewarm on .dtso... > > > >>>> > > > >>>> I was originally also, but I'm warming up to it. > > > >>> > > > >>> What's the status of this? > > > >> > > > >> I was planning to resend on top of the upcoming -rc1. > > > > > > > > Ping. > > > > > > > > > > Thanks for the prod... > > > > > > The .dtso convention was added to the dtc compiler, then a patch was > > > accepted to revert one mention of .dtso ,though there still remains > > > two location where .dtbo is still recognized (guess_type_by_name() in > > > dtc and the help text of the fdtoverlay program). > > > > > > It seems that the general .dtso and .dtbo were not popular, so I'm > > > going to drop this patch instead of continuing to try to get it > > > accepted. > > > > AFAICT .dtbo is moderately well established, and I think it's a good > > convention, since it matters whether a blob is an overlay or base > > tree, and it's not trivial to tell which is which. > > Indeed. > > > .dtso is much more recent, > > Is it? Well, I wouldn't bet money on it, I just seem to remember encountering .dtbo for some time before .dtso was mentioned. > The oldest reference I could find is from May 2015: > "[PATCH/RFC] kbuild: Create a rule for building device tree overlay objects" > https://lore.kernel.org/linux-devicetree/1431431816-24612-1-git-send-email-geert+renesas@glider.be/ Hm, I think .dtbo is even older than that, but again, I wouldn't swear to it. > I have always used dtbo/dtso in my published overlays branches, > referred from https://elinux.org/R-Car/DT-Overlays, and used by > various people. > > > and I think there's much less value to it. > > IMHO the same reasoning as for dtb vs. dtbo applies to dts vs. dtso. > It matters if the resulting blob will be an overlay or base tree, > as the blob will have to be called .dtb or .dtbo. > As dtc outputs to stdout by default, the caller has to provide the > output filename, and thus needs to know. > Even if dtc would name the output file based on the presence of > "/plugin/" in the input file, the build system still needs to know > for dependency tracking. Hm, fair point. I was thinking of the the /plugin/ tag as the distinction, whereas dtb is binary and the distinction isn't even marked in the header. But you're right that even readable text labels inside the file don't really help make(1). So, I retract that assertion. > We also do have .dts vs. .dtsi. > > Gr{oetje,eeting}s, > > Geert > -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
Hi David, On Sat, May 29, 2021 at 7:16 AM David Gibson <david@gibson.dropbear.id.au> wrote: > On Thu, May 27, 2021 at 09:21:05AM +0200, Geert Uytterhoeven wrote: > 65;6401;1c> On Thu, May 27, 2021 at 3:48 AM David Gibson > > <david@gibson.dropbear.id.au> wrote: > > > On Wed, May 26, 2021 at 04:21:48PM -0500, Frank Rowand wrote: > > > > On 5/26/21 1:11 AM, Viresh Kumar wrote: > > > > > On 22-04-21, 13:54, Frank Rowand wrote: > > > > >> On 4/22/21 3:44 AM, Geert Uytterhoeven wrote: > > > > >>> On Mon, Mar 29, 2021 at 9:23 PM Frank Rowand <frowand.list@gmail.com> wrote: > > > > >>>> On 3/27/21 12:40 PM, Rob Herring wrote: > > > > >>>>> On Wed, Mar 24, 2021 at 05:37:13PM -0500, frowand.list@gmail.com wrote: > > > > >>>>>> From: Frank Rowand <frank.rowand@sony.com> > > > > >>>>>> > > > > >>>>>> Add Makefile rule to build .dtbo.o assembly file from overlay .dtso > > > > >>>>>> source file. > > > > >>>>>> > > > > >>>>>> Rename unittest .dts overlay source files to use .dtso suffix. > > > > >>>>> > > > > >>>>> I'm pretty lukewarm on .dtso... > > > > >>>> > > > > >>>> I was originally also, but I'm warming up to it. > > > > >>> > > > > >>> What's the status of this? > > > > >> > > > > >> I was planning to resend on top of the upcoming -rc1. > > > > > > > > > > Ping. > > > > > > > > > > > > > Thanks for the prod... > > > > > > > > The .dtso convention was added to the dtc compiler, then a patch was > > > > accepted to revert one mention of .dtso ,though there still remains > > > > two location where .dtbo is still recognized (guess_type_by_name() in > > > > dtc and the help text of the fdtoverlay program). > > > > > > > > It seems that the general .dtso and .dtbo were not popular, so I'm > > > > going to drop this patch instead of continuing to try to get it > > > > accepted. > > > > > > AFAICT .dtbo is moderately well established, and I think it's a good > > > convention, since it matters whether a blob is an overlay or base > > > tree, and it's not trivial to tell which is which. > > > > Indeed. > > > > > .dtso is much more recent, > > > > Is it? > > Well, I wouldn't bet money on it, I just seem to remember encountering > .dtbo for some time before .dtso was mentioned. > > > The oldest reference I could find is from May 2015: > > "[PATCH/RFC] kbuild: Create a rule for building device tree overlay objects" > > https://lore.kernel.org/linux-devicetree/1431431816-24612-1-git-send-email-geert+renesas@glider.be/ > > Hm, I think .dtbo is even older than that, but again, I wouldn't swear > to it. Sure. My work is based on Pantelis' work for BeagleBoard capes. His code (from 2013?) used .dtbo and .dts: overlay/v3.10/merge:firmware/Makefile:$(obj)/%.dtbo: $(obj)/%.dts | $(objtree)/$(obj)/$$(dir %) So I might be the one who introduced .dtso... > > I have always used dtbo/dtso in my published overlays branches, > > referred from https://elinux.org/R-Car/DT-Overlays, and used by > > various people. > > > > > and I think there's much less value to it. > > > > IMHO the same reasoning as for dtb vs. dtbo applies to dts vs. dtso. > > It matters if the resulting blob will be an overlay or base tree, > > as the blob will have to be called .dtb or .dtbo. > > As dtc outputs to stdout by default, the caller has to provide the > > output filename, and thus needs to know. > > Even if dtc would name the output file based on the presence of > > "/plugin/" in the input file, the build system still needs to know > > for dependency tracking. > > Hm, fair point. I was thinking of the the /plugin/ tag as the > distinction, whereas dtb is binary and the distinction isn't even > marked in the header. But you're right that even readable text labels > inside the file don't really help make(1). So, I retract that > assertion. Thanks! > > We also do have .dts vs. .dtsi. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Sat, May 29, 2021 at 12:16 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Sat, May 29, 2021 at 7:16 AM David Gibson > <david@gibson.dropbear.id.au> wrote: > > On Thu, May 27, 2021 at 09:21:05AM +0200, Geert Uytterhoeven wrote: > > 65;6401;1c> On Thu, May 27, 2021 at 3:48 AM David Gibson > > > <david@gibson.dropbear.id.au> wrote: > > > > On Wed, May 26, 2021 at 04:21:48PM -0500, Frank Rowand wrote: > > > > > On 5/26/21 1:11 AM, Viresh Kumar wrote: > > > > > > On 22-04-21, 13:54, Frank Rowand wrote: > > > > > >> On 4/22/21 3:44 AM, Geert Uytterhoeven wrote: > > > > > >>> On Mon, Mar 29, 2021 at 9:23 PM Frank Rowand <frowand.list@gmail.com> wrote: > > > > > >>>> On 3/27/21 12:40 PM, Rob Herring wrote: > > > > > >>>>> On Wed, Mar 24, 2021 at 05:37:13PM -0500, frowand.list@gmail.com wrote: > > > > > >>>>>> From: Frank Rowand <frank.rowand@sony.com> > > > > > >>>>>> > > > > > >>>>>> Add Makefile rule to build .dtbo.o assembly file from overlay .dtso > > > > > >>>>>> source file. > > > > > >>>>>> > > > > > >>>>>> Rename unittest .dts overlay source files to use .dtso suffix. > > > > > >>>>> > > > > > >>>>> I'm pretty lukewarm on .dtso... > > > > > >>>> > > > > > >>>> I was originally also, but I'm warming up to it. > > > > > >>> > > > > > >>> What's the status of this? > > > > > >> > > > > > >> I was planning to resend on top of the upcoming -rc1. > > > > > > > > > > > > Ping. > > > > > > > > > > > > > > > > Thanks for the prod... > > > > > > > > > > The .dtso convention was added to the dtc compiler, then a patch was > > > > > accepted to revert one mention of .dtso ,though there still remains > > > > > two location where .dtbo is still recognized (guess_type_by_name() in > > > > > dtc and the help text of the fdtoverlay program). > > > > > > > > > > It seems that the general .dtso and .dtbo were not popular, so I'm > > > > > going to drop this patch instead of continuing to try to get it > > > > > accepted. > > > > > > > > AFAICT .dtbo is moderately well established, and I think it's a good > > > > convention, since it matters whether a blob is an overlay or base > > > > tree, and it's not trivial to tell which is which. > > > > > > Indeed. > > > > > > > .dtso is much more recent, > > > > > > Is it? > > > > Well, I wouldn't bet money on it, I just seem to remember encountering > > .dtbo for some time before .dtso was mentioned. > > > > > The oldest reference I could find is from May 2015: > > > "[PATCH/RFC] kbuild: Create a rule for building device tree overlay objects" > > > https://lore.kernel.org/linux-devicetree/1431431816-24612-1-git-send-email-geert+renesas@glider.be/ > > > > Hm, I think .dtbo is even older than that, but again, I wouldn't swear > > to it. > > Sure. My work is based on Pantelis' work for BeagleBoard capes. > His code (from 2013?) used .dtbo and .dts: > > overlay/v3.10/merge:firmware/Makefile:$(obj)/%.dtbo: $(obj)/%.dts > | $(objtree)/$(obj)/$$(dir %) > > So I might be the one who introduced .dtso... > > > > I have always used dtbo/dtso in my published overlays branches, > > > referred from https://elinux.org/R-Car/DT-Overlays, and used by > > > various people. > > > > > > > and I think there's much less value to it. > > > > > > IMHO the same reasoning as for dtb vs. dtbo applies to dts vs. dtso. > > > It matters if the resulting blob will be an overlay or base tree, > > > as the blob will have to be called .dtb or .dtbo. > > > As dtc outputs to stdout by default, the caller has to provide the > > > output filename, and thus needs to know. > > > Even if dtc would name the output file based on the presence of > > > "/plugin/" in the input file, the build system still needs to know > > > for dependency tracking. > > > > Hm, fair point. I was thinking of the the /plugin/ tag as the > > distinction, whereas dtb is binary and the distinction isn't even > > marked in the header. But you're right that even readable text labels > > inside the file don't really help make(1). So, I retract that > > assertion. > > Thanks! > > > > We also do have .dts vs. .dtsi. In the mean time, we're at rc7 again? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Tue, Jun 22, 2021 at 11:44 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Sat, May 29, 2021 at 12:16 PM Geert Uytterhoeven > <geert@linux-m68k.org> wrote: > > On Sat, May 29, 2021 at 7:16 AM David Gibson > > <david@gibson.dropbear.id.au> wrote: > > > On Thu, May 27, 2021 at 09:21:05AM +0200, Geert Uytterhoeven wrote: > > > 65;6401;1c> On Thu, May 27, 2021 at 3:48 AM David Gibson > > > > <david@gibson.dropbear.id.au> wrote: > > > > > On Wed, May 26, 2021 at 04:21:48PM -0500, Frank Rowand wrote: > > > > > > On 5/26/21 1:11 AM, Viresh Kumar wrote: > > > > > > > On 22-04-21, 13:54, Frank Rowand wrote: > > > > > > >> On 4/22/21 3:44 AM, Geert Uytterhoeven wrote: > > > > > > >>> On Mon, Mar 29, 2021 at 9:23 PM Frank Rowand <frowand.list@gmail.com> wrote: > > > > > > >>>> On 3/27/21 12:40 PM, Rob Herring wrote: > > > > > > >>>>> On Wed, Mar 24, 2021 at 05:37:13PM -0500, frowand.list@gmail.com wrote: > > > > > > >>>>>> From: Frank Rowand <frank.rowand@sony.com> > > > > > > >>>>>> > > > > > > >>>>>> Add Makefile rule to build .dtbo.o assembly file from overlay .dtso > > > > > > >>>>>> source file. > > > > > > >>>>>> > > > > > > >>>>>> Rename unittest .dts overlay source files to use .dtso suffix. > > > > > > >>>>> > > > > > > >>>>> I'm pretty lukewarm on .dtso... > > > > > > >>>> > > > > > > >>>> I was originally also, but I'm warming up to it. > > > > > > >>> > > > > > > >>> What's the status of this? > > > > > > >> > > > > > > >> I was planning to resend on top of the upcoming -rc1. > > > > > > > > > > > > > > Ping. > > > > > > > > > > > > > > > > > > > Thanks for the prod... > > > > > > > > > > > > The .dtso convention was added to the dtc compiler, then a patch was > > > > > > accepted to revert one mention of .dtso ,though there still remains > > > > > > two location where .dtbo is still recognized (guess_type_by_name() in > > > > > > dtc and the help text of the fdtoverlay program). > > > > > > > > > > > > It seems that the general .dtso and .dtbo were not popular, so I'm > > > > > > going to drop this patch instead of continuing to try to get it > > > > > > accepted. > > > > > > > > > > AFAICT .dtbo is moderately well established, and I think it's a good > > > > > convention, since it matters whether a blob is an overlay or base > > > > > tree, and it's not trivial to tell which is which. > > > > > > > > Indeed. > > > > > > > > > .dtso is much more recent, > > > > > > > > Is it? > > > > > > Well, I wouldn't bet money on it, I just seem to remember encountering > > > .dtbo for some time before .dtso was mentioned. > > > > > > > The oldest reference I could find is from May 2015: > > > > "[PATCH/RFC] kbuild: Create a rule for building device tree overlay objects" > > > > https://lore.kernel.org/linux-devicetree/1431431816-24612-1-git-send-email-geert+renesas@glider.be/ > > > > > > Hm, I think .dtbo is even older than that, but again, I wouldn't swear > > > to it. > > > > Sure. My work is based on Pantelis' work for BeagleBoard capes. > > His code (from 2013?) used .dtbo and .dts: > > > > overlay/v3.10/merge:firmware/Makefile:$(obj)/%.dtbo: $(obj)/%.dts > > | $(objtree)/$(obj)/$$(dir %) > > > > So I might be the one who introduced .dtso... > > > > > > I have always used dtbo/dtso in my published overlays branches, > > > > referred from https://elinux.org/R-Car/DT-Overlays, and used by > > > > various people. > > > > > > > > > and I think there's much less value to it. > > > > > > > > IMHO the same reasoning as for dtb vs. dtbo applies to dts vs. dtso. > > > > It matters if the resulting blob will be an overlay or base tree, > > > > as the blob will have to be called .dtb or .dtbo. > > > > As dtc outputs to stdout by default, the caller has to provide the > > > > output filename, and thus needs to know. > > > > Even if dtc would name the output file based on the presence of > > > > "/plugin/" in the input file, the build system still needs to know > > > > for dependency tracking. > > > > > > Hm, fair point. I was thinking of the the /plugin/ tag as the > > > distinction, whereas dtb is binary and the distinction isn't even > > > marked in the header. But you're right that even readable text labels > > > inside the file don't really help make(1). So, I retract that > > > assertion. > > > > Thanks! > > > > > > We also do have .dts vs. .dtsi. > > In the mean time, we're at rc7 again? That was v5.13-rc7. Now we're at v5.14-rc7... Will we live with the inability to e.g. let make distinguish between DT includes and overlays forever? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Thu, Jan 6, 2022 at 11:23 AM Frank Rowand <frowand.list@gmail.com> wrote: > > Hi Rob, David, > > Patient Geert has pinged again. If it's not a patch to be reviewed, then I'm not going to see it most likely. I don't read the DT list regularly... > If I remember correctly you guys were not thrilled with this idea, but > also did not seem strongly against it. Are you willing to go along > with .dtso for overlay source files? If so, I will revive this patch > series. > > David, if you are against supporting .dtso in the dtc compiler then > the kernel can still support it through make rules. I'm not really interested in diverging from dtc. I'd suggest moving the discussion to dtc list and/or devicetree-spec if you want to get more attention on this. Also, keep in mind that extensions also affect MIME types which someone was also asking about recently. Rob > > -Frank > > > On 1/6/22 3:00 AM, Geert Uytterhoeven wrote: > > On Tue, Aug 24, 2021 at 11:20 AM Geert Uytterhoeven > > <geert@linux-m68k.org> wrote: > >> On Tue, Jun 22, 2021 at 11:44 AM Geert Uytterhoeven > >> <geert@linux-m68k.org> wrote: > >>> On Sat, May 29, 2021 at 12:16 PM Geert Uytterhoeven > >>> <geert@linux-m68k.org> wrote: > >>>> On Sat, May 29, 2021 at 7:16 AM David Gibson > >>>> <david@gibson.dropbear.id.au> wrote: > >>>>> On Thu, May 27, 2021 at 09:21:05AM +0200, Geert Uytterhoeven wrote: > >>>>> 65;6401;1c> On Thu, May 27, 2021 at 3:48 AM David Gibson > >>>>>> <david@gibson.dropbear.id.au> wrote: > >>>>>>> On Wed, May 26, 2021 at 04:21:48PM -0500, Frank Rowand wrote: > >>>>>>>> On 5/26/21 1:11 AM, Viresh Kumar wrote: > >>>>>>>>> On 22-04-21, 13:54, Frank Rowand wrote: > >>>>>>>>>> On 4/22/21 3:44 AM, Geert Uytterhoeven wrote: > >>>>>>>>>>> On Mon, Mar 29, 2021 at 9:23 PM Frank Rowand <frowand.list@gmail.com> wrote: > >>>>>>>>>>>> On 3/27/21 12:40 PM, Rob Herring wrote: > >>>>>>>>>>>>> On Wed, Mar 24, 2021 at 05:37:13PM -0500, frowand.list@gmail.com wrote: > >>>>>>>>>>>>>> From: Frank Rowand <frank.rowand@sony.com> > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> Add Makefile rule to build .dtbo.o assembly file from overlay .dtso > >>>>>>>>>>>>>> source file. > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> Rename unittest .dts overlay source files to use .dtso suffix. > >>>>>>>>>>>>> > >>>>>>>>>>>>> I'm pretty lukewarm on .dtso... > >>>>>>>>>>>> > >>>>>>>>>>>> I was originally also, but I'm warming up to it. > >>>>>>>>>>> > >>>>>>>>>>> What's the status of this? > >>>>>>>>>> > >>>>>>>>>> I was planning to resend on top of the upcoming -rc1. > >>>>>>>>> > >>>>>>>>> Ping. > >>>>>>>>> > >>>>>>>> > >>>>>>>> Thanks for the prod... > >>>>>>>> > >>>>>>>> The .dtso convention was added to the dtc compiler, then a patch was > >>>>>>>> accepted to revert one mention of .dtso ,though there still remains > >>>>>>>> two location where .dtbo is still recognized (guess_type_by_name() in > >>>>>>>> dtc and the help text of the fdtoverlay program). > >>>>>>>> > >>>>>>>> It seems that the general .dtso and .dtbo were not popular, so I'm > >>>>>>>> going to drop this patch instead of continuing to try to get it > >>>>>>>> accepted. > >>>>>>> > >>>>>>> AFAICT .dtbo is moderately well established, and I think it's a good > >>>>>>> convention, since it matters whether a blob is an overlay or base > >>>>>>> tree, and it's not trivial to tell which is which. > >>>>>> > >>>>>> Indeed. > >>>>>> > >>>>>>> .dtso is much more recent, > >>>>>> > >>>>>> Is it? > >>>>> > >>>>> Well, I wouldn't bet money on it, I just seem to remember encountering > >>>>> .dtbo for some time before .dtso was mentioned. > >>>>> > >>>>>> The oldest reference I could find is from May 2015: > >>>>>> "[PATCH/RFC] kbuild: Create a rule for building device tree overlay objects" > >>>>>> https://lore.kernel.org/linux-devicetree/1431431816-24612-1-git-send-email-geert+renesas@glider.be/ > >>>>> > >>>>> Hm, I think .dtbo is even older than that, but again, I wouldn't swear > >>>>> to it. > >>>> > >>>> Sure. My work is based on Pantelis' work for BeagleBoard capes. > >>>> His code (from 2013?) used .dtbo and .dts: > >>>> > >>>> overlay/v3.10/merge:firmware/Makefile:$(obj)/%.dtbo: $(obj)/%.dts > >>>> | $(objtree)/$(obj)/$$(dir %) > >>>> > >>>> So I might be the one who introduced .dtso... > >>>> > >>>>>> I have always used dtbo/dtso in my published overlays branches, > >>>>>> referred from https://elinux.org/R-Car/DT-Overlays, and used by > >>>>>> various people. > >>>>>> > >>>>>>> and I think there's much less value to it. > >>>>>> > >>>>>> IMHO the same reasoning as for dtb vs. dtbo applies to dts vs. dtso. > >>>>>> It matters if the resulting blob will be an overlay or base tree, > >>>>>> as the blob will have to be called .dtb or .dtbo. > >>>>>> As dtc outputs to stdout by default, the caller has to provide the > >>>>>> output filename, and thus needs to know. > >>>>>> Even if dtc would name the output file based on the presence of > >>>>>> "/plugin/" in the input file, the build system still needs to know > >>>>>> for dependency tracking. > >>>>> > >>>>> Hm, fair point. I was thinking of the the /plugin/ tag as the > >>>>> distinction, whereas dtb is binary and the distinction isn't even > >>>>> marked in the header. But you're right that even readable text labels > >>>>> inside the file don't really help make(1). So, I retract that > >>>>> assertion. > >>>> > >>>> Thanks! > >>>> > >>>>>> We also do have .dts vs. .dtsi. > >>> > >>> In the mean time, we're at rc7 again? > >> > >> That was v5.13-rc7. Now we're at v5.14-rc7... > >> > >> Will we live with the inability to e.g. let make distinguish between > >> DT includes and overlays forever? > > > > I guess this is not gonna happen, so I'll convert all my overlays > > from .dtso to .dts.... > > > > Gr{oetje,eeting}s, > > > > Geert > > > > -- > > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > > > In personal conversations with technical people, I call myself a hacker. But > > when I'm talking to journalists I just say "programmer" or something like that. > > -- Linus Torvalds > > >
Hi Rob, On Fri, Jan 14, 2022 at 3:10 AM Rob Herring <robh@kernel.org> wrote: > On Thu, Jan 6, 2022 at 11:23 AM Frank Rowand <frowand.list@gmail.com> wrote: > > Patient Geert has pinged again. > > If it's not a patch to be reviewed, then I'm not going to see it most > likely. I don't read the DT list regularly... Fair enough... > > If I remember correctly you guys were not thrilled with this idea, but > > also did not seem strongly against it. Are you willing to go along > > with .dtso for overlay source files? If so, I will revive this patch > > series. > > > > David, if you are against supporting .dtso in the dtc compiler then > > the kernel can still support it through make rules. > > I'm not really interested in diverging from dtc. I'd suggest moving > the discussion to dtc list and/or devicetree-spec if you want to get > more attention on this. What needs to be supported in the dtc compiler? The fallback passed to guess_input_format() is "dts". So this has been working out-of-the-box since forever? > Also, keep in mind that extensions also affect MIME types which > someone was also asking about recently. You mean "MIME type of Devicetree Blobs and Sources"[1]? According to [2](2022-01-13), none of that has happened. [1] https://www.spinics.net/lists/devicetree-spec/msg00938.html [2] https://www.iana.org/assignments/media-types/media-types.xhtml > > On 1/6/22 3:00 AM, Geert Uytterhoeven wrote: > > > On Tue, Aug 24, 2021 at 11:20 AM Geert Uytterhoeven > > > <geert@linux-m68k.org> wrote: > > >> On Tue, Jun 22, 2021 at 11:44 AM Geert Uytterhoeven > > >> <geert@linux-m68k.org> wrote: > > >>> On Sat, May 29, 2021 at 12:16 PM Geert Uytterhoeven > > >>> <geert@linux-m68k.org> wrote: > > >>>> On Sat, May 29, 2021 at 7:16 AM David Gibson > > >>>> <david@gibson.dropbear.id.au> wrote: > > >>>>> On Thu, May 27, 2021 at 09:21:05AM +0200, Geert Uytterhoeven wrote: > > >>>>> 65;6401;1c> On Thu, May 27, 2021 at 3:48 AM David Gibson > > >>>>>> <david@gibson.dropbear.id.au> wrote: > > >>>>>>> On Wed, May 26, 2021 at 04:21:48PM -0500, Frank Rowand wrote: > > >>>>>>>> On 5/26/21 1:11 AM, Viresh Kumar wrote: > > >>>>>>>>> On 22-04-21, 13:54, Frank Rowand wrote: > > >>>>>>>>>> On 4/22/21 3:44 AM, Geert Uytterhoeven wrote: > > >>>>>>>>>>> On Mon, Mar 29, 2021 at 9:23 PM Frank Rowand <frowand.list@gmail.com> wrote: > > >>>>>>>>>>>> On 3/27/21 12:40 PM, Rob Herring wrote: > > >>>>>>>>>>>>> On Wed, Mar 24, 2021 at 05:37:13PM -0500, frowand.list@gmail.com wrote: > > >>>>>>>>>>>>>> From: Frank Rowand <frank.rowand@sony.com> > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> Add Makefile rule to build .dtbo.o assembly file from overlay .dtso > > >>>>>>>>>>>>>> source file. > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> Rename unittest .dts overlay source files to use .dtso suffix. > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> I'm pretty lukewarm on .dtso... > > >>>>>>>>>>>> > > >>>>>>>>>>>> I was originally also, but I'm warming up to it. > > >>>>>>>>>>> > > >>>>>>>>>>> What's the status of this? > > >>>>>>>>>> > > >>>>>>>>>> I was planning to resend on top of the upcoming -rc1. > > >>>>>>>>> > > >>>>>>>>> Ping. > > >>>>>>>>> > > >>>>>>>> > > >>>>>>>> Thanks for the prod... > > >>>>>>>> > > >>>>>>>> The .dtso convention was added to the dtc compiler, then a patch was > > >>>>>>>> accepted to revert one mention of .dtso ,though there still remains > > >>>>>>>> two location where .dtbo is still recognized (guess_type_by_name() in > > >>>>>>>> dtc and the help text of the fdtoverlay program). > > >>>>>>>> > > >>>>>>>> It seems that the general .dtso and .dtbo were not popular, so I'm > > >>>>>>>> going to drop this patch instead of continuing to try to get it > > >>>>>>>> accepted. > > >>>>>>> > > >>>>>>> AFAICT .dtbo is moderately well established, and I think it's a good > > >>>>>>> convention, since it matters whether a blob is an overlay or base > > >>>>>>> tree, and it's not trivial to tell which is which. > > >>>>>> > > >>>>>> Indeed. > > >>>>>> > > >>>>>>> .dtso is much more recent, > > >>>>>> > > >>>>>> Is it? > > >>>>> > > >>>>> Well, I wouldn't bet money on it, I just seem to remember encountering > > >>>>> .dtbo for some time before .dtso was mentioned. > > >>>>> > > >>>>>> The oldest reference I could find is from May 2015: > > >>>>>> "[PATCH/RFC] kbuild: Create a rule for building device tree overlay objects" > > >>>>>> https://lore.kernel.org/linux-devicetree/1431431816-24612-1-git-send-email-geert+renesas@glider.be/ > > >>>>> > > >>>>> Hm, I think .dtbo is even older than that, but again, I wouldn't swear > > >>>>> to it. > > >>>> > > >>>> Sure. My work is based on Pantelis' work for BeagleBoard capes. > > >>>> His code (from 2013?) used .dtbo and .dts: > > >>>> > > >>>> overlay/v3.10/merge:firmware/Makefile:$(obj)/%.dtbo: $(obj)/%.dts > > >>>> | $(objtree)/$(obj)/$$(dir %) > > >>>> > > >>>> So I might be the one who introduced .dtso... > > >>>> > > >>>>>> I have always used dtbo/dtso in my published overlays branches, > > >>>>>> referred from https://elinux.org/R-Car/DT-Overlays, and used by > > >>>>>> various people. > > >>>>>> > > >>>>>>> and I think there's much less value to it. > > >>>>>> > > >>>>>> IMHO the same reasoning as for dtb vs. dtbo applies to dts vs. dtso. > > >>>>>> It matters if the resulting blob will be an overlay or base tree, > > >>>>>> as the blob will have to be called .dtb or .dtbo. > > >>>>>> As dtc outputs to stdout by default, the caller has to provide the > > >>>>>> output filename, and thus needs to know. > > >>>>>> Even if dtc would name the output file based on the presence of > > >>>>>> "/plugin/" in the input file, the build system still needs to know > > >>>>>> for dependency tracking. > > >>>>> > > >>>>> Hm, fair point. I was thinking of the the /plugin/ tag as the > > >>>>> distinction, whereas dtb is binary and the distinction isn't even > > >>>>> marked in the header. But you're right that even readable text labels > > >>>>> inside the file don't really help make(1). So, I retract that > > >>>>> assertion. > > >>>> > > >>>> Thanks! > > >>>> > > >>>>>> We also do have .dts vs. .dtsi. > > >>> > > >>> In the mean time, we're at rc7 again? > > >> > > >> That was v5.13-rc7. Now we're at v5.14-rc7... > > >> > > >> Will we live with the inability to e.g. let make distinguish between > > >> DT includes and overlays forever? > > > > > > I guess this is not gonna happen, so I'll convert all my overlays > > > from .dtso to .dts....
On Fri, Jan 14, 2022 at 10:25:03AM +0100, Geert Uytterhoeven wrote: > Hi Rob, > > On Fri, Jan 14, 2022 at 3:10 AM Rob Herring <robh@kernel.org> wrote: > > On Thu, Jan 6, 2022 at 11:23 AM Frank Rowand <frowand.list@gmail.com> wrote: > > > Patient Geert has pinged again. > > > > If it's not a patch to be reviewed, then I'm not going to see it most > > likely. I don't read the DT list regularly... > > Fair enough... > > > > If I remember correctly you guys were not thrilled with this idea, but > > > also did not seem strongly against it. Are you willing to go along > > > with .dtso for overlay source files? If so, I will revive this patch > > > series. > > > > > > David, if you are against supporting .dtso in the dtc compiler then > > > the kernel can still support it through make rules. TBH, I barely remember the earlier discussion. I am more or less indifferent on .dtso. > > I'm not really interested in diverging from dtc. I'd suggest moving > > the discussion to dtc list and/or devicetree-spec if you want to get > > more attention on this. > > What needs to be supported in the dtc compiler? > The fallback passed to guess_input_format() is "dts". > So this has been working out-of-the-box since forever? Right. I usually like to supply -I and -O to dtc explicitly, in which case the extensions basically irrelevant. I suppose we could also issue warnings if the /plugin/ tag doesn't match the file extension. > > Also, keep in mind that extensions also affect MIME types which > > someone was also asking about recently. > > You mean "MIME type of Devicetree Blobs and Sources"[1]? > According to [2](2022-01-13), none of that has happened. > > [1] https://www.spinics.net/lists/devicetree-spec/msg00938.html > [2] https://www.iana.org/assignments/media-types/media-types.xhtml > > > > On 1/6/22 3:00 AM, Geert Uytterhoeven wrote: > > > > On Tue, Aug 24, 2021 at 11:20 AM Geert Uytterhoeven > > > > <geert@linux-m68k.org> wrote: > > > >> On Tue, Jun 22, 2021 at 11:44 AM Geert Uytterhoeven > > > >> <geert@linux-m68k.org> wrote: > > > >>> On Sat, May 29, 2021 at 12:16 PM Geert Uytterhoeven > > > >>> <geert@linux-m68k.org> wrote: > > > >>>> On Sat, May 29, 2021 at 7:16 AM David Gibson > > > >>>> <david@gibson.dropbear.id.au> wrote: > > > >>>>> On Thu, May 27, 2021 at 09:21:05AM +0200, Geert Uytterhoeven wrote: > > > >>>>> 65;6401;1c> On Thu, May 27, 2021 at 3:48 AM David Gibson > > > >>>>>> <david@gibson.dropbear.id.au> wrote: > > > >>>>>>> On Wed, May 26, 2021 at 04:21:48PM -0500, Frank Rowand wrote: > > > >>>>>>>> On 5/26/21 1:11 AM, Viresh Kumar wrote: > > > >>>>>>>>> On 22-04-21, 13:54, Frank Rowand wrote: > > > >>>>>>>>>> On 4/22/21 3:44 AM, Geert Uytterhoeven wrote: > > > >>>>>>>>>>> On Mon, Mar 29, 2021 at 9:23 PM Frank Rowand <frowand.list@gmail.com> wrote: > > > >>>>>>>>>>>> On 3/27/21 12:40 PM, Rob Herring wrote: > > > >>>>>>>>>>>>> On Wed, Mar 24, 2021 at 05:37:13PM -0500, frowand.list@gmail.com wrote: > > > >>>>>>>>>>>>>> From: Frank Rowand <frank.rowand@sony.com> > > > >>>>>>>>>>>>>> > > > >>>>>>>>>>>>>> Add Makefile rule to build .dtbo.o assembly file from overlay .dtso > > > >>>>>>>>>>>>>> source file. > > > >>>>>>>>>>>>>> > > > >>>>>>>>>>>>>> Rename unittest .dts overlay source files to use .dtso suffix. > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> I'm pretty lukewarm on .dtso... > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> I was originally also, but I'm warming up to it. > > > >>>>>>>>>>> > > > >>>>>>>>>>> What's the status of this? > > > >>>>>>>>>> > > > >>>>>>>>>> I was planning to resend on top of the upcoming -rc1. > > > >>>>>>>>> > > > >>>>>>>>> Ping. > > > >>>>>>>>> > > > >>>>>>>> > > > >>>>>>>> Thanks for the prod... > > > >>>>>>>> > > > >>>>>>>> The .dtso convention was added to the dtc compiler, then a patch was > > > >>>>>>>> accepted to revert one mention of .dtso ,though there still remains > > > >>>>>>>> two location where .dtbo is still recognized (guess_type_by_name() in > > > >>>>>>>> dtc and the help text of the fdtoverlay program). > > > >>>>>>>> > > > >>>>>>>> It seems that the general .dtso and .dtbo were not popular, so I'm > > > >>>>>>>> going to drop this patch instead of continuing to try to get it > > > >>>>>>>> accepted. > > > >>>>>>> > > > >>>>>>> AFAICT .dtbo is moderately well established, and I think it's a good > > > >>>>>>> convention, since it matters whether a blob is an overlay or base > > > >>>>>>> tree, and it's not trivial to tell which is which. > > > >>>>>> > > > >>>>>> Indeed. > > > >>>>>> > > > >>>>>>> .dtso is much more recent, > > > >>>>>> > > > >>>>>> Is it? > > > >>>>> > > > >>>>> Well, I wouldn't bet money on it, I just seem to remember encountering > > > >>>>> .dtbo for some time before .dtso was mentioned. > > > >>>>> > > > >>>>>> The oldest reference I could find is from May 2015: > > > >>>>>> "[PATCH/RFC] kbuild: Create a rule for building device tree overlay objects" > > > >>>>>> https://lore.kernel.org/linux-devicetree/1431431816-24612-1-git-send-email-geert+renesas@glider.be/ > > > >>>>> > > > >>>>> Hm, I think .dtbo is even older than that, but again, I wouldn't swear > > > >>>>> to it. > > > >>>> > > > >>>> Sure. My work is based on Pantelis' work for BeagleBoard capes. > > > >>>> His code (from 2013?) used .dtbo and .dts: > > > >>>> > > > >>>> overlay/v3.10/merge:firmware/Makefile:$(obj)/%.dtbo: $(obj)/%.dts > > > >>>> | $(objtree)/$(obj)/$$(dir %) > > > >>>> > > > >>>> So I might be the one who introduced .dtso... > > > >>>> > > > >>>>>> I have always used dtbo/dtso in my published overlays branches, > > > >>>>>> referred from https://elinux.org/R-Car/DT-Overlays, and used by > > > >>>>>> various people. > > > >>>>>> > > > >>>>>>> and I think there's much less value to it. > > > >>>>>> > > > >>>>>> IMHO the same reasoning as for dtb vs. dtbo applies to dts vs. dtso. > > > >>>>>> It matters if the resulting blob will be an overlay or base tree, > > > >>>>>> as the blob will have to be called .dtb or .dtbo. > > > >>>>>> As dtc outputs to stdout by default, the caller has to provide the > > > >>>>>> output filename, and thus needs to know. > > > >>>>>> Even if dtc would name the output file based on the presence of > > > >>>>>> "/plugin/" in the input file, the build system still needs to know > > > >>>>>> for dependency tracking. > > > >>>>> > > > >>>>> Hm, fair point. I was thinking of the the /plugin/ tag as the > > > >>>>> distinction, whereas dtb is binary and the distinction isn't even > > > >>>>> marked in the header. But you're right that even readable text labels > > > >>>>> inside the file don't really help make(1). So, I retract that > > > >>>>> assertion. > > > >>>> > > > >>>> Thanks! > > > >>>> > > > >>>>>> We also do have .dts vs. .dtsi. > > > >>> > > > >>> In the mean time, we're at rc7 again? > > > >> > > > >> That was v5.13-rc7. Now we're at v5.14-rc7... > > > >> > > > >> Will we live with the inability to e.g. let make distinguish between > > > >> DT includes and overlays forever? > > > > > > > > I guess this is not gonna happen, so I'll convert all my overlays > > > > from .dtso to .dts.... >
On Fri, Jan 14, 2022 at 3:25 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Rob, > > On Fri, Jan 14, 2022 at 3:10 AM Rob Herring <robh@kernel.org> wrote: > > On Thu, Jan 6, 2022 at 11:23 AM Frank Rowand <frowand.list@gmail.com> wrote: > > > Patient Geert has pinged again. > > > > If it's not a patch to be reviewed, then I'm not going to see it most > > likely. I don't read the DT list regularly... > > Fair enough... > > > > If I remember correctly you guys were not thrilled with this idea, but > > > also did not seem strongly against it. Are you willing to go along > > > with .dtso for overlay source files? If so, I will revive this patch > > > series. > > > > > > David, if you are against supporting .dtso in the dtc compiler then > > > the kernel can still support it through make rules. > > > > I'm not really interested in diverging from dtc. I'd suggest moving > > the discussion to dtc list and/or devicetree-spec if you want to get > > more attention on this. > > What needs to be supported in the dtc compiler? > The fallback passed to guess_input_format() is "dts". > So this has been working out-of-the-box since forever? Ah, okay. > > Also, keep in mind that extensions also affect MIME types which > > someone was also asking about recently. > > You mean "MIME type of Devicetree Blobs and Sources"[1]? > According to [2](2022-01-13), none of that has happened. This is what I was thinking of: https://github.com/devicetree-org/devicetree-specification/issues/46 In any case, given everyone is ambivalent, send me an updated patch and I'll apply it. Rob
On Wed, Jan 26, 2022 at 1:31 PM Rob Herring <robh@kernel.org> wrote: > > On Fri, Jan 14, 2022 at 3:25 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > > Hi Rob, > > > > On Fri, Jan 14, 2022 at 3:10 AM Rob Herring <robh@kernel.org> wrote: > > > On Thu, Jan 6, 2022 at 11:23 AM Frank Rowand <frowand.list@gmail.com> wrote: > > > > Patient Geert has pinged again. > > > > > > If it's not a patch to be reviewed, then I'm not going to see it most > > > likely. I don't read the DT list regularly... > > > > Fair enough... > > > > > > If I remember correctly you guys were not thrilled with this idea, but > > > > also did not seem strongly against it. Are you willing to go along > > > > with .dtso for overlay source files? If so, I will revive this patch > > > > series. > > > > > > > > David, if you are against supporting .dtso in the dtc compiler then > > > > the kernel can still support it through make rules. > > > > > > I'm not really interested in diverging from dtc. I'd suggest moving > > > the discussion to dtc list and/or devicetree-spec if you want to get > > > more attention on this. > > > > What needs to be supported in the dtc compiler? > > The fallback passed to guess_input_format() is "dts". > > So this has been working out-of-the-box since forever? > > Ah, okay. > > > > Also, keep in mind that extensions also affect MIME types which > > > someone was also asking about recently. > > > > You mean "MIME type of Devicetree Blobs and Sources"[1]? > > According to [2](2022-01-13), none of that has happened. > > This is what I was thinking of: > > https://github.com/devicetree-org/devicetree-specification/issues/46 > > In any case, given everyone is ambivalent, send me an updated patch > and I'll apply it. Ping! Anyone still want this? What I don't want to see is a mixture of .dts and .dtso. And now I'm reviewing RPi overlay patches[1] with .dts. Rob [1] https://lore.kernel.org/r/20220427185243.173594-3-detlev.casanova@collabora.com
diff --git a/Documentation/devicetree/index.rst b/Documentation/devicetree/index.rst index 54026763916d..b2071f744e46 100644 --- a/Documentation/devicetree/index.rst +++ b/Documentation/devicetree/index.rst @@ -11,7 +11,6 @@ Open Firmware and Device Tree writing-schema changesets dynamic-resolution-notes - of_unittest overlay-notes bindings/index diff --git a/Documentation/devicetree/of_unittest.rst b/Documentation/devicetree/of_unittest.rst deleted file mode 100644 index dea05214f3ad..000000000000 --- a/Documentation/devicetree/of_unittest.rst +++ /dev/null @@ -1,205 +0,0 @@ -.. SPDX-License-Identifier: GPL-2.0 - -================================== -Open Firmware Device Tree Unittest -================================== - -Author: Gaurav Minocha <gaurav.minocha.os@gmail.com> - -1. Introduction -=============== - -This document explains how the test data required for executing OF unittest -is attached to the live tree dynamically, independent of the machine's -architecture. - -It is recommended to read the following documents before moving ahead. - -(1) Documentation/devicetree/usage-model.rst -(2) http://www.devicetree.org/Device_Tree_Usage - -OF Selftest has been designed to test the interface (include/linux/of.h) -provided to device driver developers to fetch the device information..etc. -from the unflattened device tree data structure. This interface is used by -most of the device drivers in various use cases. - - -2. Test-data -============ - -The Device Tree Source file (drivers/of/unittest-data/testcases.dts) contains -the test data required for executing the unit tests automated in -drivers/of/unittest.c. Currently, following Device Tree Source Include files -(.dtsi) are included in testcases.dts:: - - drivers/of/unittest-data/tests-interrupts.dtsi - drivers/of/unittest-data/tests-platform.dtsi - drivers/of/unittest-data/tests-phandle.dtsi - drivers/of/unittest-data/tests-match.dtsi - -When the kernel is build with OF_SELFTEST enabled, then the following make -rule:: - - $(obj)/%.dtb: $(src)/%.dts FORCE - $(call if_changed_dep, dtc) - -is used to compile the DT source file (testcases.dts) into a binary blob -(testcases.dtb), also referred as flattened DT. - -After that, using the following rule the binary blob above is wrapped as an -assembly file (testcases.dtb.S):: - - $(obj)/%.dtb.S: $(obj)/%.dtb - $(call cmd, dt_S_dtb) - -The assembly file is compiled into an object file (testcases.dtb.o), and is -linked into the kernel image. - - -2.1. Adding the test data -------------------------- - -Un-flattened device tree structure: - -Un-flattened device tree consists of connected device_node(s) in form of a tree -structure described below:: - - // following struct members are used to construct the tree - struct device_node { - ... - struct device_node *parent; - struct device_node *child; - struct device_node *sibling; - ... - }; - -Figure 1, describes a generic structure of machine's un-flattened device tree -considering only child and sibling pointers. There exists another pointer, -``*parent``, that is used to traverse the tree in the reverse direction. So, at -a particular level the child node and all the sibling nodes will have a parent -pointer pointing to a common node (e.g. child1, sibling2, sibling3, sibling4's -parent points to root node):: - - root ('/') - | - child1 -> sibling2 -> sibling3 -> sibling4 -> null - | | | | - | | | null - | | | - | | child31 -> sibling32 -> null - | | | | - | | null null - | | - | child21 -> sibling22 -> sibling23 -> null - | | | | - | null null null - | - child11 -> sibling12 -> sibling13 -> sibling14 -> null - | | | | - | | | null - | | | - null null child131 -> null - | - null - -Figure 1: Generic structure of un-flattened device tree - - -Before executing OF unittest, it is required to attach the test data to -machine's device tree (if present). So, when selftest_data_add() is called, -at first it reads the flattened device tree data linked into the kernel image -via the following kernel symbols:: - - __dtb_testcases_begin - address marking the start of test data blob - __dtb_testcases_end - address marking the end of test data blob - -Secondly, it calls of_fdt_unflatten_tree() to unflatten the flattened -blob. And finally, if the machine's device tree (i.e live tree) is present, -then it attaches the unflattened test data tree to the live tree, else it -attaches itself as a live device tree. - -attach_node_and_children() uses of_attach_node() to attach the nodes into the -live tree as explained below. To explain the same, the test data tree described -in Figure 2 is attached to the live tree described in Figure 1:: - - root ('/') - | - testcase-data - | - test-child0 -> test-sibling1 -> test-sibling2 -> test-sibling3 -> null - | | | | - test-child01 null null null - - -Figure 2: Example test data tree to be attached to live tree. - -According to the scenario above, the live tree is already present so it isn't -required to attach the root('/') node. All other nodes are attached by calling -of_attach_node() on each node. - -In the function of_attach_node(), the new node is attached as the child of the -given parent in live tree. But, if parent already has a child then the new node -replaces the current child and turns it into its sibling. So, when the testcase -data node is attached to the live tree above (Figure 1), the final structure is -as shown in Figure 3:: - - root ('/') - | - testcase-data -> child1 -> sibling2 -> sibling3 -> sibling4 -> null - | | | | | - (...) | | | null - | | child31 -> sibling32 -> null - | | | | - | | null null - | | - | child21 -> sibling22 -> sibling23 -> null - | | | | - | null null null - | - child11 -> sibling12 -> sibling13 -> sibling14 -> null - | | | | - null null | null - | - child131 -> null - | - null - ----------------------------------------------------------------------- - - root ('/') - | - testcase-data -> child1 -> sibling2 -> sibling3 -> sibling4 -> null - | | | | | - | (...) (...) (...) null - | - test-sibling3 -> test-sibling2 -> test-sibling1 -> test-child0 -> null - | | | | - null null null test-child01 - - -Figure 3: Live device tree structure after attaching the testcase-data. - - -Astute readers would have noticed that test-child0 node becomes the last -sibling compared to the earlier structure (Figure 2). After attaching first -test-child0 the test-sibling1 is attached that pushes the child node -(i.e. test-child0) to become a sibling and makes itself a child node, -as mentioned above. - -If a duplicate node is found (i.e. if a node with same full_name property is -already present in the live tree), then the node isn't attached rather its -properties are updated to the live tree's node by calling the function -update_node_properties(). - - -2.2. Removing the test data ---------------------------- - -Once the test case execution is complete, selftest_data_remove is called in -order to remove the device nodes attached initially (first the leaf nodes are -detached and then moving up the parent nodes are removed, and eventually the -whole tree). selftest_data_remove() calls detach_node_and_children() that uses -of_detach_node() to detach the nodes from the live device tree. - -To detach a node, of_detach_node() either updates the child pointer of given -node's parent to its sibling or attaches the previous sibling to the given -node's sibling, as appropriate. That is it :) diff --git a/drivers/of/unittest-data/Makefile b/drivers/of/unittest-data/Makefile index a5d2d9254b2c..bc1cee638bf7 100644 --- a/drivers/of/unittest-data/Makefile +++ b/drivers/of/unittest-data/Makefile @@ -1,33 +1,53 @@ # SPDX-License-Identifier: GPL-2.0 -obj-y += testcases.dtb.o -obj-$(CONFIG_OF_OVERLAY) += overlay.dtb.o \ - overlay_0.dtb.o \ - overlay_1.dtb.o \ - overlay_2.dtb.o \ - overlay_3.dtb.o \ - overlay_4.dtb.o \ - overlay_5.dtb.o \ - overlay_6.dtb.o \ - overlay_7.dtb.o \ - overlay_8.dtb.o \ - overlay_9.dtb.o \ - overlay_10.dtb.o \ - overlay_11.dtb.o \ - overlay_12.dtb.o \ - overlay_13.dtb.o \ - overlay_15.dtb.o \ - overlay_bad_add_dup_node.dtb.o \ - overlay_bad_add_dup_prop.dtb.o \ - overlay_bad_phandle.dtb.o \ - overlay_bad_symbol.dtb.o \ - overlay_base.dtb.o \ - overlay_gpio_01.dtb.o \ - overlay_gpio_02a.dtb.o \ - overlay_gpio_02b.dtb.o \ - overlay_gpio_03.dtb.o \ - overlay_gpio_04a.dtb.o \ - overlay_gpio_04b.dtb.o +# Generate an assembly file to wrap the output of the device tree compiler +quiet_cmd_dt_S_dtbo= DTB $@ +cmd_dt_S_dtbo= \ +{ \ + echo '\#include <asm-generic/vmlinux.lds.h>'; \ + echo '.section .dtb.init.rodata,"a"'; \ + echo '.balign STRUCT_ALIGNMENT'; \ + echo '.global __dtbo_$(subst -,_,$(*F))_begin'; \ + echo '__dtbo_$(subst -,_,$(*F))_begin:'; \ + echo '.incbin "$<" '; \ + echo '__dtbo_$(subst -,_,$(*F))_end:'; \ + echo '.global __dtbo_$(subst -,_,$(*F))_end'; \ + echo '.balign STRUCT_ALIGNMENT'; \ +} > $@ + + +$(obj)/%.dtbo.S: $(obj)/%.dtbo FORCE + $(call if_changed,dt_S_dtbo) + +obj-y += testcases.dtbo.o + +obj-$(CONFIG_OF_OVERLAY) += overlay.dtbo.o \ + overlay_0.dtbo.o \ + overlay_1.dtbo.o \ + overlay_2.dtbo.o \ + overlay_3.dtbo.o \ + overlay_4.dtbo.o \ + overlay_5.dtbo.o \ + overlay_6.dtbo.o \ + overlay_7.dtbo.o \ + overlay_8.dtbo.o \ + overlay_9.dtbo.o \ + overlay_10.dtbo.o \ + overlay_11.dtbo.o \ + overlay_12.dtbo.o \ + overlay_13.dtbo.o \ + overlay_15.dtbo.o \ + overlay_bad_add_dup_node.dtbo.o \ + overlay_bad_add_dup_prop.dtbo.o \ + overlay_bad_phandle.dtbo.o \ + overlay_bad_symbol.dtbo.o \ + overlay_base.dtbo.o \ + overlay_gpio_01.dtbo.o \ + overlay_gpio_02a.dtbo.o \ + overlay_gpio_02b.dtbo.o \ + overlay_gpio_03.dtbo.o \ + overlay_gpio_04a.dtbo.o \ + overlay_gpio_04b.dtbo.o # enable creation of __symbols__ node DTC_FLAGS_overlay += -@ diff --git a/drivers/of/unittest-data/overlay.dts b/drivers/of/unittest-data/overlay.dtso similarity index 100% rename from drivers/of/unittest-data/overlay.dts rename to drivers/of/unittest-data/overlay.dtso diff --git a/drivers/of/unittest-data/overlay_0.dts b/drivers/of/unittest-data/overlay_0.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_0.dts rename to drivers/of/unittest-data/overlay_0.dtso diff --git a/drivers/of/unittest-data/overlay_1.dts b/drivers/of/unittest-data/overlay_1.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_1.dts rename to drivers/of/unittest-data/overlay_1.dtso diff --git a/drivers/of/unittest-data/overlay_10.dts b/drivers/of/unittest-data/overlay_10.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_10.dts rename to drivers/of/unittest-data/overlay_10.dtso diff --git a/drivers/of/unittest-data/overlay_11.dts b/drivers/of/unittest-data/overlay_11.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_11.dts rename to drivers/of/unittest-data/overlay_11.dtso diff --git a/drivers/of/unittest-data/overlay_12.dts b/drivers/of/unittest-data/overlay_12.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_12.dts rename to drivers/of/unittest-data/overlay_12.dtso diff --git a/drivers/of/unittest-data/overlay_13.dts b/drivers/of/unittest-data/overlay_13.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_13.dts rename to drivers/of/unittest-data/overlay_13.dtso diff --git a/drivers/of/unittest-data/overlay_15.dts b/drivers/of/unittest-data/overlay_15.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_15.dts rename to drivers/of/unittest-data/overlay_15.dtso diff --git a/drivers/of/unittest-data/overlay_2.dts b/drivers/of/unittest-data/overlay_2.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_2.dts rename to drivers/of/unittest-data/overlay_2.dtso diff --git a/drivers/of/unittest-data/overlay_3.dts b/drivers/of/unittest-data/overlay_3.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_3.dts rename to drivers/of/unittest-data/overlay_3.dtso diff --git a/drivers/of/unittest-data/overlay_4.dts b/drivers/of/unittest-data/overlay_4.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_4.dts rename to drivers/of/unittest-data/overlay_4.dtso diff --git a/drivers/of/unittest-data/overlay_5.dts b/drivers/of/unittest-data/overlay_5.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_5.dts rename to drivers/of/unittest-data/overlay_5.dtso diff --git a/drivers/of/unittest-data/overlay_6.dts b/drivers/of/unittest-data/overlay_6.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_6.dts rename to drivers/of/unittest-data/overlay_6.dtso diff --git a/drivers/of/unittest-data/overlay_7.dts b/drivers/of/unittest-data/overlay_7.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_7.dts rename to drivers/of/unittest-data/overlay_7.dtso diff --git a/drivers/of/unittest-data/overlay_8.dts b/drivers/of/unittest-data/overlay_8.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_8.dts rename to drivers/of/unittest-data/overlay_8.dtso diff --git a/drivers/of/unittest-data/overlay_9.dts b/drivers/of/unittest-data/overlay_9.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_9.dts rename to drivers/of/unittest-data/overlay_9.dtso diff --git a/drivers/of/unittest-data/overlay_bad_add_dup_node.dts b/drivers/of/unittest-data/overlay_bad_add_dup_node.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_bad_add_dup_node.dts rename to drivers/of/unittest-data/overlay_bad_add_dup_node.dtso diff --git a/drivers/of/unittest-data/overlay_bad_add_dup_prop.dts b/drivers/of/unittest-data/overlay_bad_add_dup_prop.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_bad_add_dup_prop.dts rename to drivers/of/unittest-data/overlay_bad_add_dup_prop.dtso diff --git a/drivers/of/unittest-data/overlay_bad_phandle.dts b/drivers/of/unittest-data/overlay_bad_phandle.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_bad_phandle.dts rename to drivers/of/unittest-data/overlay_bad_phandle.dtso diff --git a/drivers/of/unittest-data/overlay_bad_symbol.dts b/drivers/of/unittest-data/overlay_bad_symbol.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_bad_symbol.dts rename to drivers/of/unittest-data/overlay_bad_symbol.dtso diff --git a/drivers/of/unittest-data/overlay_base.dts b/drivers/of/unittest-data/overlay_base.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_base.dts rename to drivers/of/unittest-data/overlay_base.dtso diff --git a/drivers/of/unittest-data/overlay_gpio_01.dts b/drivers/of/unittest-data/overlay_gpio_01.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_gpio_01.dts rename to drivers/of/unittest-data/overlay_gpio_01.dtso diff --git a/drivers/of/unittest-data/overlay_gpio_02a.dts b/drivers/of/unittest-data/overlay_gpio_02a.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_gpio_02a.dts rename to drivers/of/unittest-data/overlay_gpio_02a.dtso diff --git a/drivers/of/unittest-data/overlay_gpio_02b.dts b/drivers/of/unittest-data/overlay_gpio_02b.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_gpio_02b.dts rename to drivers/of/unittest-data/overlay_gpio_02b.dtso diff --git a/drivers/of/unittest-data/overlay_gpio_03.dts b/drivers/of/unittest-data/overlay_gpio_03.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_gpio_03.dts rename to drivers/of/unittest-data/overlay_gpio_03.dtso diff --git a/drivers/of/unittest-data/overlay_gpio_04a.dts b/drivers/of/unittest-data/overlay_gpio_04a.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_gpio_04a.dts rename to drivers/of/unittest-data/overlay_gpio_04a.dtso diff --git a/drivers/of/unittest-data/overlay_gpio_04b.dts b/drivers/of/unittest-data/overlay_gpio_04b.dtso similarity index 100% rename from drivers/of/unittest-data/overlay_gpio_04b.dts rename to drivers/of/unittest-data/overlay_gpio_04b.dtso diff --git a/drivers/of/unittest-data/testcases.dts b/drivers/of/unittest-data/testcases.dtso similarity index 100% rename from drivers/of/unittest-data/testcases.dts rename to drivers/of/unittest-data/testcases.dtso diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index eb100627c186..f42a7b7765f1 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -1410,12 +1410,12 @@ static int __init unittest_data_add(void) void *unittest_data; struct device_node *unittest_data_node, *np; /* - * __dtb_testcases_begin[] and __dtb_testcases_end[] are magically - * created by cmd_dt_S_dtb in scripts/Makefile.lib + * __dtbo_testcases_begin[] and __dtbo_testcases_end[] are + * created by cmd_dt_S_dtbo in Makefile */ - extern uint8_t __dtb_testcases_begin[]; - extern uint8_t __dtb_testcases_end[]; - const int size = __dtb_testcases_end - __dtb_testcases_begin; + extern uint8_t __dtbo_testcases_begin[]; + extern uint8_t __dtbo_testcases_end[]; + const int size = __dtbo_testcases_end - __dtbo_testcases_begin; int rc; if (!size) { @@ -1425,7 +1425,7 @@ static int __init unittest_data_add(void) } /* creating copy */ - unittest_data = kmemdup(__dtb_testcases_begin, size, GFP_KERNEL); + unittest_data = kmemdup(__dtbo_testcases_begin, size, GFP_KERNEL); if (!unittest_data) return -ENOMEM; @@ -2806,24 +2806,24 @@ static inline void __init of_unittest_overlay(void) { } #ifdef CONFIG_OF_OVERLAY /* - * __dtb_ot_begin[] and __dtb_ot_end[] are created by cmd_dt_S_dtb - * in scripts/Makefile.lib + * __dtbo_##overlay_name##_begin[] and __dtbo_##overlay_name##_end[] are + * created by cmd_dt_S_dtbo in Makefile */ -#define OVERLAY_INFO_EXTERN(name) \ - extern uint8_t __dtb_##name##_begin[]; \ - extern uint8_t __dtb_##name##_end[] +#define OVERLAY_INFO_EXTERN(overlay_name) \ + extern uint8_t __dtbo_##overlay_name##_begin[]; \ + extern uint8_t __dtbo_##overlay_name##_end[] -#define OVERLAY_INFO(overlay_name, expected) \ -{ .dtb_begin = __dtb_##overlay_name##_begin, \ - .dtb_end = __dtb_##overlay_name##_end, \ - .expected_result = expected, \ - .name = #overlay_name, \ +#define OVERLAY_INFO(overlay_name, expected) \ +{ .dtbo_begin = __dtbo_##overlay_name##_begin, \ + .dtbo_end = __dtbo_##overlay_name##_end, \ + .expected_result = expected, \ + .name = #overlay_name, \ } struct overlay_info { - uint8_t *dtb_begin; - uint8_t *dtb_end; + uint8_t *dtbo_begin; + uint8_t *dtbo_end; int expected_result; int overlay_id; char *name; @@ -2887,7 +2887,7 @@ static struct overlay_info overlays[] = { OVERLAY_INFO(overlay_bad_phandle, -EINVAL), OVERLAY_INFO(overlay_bad_symbol, -EINVAL), /* end marker */ - {.dtb_begin = NULL, .dtb_end = NULL, .expected_result = 0, .name = NULL} + {.dtbo_begin = NULL, .dtbo_end = NULL, .expected_result = 0, .name = NULL} }; static struct device_node *overlay_base_root; @@ -2944,13 +2944,13 @@ void __init unittest_unflatten_overlay_base(void) return; } - data_size = info->dtb_end - info->dtb_begin; + data_size = info->dtbo_end - info->dtbo_begin; if (!data_size) { pr_err("No dtb 'overlay_base' to attach\n"); return; } - size = fdt_totalsize(info->dtb_begin); + size = fdt_totalsize(info->dtbo_begin); if (size != data_size) { pr_err("dtb 'overlay_base' header totalsize != actual size"); return; @@ -2962,7 +2962,7 @@ void __init unittest_unflatten_overlay_base(void) return; } - memcpy(new_fdt, info->dtb_begin, size); + memcpy(new_fdt, info->dtbo_begin, size); __unflatten_device_tree(new_fdt, NULL, &overlay_base_root, dt_alloc_memory, true); @@ -2997,11 +2997,11 @@ static int __init overlay_data_apply(const char *overlay_name, int *overlay_id) return 0; } - size = info->dtb_end - info->dtb_begin; + size = info->dtbo_end - info->dtbo_begin; if (!size) pr_err("no overlay data for %s\n", overlay_name); - ret = of_overlay_fdt_apply(info->dtb_begin, size, &info->overlay_id); + ret = of_overlay_fdt_apply(info->dtbo_begin, size, &info->overlay_id); if (overlay_id) *overlay_id = info->overlay_id; if (ret < 0) diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index bc045a54a34e..5be0dc2b2b26 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -347,7 +347,7 @@ cmd_dtc = $(HOSTCC) -E $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) $< ; $(obj)/%.dtb: $(src)/%.dts $(DTC) FORCE $(call if_changed_dep,dtc) -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE +$(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE $(call if_changed_dep,dtc) overlay-y := $(addprefix $(obj)/, $(overlay-y))