diff mbox series

usb: dwc3: Create helper function getting MDWIDTH

Message ID f6c3bf1ec9d6e36a36ed84534988014f2dd70035.1616636455.git.Thinh.Nguyen@synopsys.com
State Superseded
Headers show
Series usb: dwc3: Create helper function getting MDWIDTH | expand

Commit Message

Thinh Nguyen March 25, 2021, 1:47 a.m. UTC 
Different controller IPs check different HW parameters for MDWIDTH.
To help with maintainability, create a helper function to consolidate
the logic in a single place.

Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
---
 drivers/usb/dwc3/core.h    | 19 +++++++++++++++++--
 drivers/usb/dwc3/debugfs.c | 12 ++++--------
 drivers/usb/dwc3/gadget.c  | 16 +++++-----------
 3 files changed, 26 insertions(+), 21 deletions(-)


base-commit: 049d3db625a652e23488db88b6104de4d5b62f16

Comments

Thinh Nguyen March 25, 2021, 2 a.m. UTC | #1 
Thinh Nguyen wrote:
> Different controller IPs check different HW parameters for MDWIDTH.

> To help with maintainability, create a helper function to consolidate

> the logic in a single place.

> 

> Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>

> ---

>  drivers/usb/dwc3/core.h    | 19 +++++++++++++++++--

>  drivers/usb/dwc3/debugfs.c | 12 ++++--------

>  drivers/usb/dwc3/gadget.c  | 16 +++++-----------

>  3 files changed, 26 insertions(+), 21 deletions(-)

> 


Sorry for the noise and please ignore the duplicate patch...

Thanks,
Thinh
Greg Kroah-Hartman March 26, 2021, 1:39 p.m. UTC | #2 
On Thu, Mar 25, 2021 at 02:00:14AM +0000, Thinh Nguyen wrote:
> Thinh Nguyen wrote:

> > Different controller IPs check different HW parameters for MDWIDTH.

> > To help with maintainability, create a helper function to consolidate

> > the logic in a single place.

> > 

> > Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>

> > ---

> >  drivers/usb/dwc3/core.h    | 19 +++++++++++++++++--

> >  drivers/usb/dwc3/debugfs.c | 12 ++++--------

> >  drivers/usb/dwc3/gadget.c  | 16 +++++-----------

> >  3 files changed, 26 insertions(+), 21 deletions(-)

> > 

> 

> Sorry for the noise and please ignore the duplicate patch...


So was this the duplicate?  I'm lost, so am dropping this one...

thanks,

greg k-h
Thinh Nguyen March 28, 2021, 12:55 a.m. UTC | #3 
Greg Kroah-Hartman wrote:
> On Thu, Mar 25, 2021 at 02:00:14AM +0000, Thinh Nguyen wrote:

>> Thinh Nguyen wrote:

>>> Different controller IPs check different HW parameters for MDWIDTH.

>>> To help with maintainability, create a helper function to consolidate

>>> the logic in a single place.

>>>

>>> Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>

>>> ---

>>>  drivers/usb/dwc3/core.h    | 19 +++++++++++++++++--

>>>  drivers/usb/dwc3/debugfs.c | 12 ++++--------

>>>  drivers/usb/dwc3/gadget.c  | 16 +++++-----------

>>>  3 files changed, 26 insertions(+), 21 deletions(-)

>>>

>>

>> Sorry for the noise and please ignore the duplicate patch...

> 

> So was this the duplicate?  I'm lost, so am dropping this one...

> 

> thanks,

> 

> greg k-h

> 



Yeah... sorry about that. Just sent a v2 to resolve this.

Thanks,
Thinh
diff mbox series

Patch

diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 4ca4b4be85e4..265190b7074a 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -860,8 +860,6 @@  struct dwc3_hwparams {
 /* HWPARAMS0 */
 #define DWC3_MODE(n)		((n) & 0x7)
 
-#define DWC3_MDWIDTH(n)		(((n) & 0xff00) >> 8)
-
 /* HWPARAMS1 */
 #define DWC3_NUM_INT(n)		(((n) & (0x3f << 15)) >> 15)
 
@@ -1458,6 +1456,23 @@  u32 dwc3_core_fifo_space(struct dwc3_ep *dep, u8 type);
 	 (!(_ip##_VERSIONTYPE_##_to) ||					\
 	  dwc->version_type <= _ip##_VERSIONTYPE_##_to))
 
+/**
+ * dwc3_mdwidth - get MDWIDTH value in bits
+ * @dwc: pointer to our context structure
+ *
+ * Return MDWIDTH configuration value in bits.
+ */
+static inline u32 dwc3_mdwidth(struct dwc3 *dwc)
+{
+	u32 mdwidth;
+
+	mdwidth = DWC3_GHWPARAMS0_MDWIDTH(dwc->hwparams.hwparams0);
+	if (DWC3_IP_IS(DWC32))
+		mdwidth += DWC3_GHWPARAMS6_MDWIDTH(dwc->hwparams.hwparams6);
+
+	return mdwidth;
+}
+
 bool dwc3_has_imod(struct dwc3 *dwc);
 
 int dwc3_event_buffers_setup(struct dwc3 *dwc);
diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
index 5da4f6082d93..c85852d98b4b 100644
--- a/drivers/usb/dwc3/debugfs.c
+++ b/drivers/usb/dwc3/debugfs.c
@@ -638,16 +638,14 @@  static int dwc3_tx_fifo_size_show(struct seq_file *s, void *unused)
 	struct dwc3_ep		*dep = s->private;
 	struct dwc3		*dwc = dep->dwc;
 	unsigned long		flags;
-	int			mdwidth;
+	u32			mdwidth;
 	u32			val;
 
 	spin_lock_irqsave(&dwc->lock, flags);
 	val = dwc3_core_fifo_space(dep, DWC3_TXFIFO);
 
 	/* Convert to bytes */
-	mdwidth = DWC3_MDWIDTH(dwc->hwparams.hwparams0);
-	if (DWC3_IP_IS(DWC32))
-		mdwidth += DWC3_GHWPARAMS6_MDWIDTH(dwc->hwparams.hwparams6);
+	mdwidth = dwc3_mdwidth(dwc);
 
 	val *= mdwidth;
 	val >>= 3;
@@ -662,16 +660,14 @@  static int dwc3_rx_fifo_size_show(struct seq_file *s, void *unused)
 	struct dwc3_ep		*dep = s->private;
 	struct dwc3		*dwc = dep->dwc;
 	unsigned long		flags;
-	int			mdwidth;
+	u32			mdwidth;
 	u32			val;
 
 	spin_lock_irqsave(&dwc->lock, flags);
 	val = dwc3_core_fifo_space(dep, DWC3_RXFIFO);
 
 	/* Convert to bytes */
-	mdwidth = DWC3_MDWIDTH(dwc->hwparams.hwparams0);
-	if (DWC3_IP_IS(DWC32))
-		mdwidth += DWC3_GHWPARAMS6_MDWIDTH(dwc->hwparams.hwparams6);
+	mdwidth = dwc3_mdwidth(dwc);
 
 	val *= mdwidth;
 	val >>= 3;
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index e1442fc763e1..a9540cc1a1eb 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -2337,9 +2337,7 @@  static void dwc3_gadget_setup_nump(struct dwc3 *dwc)
 	u32 reg;
 
 	ram2_depth = DWC3_GHWPARAMS7_RAM2_DEPTH(dwc->hwparams.hwparams7);
-	mdwidth = DWC3_GHWPARAMS0_MDWIDTH(dwc->hwparams.hwparams0);
-	if (DWC3_IP_IS(DWC32))
-		mdwidth += DWC3_GHWPARAMS6_MDWIDTH(dwc->hwparams.hwparams6);
+	mdwidth = dwc3_mdwidth(dwc);
 
 	nump = ((ram2_depth * mdwidth / 8) - 24 - 16) / 1024;
 	nump = min_t(u32, nump, 16);
@@ -2575,12 +2573,10 @@  static int dwc3_gadget_init_control_endpoint(struct dwc3_ep *dep)
 static int dwc3_gadget_init_in_endpoint(struct dwc3_ep *dep)
 {
 	struct dwc3 *dwc = dep->dwc;
-	int mdwidth;
+	u32 mdwidth;
 	int size;
 
-	mdwidth = DWC3_MDWIDTH(dwc->hwparams.hwparams0);
-	if (DWC3_IP_IS(DWC32))
-		mdwidth += DWC3_GHWPARAMS6_MDWIDTH(dwc->hwparams.hwparams6);
+	mdwidth = dwc3_mdwidth(dwc);
 
 	/* MDWIDTH is represented in bits, we need it in bytes */
 	mdwidth /= 8;
@@ -2622,12 +2618,10 @@  static int dwc3_gadget_init_in_endpoint(struct dwc3_ep *dep)
 static int dwc3_gadget_init_out_endpoint(struct dwc3_ep *dep)
 {
 	struct dwc3 *dwc = dep->dwc;
-	int mdwidth;
+	u32 mdwidth;
 	int size;
 
-	mdwidth = DWC3_MDWIDTH(dwc->hwparams.hwparams0);
-	if (DWC3_IP_IS(DWC32))
-		mdwidth += DWC3_GHWPARAMS6_MDWIDTH(dwc->hwparams.hwparams6);
+	mdwidth = dwc3_mdwidth(dwc);
 
 	/* MDWIDTH is represented in bits, convert to bytes */
 	mdwidth /= 8;