diff mbox series

[bpf-next,v7,06/13] skmsg: use GFP_KERNEL in sk_psock_create_ingress_msg()

Message ID 20210328202013.29223-7-xiyou.wangcong@gmail.com
State New
Headers show
Series [bpf-next,v7,01/13] skmsg: lock ingress_skb when purging | expand

Commit Message

Cong Wang March 28, 2021, 8:20 p.m. UTC
From: Cong Wang <cong.wang@bytedance.com>

This function is only called in process context.

Cc: John Fastabend <john.fastabend@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Jakub Sitnicki <jakub@cloudflare.com>
Cc: Lorenz Bauer <lmb@cloudflare.com>
Signed-off-by: Cong Wang <cong.wang@bytedance.com>
---
 net/core/skmsg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

John Fastabend March 29, 2021, 7:44 p.m. UTC | #1
Cong Wang wrote:
> From: Cong Wang <cong.wang@bytedance.com>

> 

> This function is only called in process context.

> 

> Cc: John Fastabend <john.fastabend@gmail.com>

> Cc: Daniel Borkmann <daniel@iogearbox.net>

> Cc: Jakub Sitnicki <jakub@cloudflare.com>

> Cc: Lorenz Bauer <lmb@cloudflare.com>

> Signed-off-by: Cong Wang <cong.wang@bytedance.com>

> ---

>  net/core/skmsg.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/net/core/skmsg.c b/net/core/skmsg.c

> index d43d43905d2c..656eceab73bc 100644

> --- a/net/core/skmsg.c

> +++ b/net/core/skmsg.c

> @@ -410,7 +410,7 @@ static struct sk_msg *sk_psock_create_ingress_msg(struct sock *sk,

>  	if (!sk_rmem_schedule(sk, skb, skb->truesize))

>  		return NULL;

>  

> -	msg = kzalloc(sizeof(*msg), __GFP_NOWARN | GFP_ATOMIC);

> +	msg = kzalloc(sizeof(*msg), __GFP_NOWARN | GFP_KERNEL);

>  	if (unlikely(!msg))

>  		return NULL;

>  

> -- 

> 2.25.1

> 


Acked-by: John Fastabend <john.fastabend@gmail.com>
diff mbox series

Patch

diff --git a/net/core/skmsg.c b/net/core/skmsg.c
index d43d43905d2c..656eceab73bc 100644
--- a/net/core/skmsg.c
+++ b/net/core/skmsg.c
@@ -410,7 +410,7 @@  static struct sk_msg *sk_psock_create_ingress_msg(struct sock *sk,
 	if (!sk_rmem_schedule(sk, skb, skb->truesize))
 		return NULL;
 
-	msg = kzalloc(sizeof(*msg), __GFP_NOWARN | GFP_ATOMIC);
+	msg = kzalloc(sizeof(*msg), __GFP_NOWARN | GFP_KERNEL);
 	if (unlikely(!msg))
 		return NULL;