diff mbox series

[v1,5/6] tests/tcg/i386: expand .data sections for system tests

Message ID 20210329110303.15235-6-alex.bennee@linaro.org
State Superseded
Headers show
Series check-tcg for non-x86 hosts | expand

Commit Message

Alex Bennée March 29, 2021, 11:03 a.m. UTC
Newer compilers might end up putting some data in .data.rel.local
which was getting skipped resulting in hilarious confusion on some
tests. Fix that.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
 tests/tcg/i386/system/kernel.ld | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1

Comments

Thomas Huth March 29, 2021, 11:39 a.m. UTC | #1
On 29/03/2021 13.03, Alex Bennée wrote:
> Newer compilers might end up putting some data in .data.rel.local

> which was getting skipped resulting in hilarious confusion on some

> tests. Fix that.

> 

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> ---

>   tests/tcg/i386/system/kernel.ld | 2 +-

>   1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/tests/tcg/i386/system/kernel.ld b/tests/tcg/i386/system/kernel.ld

> index 92de525e93..27ea5bbe04 100644

> --- a/tests/tcg/i386/system/kernel.ld

> +++ b/tests/tcg/i386/system/kernel.ld

> @@ -12,7 +12,7 @@ SECTIONS {

>   	}

>   

>   	.data : {

> -		*(.data)

> +		*(.data*)

>   		__load_en = .;

>   	}

>   

> 


Reviewed-by: Thomas Huth <thuth@redhat.com>
Richard Henderson March 30, 2021, 3:27 p.m. UTC | #2
On 3/29/21 5:03 AM, Alex Bennée wrote:
> Newer compilers might end up putting some data in .data.rel.local

> which was getting skipped resulting in hilarious confusion on some

> tests. Fix that.

> 

> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>

> ---

>   tests/tcg/i386/system/kernel.ld | 2 +-

>   1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~
diff mbox series

Patch

diff --git a/tests/tcg/i386/system/kernel.ld b/tests/tcg/i386/system/kernel.ld
index 92de525e93..27ea5bbe04 100644
--- a/tests/tcg/i386/system/kernel.ld
+++ b/tests/tcg/i386/system/kernel.ld
@@ -12,7 +12,7 @@  SECTIONS {
 	}
 
 	.data : {
-		*(.data)
+		*(.data*)
 		__load_en = .;
 	}