From patchwork Tue Mar 30 08:54:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 411685 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp4279235jai; Tue, 30 Mar 2021 01:55:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyG7xehhSpCFOf5p0pWOSj+3WxUoHo3ty2YXhfOtMFil89xD0Uh33xCYx0mI5W53JEXNcHq X-Received: by 2002:a17:906:ecb8:: with SMTP id qh24mr33336990ejb.162.1617094523324; Tue, 30 Mar 2021 01:55:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617094523; cv=none; d=google.com; s=arc-20160816; b=qlGrTmqrwtdMd0JEtHPlM4bwZ6erG5QJ3VGH4SLRDfMNZW9dmcwMghvaEwTf4Uh7YK ijIigAmENoW3kfWHUcvE7bDwdCmvTo6Zeqo1+JgsEJVP7sWwwXOfzdYIUr+vEVDT533u 81EV2ESB5oEMBAkcey388CVQMnSQ0g6nadhjFBChU6NNqXM55BfQgZmIlNYKA1g9jT39 MfRSIWiIW2n0gRkSytN8HF/huZdBg1hFOkLXS4aVzv/z+rfUBfOyZxTJg4CUeX4MuX3B 0JrJKWi1cWvAc96m+ZLDU4Fz6umZ9ud7fmbelhWrq/twX05K2HxWvZZCdIob0GFAKR88 j7pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=zjK96CKPYhWJsRojqqw/3kO0UdS2THfbIH/lD9qwZRI=; b=uddqAOinpYBCoZBpwkd0Ss7lFLC3JRyZsSQO8i1okhnCDJIs4crYPXFuSf8qfNA+lC yAAhpG8PS/xVp5A/1SFpuR5Sxlmphw5jCTM8Q9uX6r2dfdjtGdK7tblgq1HylvCGQBOm BT0fTSJpUVbx22jhK1XfJMRip7UguR0868I76YHTOqTlm34qLX9SYKzTDhwGHJxovDqB t1RkUPQQHYYXYX5Ddk4TYsRJfGt/5dFFASIVq+iS51N7c8+kyvIMfC8wBrFybPvBvsuM bNiM7zapXSos3+nfJuKL7Ow0X3z+3wOClZUJwdn4E3g0+Lotc5N+w/oi1JxYZOkoN1Mx wXHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=y3UM4XVZ; spf=pass (google.com: domain of linux-input-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a22si14273072edv.24.2021.03.30.01.55.23; Tue, 30 Mar 2021 01:55:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-input-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=y3UM4XVZ; spf=pass (google.com: domain of linux-input-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231124AbhC3Iyu (ORCPT + 1 other); Tue, 30 Mar 2021 04:54:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231194AbhC3Iyg (ORCPT ); Tue, 30 Mar 2021 04:54:36 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93374C061764 for ; Tue, 30 Mar 2021 01:54:35 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id b4so22621652lfi.6 for ; Tue, 30 Mar 2021 01:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zjK96CKPYhWJsRojqqw/3kO0UdS2THfbIH/lD9qwZRI=; b=y3UM4XVZ+jolBdJ/j2UQym3ri6kZusUPIXy9i/t2h7HkTqDKc8B0EH6ho6JZFnNqdY 2anbTQKIuOfI+OokvQEwlK1M561LxC3ZY5Q138ixoagINf27ZM1p4hk/GKCsVafEPrA/ snqKm8xpDjN5Levl/VI6UIZpH1JwmufJfBp8ZQ8beTP0plHsT+lB/CDusgwYMR596sOa BDYmfPmsWv6khM1A1Q98QpQ9xR6P1d6ZtXdYnR5ymNxocqlUOgLD1BFh4WM9HEf64k19 whEZdFQ4aoQ1J5ueZ/onoAH8XtuGNkbfbJVos0ufAa+/SNge2TijYNMwW/5ros+tOfE/ uB2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zjK96CKPYhWJsRojqqw/3kO0UdS2THfbIH/lD9qwZRI=; b=ZqemHoZQa6IIGG/CYi13zKjFYvikZE12r7aB8kL62lWfPuW+MnhieotGpzkpAYqjbz VgEFueHrORWTamndIDK3PmtDi+qqVTght8ljIMFpt2N572zxNSMcYdrs6rwUcup4f2Vn Y5H1BCXkQFYS4J4+AtAoOPgjBL1rGZTMzkOGZgjw0WYTFQsuQm+dfwbQ+6CKl3oEMQ8z +xubSgsAa4bBMgxAnCEba5kY+N1MVVTrmhBYNFdFKVcl+jKk939ax9W3eXYZM7FDALdh 8GizUrLq96XrdGXyYpT8oLVYe/15gZdqSWfsDvJRAgufxZ7pUCp7ocy19bryva03FFQF 0WdQ== X-Gm-Message-State: AOAM531Q+yLqD+dytuJtm7PebDxiOJiJQJPtGUxX1iY7Tx+hKvYLexIN 0NtqsLgH6xXhBqvNmIEK0qvJbA== X-Received: by 2002:a19:7412:: with SMTP id v18mr18359157lfe.234.1617094474159; Tue, 30 Mar 2021 01:54:34 -0700 (PDT) Received: from localhost.localdomain (c-14cb225c.014-348-6c756e10.bbcust.telenor.se. [92.34.203.20]) by smtp.gmail.com with ESMTPSA id 201sm2104238lfm.108.2021.03.30.01.54.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Mar 2021 01:54:33 -0700 (PDT) From: Linus Walleij To: Ferruh Yigit , Dmitry Torokhov , Javier Martinez Canillas Cc: Henrik Rydberg , linux-input@vger.kernel.org, Linus Walleij Subject: [PATCH 5/7] Input: cyttsp - Drop the phys path Date: Tue, 30 Mar 2021 10:54:22 +0200 Message-Id: <20210330085424.2244653-6-linus.walleij@linaro.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210330085424.2244653-1-linus.walleij@linaro.org> References: <20210330085424.2244653-1-linus.walleij@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org When I test to use the CY8CTMA340 with PostmarketOS I don't have any problem whatsoever in dropping this phys path, it finds and uses the touchscreen just as well. I suppose it is because userspace is using modern input libraries. I challenge the maintainers to point out a valid and still used userspace that actually need this. I say we drop it. Signed-off-by: Linus Walleij --- drivers/input/touchscreen/cyttsp_core.c | 2 -- drivers/input/touchscreen/cyttsp_core.h | 1 - 2 files changed, 3 deletions(-) -- 2.29.2 Reviewed-by: Javier Martinez Canillas diff --git a/drivers/input/touchscreen/cyttsp_core.c b/drivers/input/touchscreen/cyttsp_core.c index 84f4f1c1a220..8ae9f00e5e31 100644 --- a/drivers/input/touchscreen/cyttsp_core.c +++ b/drivers/input/touchscreen/cyttsp_core.c @@ -655,10 +655,8 @@ struct cyttsp *cyttsp_probe(const struct cyttsp_bus_ops *bus_ops, return ERR_PTR(error); init_completion(&ts->bl_ready); - snprintf(ts->phys, sizeof(ts->phys), "%s/input0", dev_name(dev)); input_dev->name = "Cypress TTSP TouchScreen"; - input_dev->phys = ts->phys; input_dev->id.bustype = bus_ops->bustype; input_dev->dev.parent = ts->dev; diff --git a/drivers/input/touchscreen/cyttsp_core.h b/drivers/input/touchscreen/cyttsp_core.h index c102a094e888..8eba9d8ba74a 100644 --- a/drivers/input/touchscreen/cyttsp_core.h +++ b/drivers/input/touchscreen/cyttsp_core.h @@ -115,7 +115,6 @@ struct cyttsp { struct device *dev; int irq; struct input_dev *input; - char phys[32]; const struct cyttsp_bus_ops *bus_ops; struct cyttsp_bootloader_data bl_data; struct cyttsp_sysinfo_data sysinfo_data;