[04/12] ARM: pxa: stargate2: Constify the software node

Message ID 20210329105047.51033-5-heikki.krogerus@linux.intel.com
State New
Headers show
Series
  • i2c: Adding support for software nodes
Related show

Commit Message

Heikki Krogerus March 29, 2021, 10:50 a.m.
Additional device properties are always just a part of a
software fwnode. If the device properties are constant, the
software node can also be constant.

Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Daniel Mack <daniel@zonque.org>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>
---
 arch/arm/mach-pxa/stargate2.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Wolfram Sang April 6, 2021, 7:39 p.m. | #1
On Mon, Mar 29, 2021 at 01:50:39PM +0300, Heikki Krogerus wrote:
> Additional device properties are always just a part of a

> software fwnode. If the device properties are constant, the

> software node can also be constant.

> 

> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> Cc: Jonathan Cameron <jic23@cam.ac.uk>

> Cc: Daniel Mack <daniel@zonque.org>

> Cc: Haojian Zhuang <haojian.zhuang@gmail.com>

> Cc: Robert Jarzmik <robert.jarzmik@free.fr>


I like to apply it soon. Can we get an ack, please?
Robert Jarzmik April 10, 2021, 8:16 a.m. | #2
Wolfram Sang <wsa@kernel.org> writes:

> On Mon, Mar 29, 2021 at 01:50:39PM +0300, Heikki Krogerus wrote:

>> Additional device properties are always just a part of a

>> software fwnode. If the device properties are constant, the

>> software node can also be constant.

>> 

>> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

>> Cc: Jonathan Cameron <jic23@cam.ac.uk>

>> Cc: Daniel Mack <daniel@zonque.org>

>> Cc: Haojian Zhuang <haojian.zhuang@gmail.com>

>> Cc: Robert Jarzmik <robert.jarzmik@free.fr>

>

> I like to apply it soon. Can we get an ack, please?

Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>


Cheers.

-- 
Robert

Patch

diff --git a/arch/arm/mach-pxa/stargate2.c b/arch/arm/mach-pxa/stargate2.c
index e2353f7dcf01a..7ad6274657686 100644
--- a/arch/arm/mach-pxa/stargate2.c
+++ b/arch/arm/mach-pxa/stargate2.c
@@ -794,6 +794,10 @@  static const struct property_entry pca9500_eeprom_properties[] = {
 	{ }
 };
 
+static const struct software_node pca9500_eeprom_node = {
+	.properties = pca9500_eeprom_properties,
+};
+
 /**
  * stargate2_reset_bluetooth() reset the bluecore to ensure consistent state
  **/
@@ -929,7 +933,7 @@  static struct i2c_board_info __initdata stargate2_i2c_board_info[] = {
 	}, {
 		.type = "24c02",
 		.addr = 0x57,
-		.properties = pca9500_eeprom_properties,
+		.swnode = &pca9500_eeprom_node,
 	}, {
 		.type = "max1238",
 		.addr = 0x35,