From patchwork Thu Apr 1 15:19:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 413626 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp656200jai; Thu, 1 Apr 2021 08:24:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwmUKolhnJXYoJQVldYSFaPamb2waZxwORsjaqTrXxmGngcCIcv4zV12pv8fzgIJR3bdUv8 X-Received: by 2002:a5d:4688:: with SMTP id u8mr10300247wrq.39.1617290692832; Thu, 01 Apr 2021 08:24:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617290692; cv=none; d=google.com; s=arc-20160816; b=aNUOmLMZGDVPqMGZTJ80RStsvDDJuX3T03cAVCDdacD9kN67h1jT/oT/al0yTHqV1u A2WNBG5PT2G9u4aK3BP3GtF1LCYzbxfBhR1fZfumuVBXD1oPxm7qLeTskX8bPllQUdkn kKVv7KAOtUohCtLoFHSCWbgekSJVFWdQzF4WOnVMerXOZtpcbt4vKzbLwx3ZmiEAAbhH NB11WMAkwpWlJeDgZUhulPhUj18pp7gGTMYGDeC/9k9trb7Jr1SjwMQFK8hTzHp5nuFM 3phS6MML9Xviqen8cYNmDQLhMe2xM5fLJGD4/9+9zSAT37lcJI4H6QPZlpi45KfFv6Ch nXzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dkim-signature; bh=5Ib6tvKLVT5OFYvHdMzx5cdtwfAJTJzvfy+jH0blGuA=; b=Zr0MyqE7IA52fSkRoMKUFrgCX+npghcusk1DyxHA7rBZcNLCB6ZLIMjNfNWQIaLiUk ZO1++13DbZzxeupTqb+N0ZbywvmE9Y1GVPidqqF0BqPn2HqdJEoYlyNEfh3E1KUgopPd Bj7WvDR1YG2pS3pOMlvx4VF61rOTBC2ojgxVjtJr5TTFbEmhlF9nyjYauyBDdSLq76W4 87Gw/JQFQu6UH0+Z92VRH2dkzNbHQuNwvGB/zdfMe/aAvYR7ZFeW4tR/KngCXr+P7NDL m1X/2muiWJrW6vPK0bgniyRnK/JeDMCIRddwyjvCswoF6pubG4n5wgLp9csdDappvJ1I gVAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=desiato.20200630 header.b=HQjdk83n; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=KiGvVnSH; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1:d65d:64ff:fe57:4e05 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from desiato.infradead.org (desiato.infradead.org. [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by mx.google.com with ESMTPS id f1si6871558wrr.63.2021.04.01.08.24.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Apr 2021 08:24:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1:d65d:64ff:fe57:4e05 as permitted sender) client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=desiato.20200630 header.b=HQjdk83n; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=KiGvVnSH; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1:d65d:64ff:fe57:4e05 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5Ib6tvKLVT5OFYvHdMzx5cdtwfAJTJzvfy+jH0blGuA=; b=HQjdk83noGqP1J7L60jUKyNQL ANEKyfbjUIgRWHpoPfbgjvUA/clg9nyRLVlSu8kx8wcUoNzSgKoc0DmM8TjCL8s6otTW44FWt+yOS I1dzSGGpbZO9p3peHRBfZsGAVl7gKX/JcGROgUnhsuERvyaJIzemqp/nDsZH0wZ9FxQGBH56e/ekO k1u/Df08BoLpLy/5YqqGj5AThX9ZmEphNi7qT+BXKzHfnoCGq0RW4u68UcmsrRoPBdneSXIlSLgZA K3neIm2iBZpXO2SnO1Wlnu3RCfHrlvaFnr18dzcMzW3xIo4KWJaYOr6cwMeoyipuG9brZyzK1ooJW FwW051Tzw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRzBa-00A0QS-IC; Thu, 01 Apr 2021 15:24:42 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRz7T-009zYJ-Ug for linux-mtd@lists.infradead.org; Thu, 01 Apr 2021 15:20:31 +0000 Received: by mail-pl1-x62a.google.com with SMTP id v8so1173068plz.10 for ; Thu, 01 Apr 2021 08:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ww076wtEw/l52B1eQC1HZmnMQQ8Ebtr9JfK+3ViX3so=; b=KiGvVnSH66DmF8HdRytw6CJzuJoS03Rgw4NS/QOUBG/qyDfowjfjPJb4Uk9rl3tzSl FrtcqDfXNAt03yv2ZbMWSkUtZVxgRqCp/FxjadzOmk0LdPRI0xK8SS0cmsm50tBLUV8D LT2bSRIZNrc7c9mY8GZxdhUIy6Sv/F6+JsIxaTreMmGzoIVgcnJMnqibzvnhl7vEeCSS l+h74kxjQjZ+K2aItGMz6rzYzSTuvOU31WEx5Tonk1xxdAIDZpUuj/fNFiz29q66gypd vbgOy/k/jbxvAJwSS59FAbQ0k7tPzSO6eZoOEiGcRgHuJj++WFr95/LbkGkaTmvTBXB+ F9IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ww076wtEw/l52B1eQC1HZmnMQQ8Ebtr9JfK+3ViX3so=; b=IgV4EFSjncSptPT/oQD0kv8s2NMk8bwhESD+pwcSb+lrlhYNdaqQGoVHho18k+mgDf srq8wQ0YZ3lkbMqG8pKODW0hVnYqf2qvGEv+tPSrLaJIFCtk6378CcjeTaBTwmtggSKY WtXgYaVyqQQNSQJlfS6kAU1xsEKzIp4LPuZ60guOW/OhhBs+WEJyjBISy+Purf58cHT3 i7YP+ldiSq9B1ZaU1CYSHW7g4cq8/YrT7nw4OXALTHXT7cLawaE/LIpC9SBmyLQkp2fe qT+JygveQSiAEylReFz1DJ7IIW6kLo1Q07q710cbEDTzrltaWFDuYmUJCWdWS78SMB5/ Io4Q== X-Gm-Message-State: AOAM531Lvwnb4tzO5Yg499Wo+FtNd43s3sUytWRK2NbGwYvVvC/qrUmw LoRIlZbzOUUvbTSSYOLA/AZHdKwZEKYv X-Received: by 2002:a17:902:c14c:b029:e5:cd82:a0b with SMTP id 12-20020a170902c14cb02900e5cd820a0bmr8410255plj.34.1617290426225; Thu, 01 Apr 2021 08:20:26 -0700 (PDT) Received: from localhost.localdomain ([103.77.37.138]) by smtp.gmail.com with ESMTPSA id l22sm6500919pjl.14.2021.04.01.08.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Apr 2021 08:20:25 -0700 (PDT) From: Manivannan Sadhasivam To: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, robh+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, boris.brezillon@collabora.com, Daniele.Palmas@telit.com, bjorn.andersson@linaro.org, Manivannan Sadhasivam Subject: [PATCH v10 4/4] mtd: rawnand: qcom: Add missing nand_cleanup() in error path Date: Thu, 1 Apr 2021 20:49:55 +0530 Message-Id: <20210401151955.143817-5-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210401151955.143817-1-manivannan.sadhasivam@linaro.org> References: <20210401151955.143817-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210401_162028_323140_4D4B86CA X-CRM114-Status: UNSURE ( 9.51 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 3.4 (+++) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Add missing nand_cleanup() in the alloc_bam_transaction() error path to cleanup the resources properly. Signed-off-by: Manivannan Sadhasivam --- drivers/mtd/nand/raw/qcom_nandc.c | 1 + 1 file changed, 1 insertion(+) Content analysis details: (3.4 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [103.77.37.138 listed in zen.spamhaus.org] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:62a listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org Add missing nand_cleanup() in the alloc_bam_transaction() error path to cleanup the resources properly. Signed-off-by: Manivannan Sadhasivam --- drivers/mtd/nand/raw/qcom_nandc.c | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c index 87c23bb320bf..fe74cf3aece5 100644 --- a/drivers/mtd/nand/raw/qcom_nandc.c +++ b/drivers/mtd/nand/raw/qcom_nandc.c @@ -2882,6 +2882,7 @@ static int qcom_nand_host_init_and_register(struct qcom_nand_controller *nandc, if (!nandc->bam_txn) { dev_err(nandc->dev, "failed to allocate bam transaction\n"); + nand_cleanup(chip); return -ENOMEM; } }